New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 823521 link

Starred by 1 user
Status: Fixed
Owner:
█ harringtond@chromium.org
Last visit > 30 days ago
Closed: Sep 10
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Eliminate PrefetchImporter

Project Member Reported by harringtond@chromium.org, Mar 19 2018 
It was conceived when we didn't want to start the OPM when Preftching was started, as it could be an expensive operation. With the task-ified model in place that is not the case anymore and that class can be removed so that core/prefetch code can call directly into core/
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3a53bdd011d456f0b4b2f918361cf372d65942b

commit f3a53bdd011d456f0b4b2f918361cf372d65942b
Author: Dan Harrington <harringtond@chromium.org>
Date: Thu Mar 29 00:41:58 2018

Move PrefetchImporterImpl under components/

The Prefetch service now depends directly on the OfflinePageModel.
Previously, we had to route access to the model through browser/.
This can be done safely because the Taskified model does not
load the entire database in memory like the previous implementation
did.

Bug:  823521 
Change-Id: I90f4ca4d3c1f9a7aeaee20e21b7f6048bb5a8777
Reviewed-on: https://chromium-review.googlesource.com/969708
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546677}
[modify] https://crrev.com/f3a53bdd011d456f0b4b2f918361cf372d65942b/chrome/browser/BUILD.gn
[modify] https://crrev.com/f3a53bdd011d456f0b4b2f918361cf372d65942b/chrome/browser/offline_pages/prefetch/prefetch_service_factory.cc
[modify] https://crrev.com/f3a53bdd011d456f0b4b2f918361cf372d65942b/chrome/test/BUILD.gn
[modify] https://crrev.com/f3a53bdd011d456f0b4b2f918361cf372d65942b/components/offline_pages/core/prefetch/BUILD.gn
[rename] https://crrev.com/f3a53bdd011d456f0b4b2f918361cf372d65942b/components/offline_pages/core/prefetch/prefetch_importer_impl.cc
[rename] https://crrev.com/f3a53bdd011d456f0b4b2f918361cf372d65942b/components/offline_pages/core/prefetch/prefetch_importer_impl.h
[rename] https://crrev.com/f3a53bdd011d456f0b4b2f918361cf372d65942b/components/offline_pages/core/prefetch/prefetch_importer_impl_unittest.cc

Comment 2 by harringtond@chromium.org, Sep 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment