New issue
Advanced search Search tips

Issue 823510 link

Starred by 1 user
Status: Verified
Owner:
eugene...@chromium.org
Closed: Mar 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 791806



Sign in to add a comment

New Download Manager needs top and left shadows for regular UI size

Project Member Reported by eugene...@chromium.org, Mar 19 2018 
App Version (from "Chrome Settings > About Chrome"): M67
iOS Version: All
Device: iPad only

Steps to reproduce: 
1.) Load https://www.barebones.com/products/bbedit/download.html
2.) Tap Download

Observed behavior: 
Left and right sides of Download Manager bar do not have shadow
Simulator Screen Shot - iPad Air 2 - 2018-03-19 at 15.35.12.png
258 KB View Download

Comment 1 by eugene...@chromium.org, Mar 19 2018

Blocking: 791806
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f3a5cdad59be9f8e0f754ef70240b0666d3190c

commit 3f3a5cdad59be9f8e0f754ef70240b0666d3190c
Author: Eugene But <eugenebut@google.com>
Date: Fri Mar 30 00:05:46 2018

Use resizable image for Download Manager background.

Previously Download Manager used infobar background shadow and white
view for the background. Now the background is image view with resizable
image. The image is different for regular and compact user interface
size.

Bug:  823510 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idfd7528cdbe2c9903e3cf23428da27b655dc80ff
Reviewed-on: https://chromium-review.googlesource.com/986720
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547031}
[modify] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/BUILD.gn
[modify] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/download_manager_view_controller.mm
[modify] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/resources/BUILD.gn
[add] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/resources/background_compact.imageset/Contents.json
[add] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/resources/background_compact.imageset/background_compact.png
[add] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/resources/background_compact.imageset/background_compact@2x.png
[add] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/resources/background_compact.imageset/background_compact@3x.png
[add] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/resources/background_regular.imageset/Contents.json
[add] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/resources/background_regular.imageset/background_regular.png
[add] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/resources/background_regular.imageset/background_regular@2x.png
[add] https://crrev.com/3f3a5cdad59be9f8e0f754ef70240b0666d3190c/ios/chrome/browser/ui/download/resources/background_regular.imageset/background_regular@3x.png

Comment 3 by eugene...@chromium.org, Mar 30 2018

Labels: ReleaseBlock-Stable M-67
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da83271f8212fb8a363c262790d32c65962ba17b

commit da83271f8212fb8a363c262790d32c65962ba17b
Author: Eugene But <eugenebut@google.com>
Date: Fri Mar 30 20:57:52 2018

Added additional left and right margins for regular size class.

In regular size class Download Manager has left and right shadows,
so all controls should have additional left and right margins.

Bug:  823510 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idfa2e452ba0b184b461771b9a3559c9be96bfcfe
Reviewed-on: https://chromium-review.googlesource.com/987292
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547261}
[modify] https://crrev.com/da83271f8212fb8a363c262790d32c65962ba17b/ios/chrome/browser/ui/download/download_manager_view_controller.mm

Comment 5 by eugene...@chromium.org, Mar 30 2018

Status: Fixed (was: Assigned)

Comment 6 by vbhatso...@chromium.org, Apr 4 2018

Status: Verified (was: Fixed)
Left and right sides of Download Manager bar have a shadow.
Verified on iPad Pro 12'5 iOS 10.3.3, iPad Pro 12'5 iOs 11.2.6 on build 67.0.3388.0Canary
►

Sign in to add a comment