New issue
Advanced search Search tips

Issue 823507 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue v8:6666
issue 819121



Sign in to add a comment

4% regression in speedometer at 543980:544012

Project Member Reported by m...@chromium.org, Mar 19 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 19 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=823507

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=3ed75cc0cd826783410f702eed93c4cccc3593a62f089eabca8e7f342d996f78


Bot(s) for this bug's original alert(s):

android-nexus7v2
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 20 2018

Cc: yangguo@chromium.org mstarzinger@chromium.org jgruber@chromium.org
Owner: jgruber@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14a9d719440000

Reland "[builtins] Remove off-heap builtins from the snapshot" by jgruber@chromium.org
https://chromium.googlesource.com/v8/v8/+/fd70917d520ea7bbcc5e401776c7dac7120c6942

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Blocking: v8:6666
 Issue 823930  has been merged into this issue.
 Issue 823932  has been merged into this issue.
Cc: nhiroki@chromium.org kouhei@chromium.org falken@chromium.org
 Issue 823933  has been merged into this issue.
Issue 824669 has been merged into this issue.
Yep, web-tooling-benchmark is what I've been using to bench locally since it's so convenient.

I haven't yet had the time to focus on these regressions. What I know so far is that indirections for constants and external references contribute. 

It's surprising though that the regressions bisect to this CL, which just switches execution from on-heap code to off-heap, binary-embedded code, without changing the code itself. There's something here that I don't understand yet.

I'm currently hacking on landing a few final CLs for the off-heap mechanism, will focus on performance once that is done (early next week). If we don't have a good perf solution in sight by mid next week, we'll flip v8_enable_embedded_builtins back to false for the next release.
Status: Duplicate (was: Assigned)
Duping this into https://crbug.com/819121. See http://goo.gl/vjjyB6 for an analysis of the current state.
Blocking: 819121
Mergedinto: 819121

Sign in to add a comment