New issue
Advanced search Search tips

Issue 823495 link

Starred by 2 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Apr 2018
Cc:
sdy@chromium.org
lgrey@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 823735



Sign in to add a comment

[MacViews] Menus interact with the run loop inconsistently

Project Member Reported by sdy@chromium.org, Mar 19 2018 
Chrome Version: 67.0.3375.0
OS: macOS

Currently, NSMenu-based menus run a nested event loop (even under MacViews) and Views-based menus do not. This can lead to unexpected behavior and test hangs.

This is a tracking bug for making the behavior consistent.

Comment 1 by tapted@chromium.org, Mar 19 2018 

Yup - I agree we should do this. Although, I'm not sure there _is_ a way to make NSMenu non-blocking... unless we run it in a background thread. Which I suppose isn't a horrible idea, so long as we are careful. A ref-counted object like MenuController (menu_controller.mm -- not the views one) is probably the right place to attack.

History: Views menus were mostly blocking too, until someone started exploring Views on Android (where menus can *never* be blocking). The push for views on Android has gone, but the work to make views menus default to async was completed. (Except on Mac).

Comment 2 by lgrey@chromium.org, Mar 20 2018

Blocking: 823735

Comment 3 by ellyjo...@chromium.org, Mar 26 2018

Labels: MacViews-Browser Target-68
MacViews triage: let's target this for M-68.

Comment 4 by ellyjo...@chromium.org, Mar 27 2018

Cc: -ellyjo...@chromium.org sdy@chromium.org
Owner: ellyjo...@chromium.org

Comment 5 by gov...@chromium.org, Mar 27 2018

Labels: M-68

Comment 6 by gov...@chromium.org, Mar 29 2018 

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

Comment 7 by ellyjo...@chromium.org, Apr 16 2018

Status: Fixed (was: Assigned)
Good news: we now use Views menus for everything, so there are no more nested run loops.
►

Sign in to add a comment