New issue
Advanced search Search tips

Issue 823493 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

window.open() doesn't show contents in Android content shell

Project Member Reported by alex...@chromium.org, Mar 19 2018

Issue description

I noticed this when a content_browsertest I wrote on https://chromium-review.googlesource.com/966988 failed on Android.  Debugging further, I found that there seems to be a generic problem with window.open() not showing the contents of the new window in Android content shell.

Repro steps:
1) Build/install/launch Android content shell:
ninja -C out/release content_shell_apk -j 2000
out/release/bin/content_shell_apk install
out/release/bin/content_shell_apk launch

2) Navigate to http://csreis.github.io/tests/window-open.html

3) Press the first "Open simple window" button, which window.opens a same-site page.

Expected: the new window shows "Simple page"

Actual: the new window shows up blank.

I noticed that pressing on the address bar will will make the contents of the new window show up.  Similarly, rotating the device will also make it show up.

Adding boliu@ and a few people from content/browser/android/OWNERS, hoping that someone knows how to triage this.
 

Comment 1 by boliu@chromium.org, Mar 19 2018

compositor output isn't visible before the resize for some reason (no debug borders whatsoever) maybe the surfaceview isn't set up correctly or something. rotation or bringing up the viewport both causes a resize which then regiggles things enough to fix it

Comment 2 by boliu@chromium.org, Mar 20 2018

Owner: boliu@chromium.org
Status: Assigned (was: Available)
Fix: https://chromium-review.googlesource.com/c/chromium/src/+/971721
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd41a8d4554a2ed2de2648045a20830d9905c672

commit bd41a8d4554a2ed2de2648045a20830d9905c672
Author: Bo Liu <boliu@chromium.org>
Date: Wed Mar 21 00:00:03 2018

android: Fix blank popup in content shell

Issue is the pop up flow does not cause the webcontents to be resized.

Bug:  823493 
Change-Id: I2dff1b533aea3b641aa854a0e0d2e0eb9744b143
Reviewed-on: https://chromium-review.googlesource.com/971721
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544591}
[modify] https://crrev.com/bd41a8d4554a2ed2de2648045a20830d9905c672/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

Comment 4 by boliu@chromium.org, Mar 21 2018

Status: Fixed (was: Assigned)

Sign in to add a comment