Issue metadata
Sign in to add a comment
|
interactive_ui_tests MacViews [NSThemeFrame _reacquireToolbarViewFromFullScreenWindowAndShow:] Assert Failure |
||||||||||||||||||||||
Issue description
Tests: BrowserViewTest.FullscreenClearsFocus
ExclusiveAccessBubbleViewsTest.NativeClose
Assertion failed: ([self.titlebarContainerView superview] == nil), function -[NSThemeFrame _reacquireToolbarViewFromFullScreenWindowAndShow:], file /BuildRoot/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1561.20.106/AppKit.subproj/NSThemeFrame.m, line 7805.
Received signal 6
0 libbase.dylib 0x000000011dd9f3de base::debug::StackTrace::StackTrace(unsigned long) + 174
1 libbase.dylib 0x000000011dd9f49d base::debug::StackTrace::StackTrace(unsigned long) + 29
2 libbase.dylib 0x000000011dd9d94c base::debug::StackTrace::StackTrace() + 28
3 libbase.dylib 0x000000011dd9f1cf base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 1407
4 libsystem_platform.dylib 0x00007fff5bad3f5a _sigtramp + 26
5 ??? 0x00007fd8ad92e990 0x0 + 140568601749904
6 libsystem_c.dylib 0x00007fff5b8fe312 abort + 127
7 libsystem_c.dylib 0x00007fff5b8c6368 basename_r + 0
8 AppKit 0x00007fff31755a79 -[NSThemeFrame _reacquireToolbarViewFromFullScreenWindowAndShow:] + 621
9 AppKit 0x00007fff31fecf70 -[NSWindow(NSFullScreen) _cleanupAndRemoveFullScreenContentController] + 78
10 AppKit 0x00007fff31fee956 -[NSWindow(NSFullScreen) _fullScreenStatusChanged] + 374
11 AppKit 0x00007fff3167a82b __25-[NSWindow setStyleMask:]_block_invoke + 2178
12 AppKit 0x00007fff3159a018 NSPerformVisuallyAtomicChange + 146
13 AppKit 0x00007fff31679f60 -[NSWindow setStyleMask:] + 191
14 AppKit 0x00007fff31af6c22 -[_NSWindowExitFullScreenTransitionController setupWindowForAfterFullScreenExit] + 106
15 AppKit 0x00007fff31ddfb8c __46-[_NSExitFullScreenTransitionController start]_block_invoke.268 + 57
16 libdispatch.dylib 0x00007fff5b820591 _dispatch_call_block_and_release + 12
17 libdispatch.dylib 0x00007fff5b818d50 _dispatch_client_callout + 8
18 libdispatch.dylib 0x00007fff5b82432d _dispatch_main_queue_callback_4CF + 1148
19 CoreFoundation 0x00007fff33edab49 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
20 CoreFoundation 0x00007fff33e9d43a __CFRunLoopRun + 2586
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16df02b6ee4f6d6f393dabe1100e413b24f198ec commit 16df02b6ee4f6d6f393dabe1100e413b24f198ec Author: Robert Liao <robliao@chromium.org> Date: Wed Mar 21 16:41:43 2018 Disable Views Tests That Hit A Mac Internal Assert BUG= 823490 Change-Id: I034afe4ed185cb7856f34666acaf24aae2084c70 Reviewed-on: https://chromium-review.googlesource.com/972552 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544731} [modify] https://crrev.com/16df02b6ee4f6d6f393dabe1100e413b24f198ec/chrome/browser/ui/views/exclusive_access_bubble_views_interactive_uitest.cc [modify] https://crrev.com/16df02b6ee4f6d6f393dabe1100e413b24f198ec/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
,
Mar 21 2018
,
Mar 22 2018
,
May 11 2018
up-duping - the stuff in Issue 824757 is fixed, but ExclusiveAccessBubbleViewsTest.NativeClose is still disabled.
,
Jun 19 2018
,
Jul 12
,
Sep 21
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf6dfbb041cb6d9e75283ea5968c8f8bebcfb230 commit cf6dfbb041cb6d9e75283ea5968c8f8bebcfb230 Author: Wei Li <weili@chromium.org> Date: Mon Sep 24 17:27:09 2018 Reenable two disabled interactive_ui_tests These two tests were disabled due to assertion failures on Cocoa call stack. By porting fullscreen code to Views, we no longer call into such functions. With some minor improvement -- adding initial preference setup, the tests should pass. BUG= 823490 Change-Id: I9b3c7838d1502c52a2da8cbc4a954ae9f8e71da7 Reviewed-on: https://chromium-review.googlesource.com/1239356 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#593582} [modify] https://crrev.com/cf6dfbb041cb6d9e75283ea5968c8f8bebcfb230/chrome/browser/ui/views/exclusive_access_bubble_views_interactive_uitest.cc [modify] https://crrev.com/cf6dfbb041cb6d9e75283ea5968c8f8bebcfb230/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
,
Sep 24
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by robliao@chromium.org
, Mar 19 2018