Failure log -

java.lang.AssertionError: Sync data criteria not met.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:93)
	at org.chromium.chrome.browser.sync.SyncTestRule.pollInstrumentationThread(SyncTestRule.java:199)
	at org.chromium.chrome.browser.sync.BookmarksTest.testUploadMovedBookmark(BookmarksTest.java:335)
	at java.lang.reflect.Method.invoke(Method.java)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.chromium.chrome.browser.sync.SyncTestRule$7.evaluate(SyncTestRule.java:238)
	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:113)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.chromium.chrome.browser.sync.SyncTestRule$8.evaluate(SyncTestRule.java:245)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:201)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:43)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:183)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:103)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)

Since this has been flaking for some while now, will proceed to disable it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8025d64261a4678509acd5afa458a337a02382f5

commit 8025d64261a4678509acd5afa458a337a02382f5
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Tue Mar 20 00:57:54 2018

Mark BookmarksTest#testUploadMovedBookmark as flaky.

BUG= 823484 
TBR=nyquist@chromium.org

Change-Id: I5f0aac3a43b938ebdc5e6eaae12c21688378e8ef
Reviewed-on: https://chromium-review.googlesource.com/969793
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544237}
[modify] https://crrev.com/8025d64261a4678509acd5afa458a337a02382f5/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java

+mamir who works on bookmark sync

Detected 8 new flakes for test/step "org.chromium.chrome.browser.sync.BookmarksTest#testUploadMovedBookmark". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUQsSBUZsYWtlIkZvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuc3luYy5Cb29rbWFya3NUZXN0I3Rlc3RVcGxvYWRNb3ZlZEJvb2ttYXJrDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Gonna disable the test.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/029250d4863742e3347169b2ca180dbd07f3a8e6

commit 029250d4863742e3347169b2ca180dbd07f3a8e6
Author: Alexander Potapenko <glider@google.com>
Date: Wed Mar 21 13:39:38 2018

Disable BookmarksTest#testUploadMovedBookmark

It has been flaky for too long.

BUG= 823484 
TBR=nyquist@chromium.org,mamir@chromium.org

Change-Id: Iee085516ea05d98d3fddd6620005818a822bc0ab
Reviewed-on: https://chromium-review.googlesource.com/973223
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544683}
[modify] https://crrev.com/029250d4863742e3347169b2ca180dbd07f3a8e6/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ead171ec2c8a68cc0e14fcfebd118b9384105348

commit ead171ec2c8a68cc0e14fcfebd118b9384105348
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Thu Nov 22 17:23:36 2018

[Sync] Re-enable a flaky testUploadMovedBookmark() test

The test
org.chromium.chrome.browser.sync.BookmarksTest#testUploadMovedBookmark
has been disabled for long time due to
flakiness.

This CL does the following:
1- Adds an assert() that's missing from the test start up.
2- Enables the test.

The plan is to enable it again to get measurements for how long it
takes to fail and pass to rule out a time-out problem.

The flakiness dashboard has been replaced with a newer one since the
reporting of the attached bug.

TBR=mastiz@chromium.org

Bug:  823484 
Change-Id: I827ff84ad953c56f01619b4aa07643714d0ffc6f
Reviewed-on: https://chromium-review.googlesource.com/c/1348116
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610449}
[modify] https://crrev.com/ead171ec2c8a68cc0e14fcfebd118b9384105348/chrome/android/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ff75e5f6375e3b97b61117ad33b5e395d7f188d

commit 9ff75e5f6375e3b97b61117ad33b5e395d7f188d
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Fri Nov 23 11:27:06 2018

Revert "[Sync] Re-enable a flaky testUploadMovedBookmark() test"

This reverts commit ead171ec2c8a68cc0e14fcfebd118b9384105348.

Reason for revert: Test is still flaky.

Original change's description:
> [Sync] Re-enable a flaky testUploadMovedBookmark() test
> 
> The test
> org.chromium.chrome.browser.sync.BookmarksTest#testUploadMovedBookmark
> has been disabled for long time due to
> flakiness.
> 
> This CL does the following:
> 1- Adds an assert() that's missing from the test start up.
> 2- Enables the test.
> 
> The plan is to enable it again to get measurements for how long it
> takes to fail and pass to rule out a time-out problem.
> 
> The flakiness dashboard has been replaced with a newer one since the
> reporting of the attached bug.
> 
> TBR=mastiz@chromium.org
> 
> Bug:  823484 
> Change-Id: I827ff84ad953c56f01619b4aa07643714d0ffc6f
> Reviewed-on: https://chromium-review.googlesource.com/c/1348116
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610449}

TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org

Change-Id: I0d56f7d5f7590e9c15abbd4392ebfd75c987ca6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  823484 
Reviewed-on: https://chromium-review.googlesource.com/c/1349333
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610571}
[modify] https://crrev.com/9ff75e5f6375e3b97b61117ad33b5e395d7f188d/chrome/android/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d6654b8306785e4ed63b7c1c2993cb4826bd0c1

commit 9d6654b8306785e4ed63b7c1c2993cb4826bd0c1
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Sat Nov 24 07:50:33 2018

[Sync] Fix flaky test testUploadMovedBookmark()

The test was flaky because it uses folder information to identify
different entities. However, the code didn't properly populate the
folder information for entities from the server.

This CL fixes that and renables the test

Bug:  823484 
Change-Id: Ia6fcb82fe69ce5f6f79866929f98cba24d3eac3d
Reviewed-on: https://chromium-review.googlesource.com/c/1349657
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610697}
[modify] https://crrev.com/9d6654b8306785e4ed63b7c1c2993cb4826bd0c1/chrome/android/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java

The NextAction date has arrived: 2018-12-03