interactive_ui_tests + MacViews BrowserCommandControllerInteractiveTest.KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11 |
||||||||||||||
Issue descriptionBrowserCommandControllerInteractiveTest.KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11 [FullscreenToolbarController enterFullscreenMode] when _inFullscreenMode_ is YES. Check failed: !inFullscreenMode_.
,
Mar 21 2018
This is passing locally and on the bot, so I'm assuming it got fixed by something else
,
Mar 21 2018
Some of these are flaky, so I'd keep an eye out on this one.
,
Mar 21 2018
This is still DCHECK'ing for me as of Wed Mar 21 17:03:40 2018 +0000 68f5aab1de53ef35ec92eddbe59d3155e3db53b6
,
Mar 22 2018
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31d079820cf4b53ccb2319b93aa8a4401dc8112d commit 31d079820cf4b53ccb2319b93aa8a4401dc8112d Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 22 12:50:40 2018 Disable Test on MacViews - BrowserCommandControllerInteractiveTest.KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11 BUG=823478 Change-Id: I926882274251a6ba554594f993f82cec9bd26cbe Reviewed-on: https://chromium-review.googlesource.com/974452 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545048} [modify] https://crrev.com/31d079820cf4b53ccb2319b93aa8a4401dc8112d/chrome/browser/ui/browser_command_controller_interactive_browsertest.cc
,
Mar 23 2018
,
Mar 26 2018
,
Apr 13 2018
,
Apr 17 2018
,
Apr 25 2018
Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
,
Jun 20 2018
,
Jul 12
,
Jul 12
,
Jul 26
,
Jul 26
,
Jan 9
I've been looking some at this test. It looks like it enters real, actual fullscreen - the JS "fullscreen" keypress leads back to Widget::SetFullscreen() which creates a real _NSWindowEnterFullScreenTransitionController. We then appear to exit it via the fake fullscreen path, which accidentally "works", but doesn't know that in this case a real transition is happening which is asynchronous. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by lgrey@chromium.org
, Mar 21 2018Status: Assigned (was: Available)