New issue
Advanced search Search tips

Issue 823476 link

Starred by 1 user
Status: Fixed
Owner:
steimel@chromium.org
Closed: Mar 2018
Cc:
beccahughes@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Modern Media Controls: Don't go into fullscreen on double tap before preloading

Project Member Reported by steimel@chromium.org, Mar 19 2018 
On modern media controls, we go into fullscreen when the user double-clicks on the video. This allows the user to go fullscreen even when the fullscreen button is disabled (before preloading metadata). We should not go fullscreen in this case
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0701fde7ec45cb948452b9983ce9c03bcae869fe

commit 0701fde7ec45cb948452b9983ce9c03bcae869fe
Author: Tommy Steimel <steimel@chromium.org>
Date: Fri Mar 23 23:54:24 2018

Dont go into fullscreen on doubleclick before preload

This CL adds a check in the overlay play button double-click code to
make sure the user should be able to toggle fullscreen before actually
toggling.

Bug:  823476 
Change-Id: I8d61292516ed4b385f732f9259ed262b4685a314
Reviewed-on: https://chromium-review.googlesource.com/972347
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545632}
[add] https://crrev.com/0701fde7ec45cb948452b9983ce9c03bcae869fe/third_party/WebKit/LayoutTests/media/controls/modern/video-does-not-go-fullscreen-on-double-click-before-preload.html
[modify] https://crrev.com/0701fde7ec45cb948452b9983ce9c03bcae869fe/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/0701fde7ec45cb948452b9983ce9c03bcae869fe/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/0701fde7ec45cb948452b9983ce9c03bcae869fe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp

Comment 2 by steimel@chromium.org, Mar 24 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment