Unminimized window existing tablet mode is minimized |
|||
Issue description1) Open a maximized Chrome window. 2) Minimize it by pressing the horizontal underscore icon at the upper right (next to the maximize icon). 3) Go into tablet mode. 4) Touch the Chrome icon on the shelf to open the window 5) Go out of tablet mode. Since we have unminimized window in tablet mode, we shall also have unminimized window state when existing tablet mode. issue is from #50 in issue 783310 .
,
Mar 23 2018
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74e2582a9fd6ad68fe0136c353bef26b93f16b72 commit 74e2582a9fd6ad68fe0136c353bef26b93f16b72 Author: Qiang Xu <warx@google.com> Date: Fri Mar 23 00:04:15 2018 cros: sync unminimized state when attaching state if necessary changes: When attaching state, if previous state is unminimized but the stored window state is minimized, we should sync the state to unminimized state, which is determined by pre-minimized window show state. Bug: 823469 , 783310 , 811352 Test: manual test and added test coverage Change-Id: I32a4e119e12ebefa015713ac535768880d8b4832 Reviewed-on: https://chromium-review.googlesource.com/969621 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#545295} [modify] https://crrev.com/74e2582a9fd6ad68fe0136c353bef26b93f16b72/ash/wm/default_state.cc [modify] https://crrev.com/74e2582a9fd6ad68fe0136c353bef26b93f16b72/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ae7191a947988481fe20950e59830786915635b commit 8ae7191a947988481fe20950e59830786915635b Author: Qiang Xu <warx@google.com> Date: Mon Mar 26 16:45:27 2018 m66 merge: cros: sync unminimized state when attaching state if necessary changes: When attaching state, if previous state is unminimized but the stored window state is minimized, we should sync the state to unminimized state, which is determined by pre-minimized window show state. TBR=oshima@chromium.org (cherry picked from commit 74e2582a9fd6ad68fe0136c353bef26b93f16b72) Bug: 823469 , 783310 , 811352 Test: manual test and added test coverage Change-Id: I32a4e119e12ebefa015713ac535768880d8b4832 Reviewed-on: https://chromium-review.googlesource.com/969621 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Original-Commit-Position: refs/heads/master@{#545295} Reviewed-on: https://chromium-review.googlesource.com/980824 Reviewed-by: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/branch-heads/3359@{#434} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/8ae7191a947988481fe20950e59830786915635b/ash/wm/default_state.cc [modify] https://crrev.com/8ae7191a947988481fe20950e59830786915635b/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by warx@chromium.org
, Mar 23 2018