New issue
Advanced search Search tips

Issue 823460 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Stop logging VLOG(1) from all ARC code in Chrome

Project Member Reported by derat@chromium.org, Mar 19 2018

Issue description

When I look at the Chrome user log from a system with ARC enabled, it has a lot of useless-seeming repetitive messages from ARC:

[1208:1208:0312/100841.968225:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.968430:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.970634:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.972971:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.973327:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.973661:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.974256:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.974789:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.975007:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.975249:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.975805:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.976317:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.976635:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.976842:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.977156:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.977648:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.978072:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.978259:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.978423:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.978575:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.979344:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.979823:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.980177:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.980546:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.981420:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.981895:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.982337:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
[1208:1208:0312/100841.982839:VERBOSE1:arc_net_host_impl.cc(754)] New default network: /service/1 (wifi)
...
[1208:1208:0312/120248.375032:VERBOSE1:arc_net_host_impl.cc(746)] No default network
[1208:1208:0312/120248.375226:VERBOSE1:arc_net_host_impl.cc(746)] No default network
[1208:1208:0312/120248.375816:VERBOSE1:arc_net_host_impl.cc(746)] No default network
...
[1208:1208:0312/120248.376409:VERBOSE1:arc_net_host_impl.cc(746)] No default network
[1208:1208:0312/120248.395736:VERBOSE1:arc_net_host_impl.cc(746)] No default network
...
[1208:1208:0312/120249.078747:VERBOSE1:arc_net_host_impl.cc(746)] No default network
[1208:1208:0312/120249.079194:VERBOSE1:arc_net_host_impl.cc(746)] No default network
[1208:1208:0312/120249.158457:VERBOSE1:arc_net_host_impl.cc(746)] No default network

These get logged because of this code in session_manager's chrome_setup.cc:

  if (builder->UseFlagIsSet("cheets"))
    builder->AddVmodulePattern("*arc/*=1");

Luis, I think that you added this for  issue 606081 . Can we remove it now or at least replace it with a more-targeted pattern?

Most of the VLOG calls in arc_net_host_impl.cc look like they were just added to provide debugging info while the code was being written. In general, I think that that matches people's expectations when using VLOG(1) -- it's okay to enable these as a last resort for tracking down a tricky bug, but we shouldn't enable them indefinitely across the board for entire subdirectories of Chrome code.
 
Owner: yusukes@chromium.org

Sign in to add a comment