New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823454 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Make repair tasks check/update DUT labels

Reported by jrbarnette@chromium.org, Mar 19 2018

Issue description

Repair special tests should include running automated label
detection/assignment.  There are at least two reasons:
  * From time to time, we find that DUTs can acquire incorrect
    labels due to prior errors.  When that happens, we need a way
    to force running label detection.  Running repair is an easy
    way to deal with that.
  * If repair fixes a DUT that's been out of service for some
    period of time, its labels may become out of date.  So, repair
    should make sure the labels are accurate.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/15b78cf68518521fc33a34b57c4d343f160d5842

commit 15b78cf68518521fc33a34b57c4d343f160d5842
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Tue Mar 20 04:34:28 2018

[autotest] Update labels during repair

After we run repair, if the repair proper succeeded, attempt to update
host labels.

BUG= chromium:823454 
TEST=None

Change-Id: If8dbd2c0b5a45188ac103fc1732827c83be80143
Reviewed-on: https://chromium-review.googlesource.com/969615
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/15b78cf68518521fc33a34b57c4d343f160d5842/server/control_segments/repair

Status: Fixed (was: Started)
This should be done, except for the push to prod.  Heaven only
knows when that will happen, but it should be before the next
time that we need the feature.
Status: Started (was: Fixed)
Not really fixed:
    http://crrev.com/c/1045915
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7cd9c5c46a49d77b375c01d40b1e46b4adf877cf

commit 7cd9c5c46a49d77b375c01d40b1e46b4adf877cf
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Tue May 08 00:24:02 2018

[autotest] Fix updating labels in repair.

A previous change was meant to force labels to be updated after a
successful repair.  That change never worked.  This fixes it.

BUG= chromium:823454 
TEST=run repair in a local instance, see label updates run

Change-Id: I8e7b406c18538ea6c409f387c8b0cc96112fe760
Reviewed-on: https://chromium-review.googlesource.com/1045915
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/7cd9c5c46a49d77b375c01d40b1e46b4adf877cf/server/control_segments/repair

Status: Verified (was: Started)
Confirmed fixed this time.  Sample repair task, with logs showing
the label detection code running:
    https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/hosts/chromeos6-row4-rack11-host2/1105670-repair/20182305112909/debug/

Sign in to add a comment