New issue
Advanced search Search tips

Issue 823449 link

Starred by 1 user
Status: Fixed
Owner:
csharrison@chromium.org
Closed: Mar 2018
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

SubresourceFilterFeaturesTest.AdTaggingDisabled_DisablesDryRun fails on iOS

Project Member Reported by asvitk...@chromium.org, Mar 19 2018 
SubresourceFilterFeaturesTest.AdTaggingDisabled_DisablesDryRun fails on iOS

[ RUN      ] SubresourceFilterFeaturesTest.AdTaggingDisabled_DisablesDryRun
../../components/subresource_filter/core/browser/subresource_filter_features_unittest.cc:747: Failure
Value of: base::ContainsValue( GetEnabledConfigurations()->configs_by_decreasing_priority(), dryrun)
  Actual: true
Expected: false

Sending a CL to disable on iOS.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab87e8395193436b96549d1dba0e0eecd0b4a6aa

commit ab87e8395193436b96549d1dba0e0eecd0b4a6aa
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Mon Mar 19 21:51:55 2018

Fix SyntheticTrialRegistryTest on iOS and disable two other tests.

Tests disabled on iOS:
  VariationsCrashKeysTest.BasicFunctionality
  SubresourceFilterFeaturesTest.AdTaggingDisabled_DisablesDryRun

The other two tests are already failing, but are being masked by
the SyntheticTrialRegistryTest failure which is crashing the test
harness. Disabling them in this CL to green up the bots and they
can be investigated/fixed separately.

Bug: 821162,  823449 
Change-Id: Id6200cb1e5b086a8ee36babc669b408a16c1f5bb
Reviewed-on: https://chromium-review.googlesource.com/969610
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544175}
[modify] https://crrev.com/ab87e8395193436b96549d1dba0e0eecd0b4a6aa/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
[modify] https://crrev.com/ab87e8395193436b96549d1dba0e0eecd0b4a6aa/components/variations/child_process_field_trial_syncer_unittest.cc
[modify] https://crrev.com/ab87e8395193436b96549d1dba0e0eecd0b4a6aa/components/variations/variations_crash_keys_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bfe0457768b4f6838bbb7fbd0462c55ccbea7af

commit 9bfe0457768b4f6838bbb7fbd0462c55ccbea7af
Author: Charles Harrison <csharrison@chromium.org>
Date: Tue Mar 20 20:43:11 2018

[subresource_filter] Clear global state on test start

Bug:  823449 
Change-Id: Ia92871cf688ac106234b2a83d68d07ce07a5aabf
Reviewed-on: https://chromium-review.googlesource.com/971703
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544512}
[modify] https://crrev.com/9bfe0457768b4f6838bbb7fbd0462c55ccbea7af/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc

Comment 3 by csharrison@chromium.org, Mar 20 2018

Status: Fixed (was: Untriaged)
Should be fixed, thanks Alexei
►

Sign in to add a comment