The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef3491956e191521250de2b1374d5ea073cb2e65

commit ef3491956e191521250de2b1374d5ea073cb2e65
Author: Charlie Harrison <csharrison@chromium.org>
Date: Fri Jul 13 18:23:01 2018

[subresource_filter] Clean up the setting manager metrics

content_settings::Observers are not robust enough for metrics capture.
A few problems:
1. It is impossible to tell if a setting change is meaningful
   (e.g. BLOCK -> BLOCK vs BLOCK -> ALLOW)

2. Some WebUIs trigger duplicate calls into observers

If crbug.com/706061 is fixed, we can probably re-add some of this code.
In the meantime, I will add a metric or two to the Android Preference
UI, where we really need it and can log what we care about directly.

This CL also cleans up and versions the SubresourceFilter.Actions
histogram, which has a bunch of deprecated / not useful buckets.

TBR=msw@chromium.org

Bug:  823415 
Change-Id: If2d42520b226b21b6a8e875876d733ea32656b11
Reviewed-on: https://chromium-review.googlesource.com/1081370
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574985}
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/subresource_filter/subresource_filter_content_settings_manager.cc
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/subresource_filter/subresource_filter_content_settings_manager.h
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/subresource_filter/subresource_filter_settings_browsertest.cc
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/ui/android/content_settings/ads_blocked_infobar_delegate.cc
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ef3491956e191521250de2b1374d5ea073cb2e65/tools/metrics/histograms/histograms.xml

This was "fixed" by just removing the content settings metrics.