New issue
Advanced search Search tips

Issue 823411 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Consider moving the ad filter's safe browsing client into safe_browsing

Project Member Reported by csharrison@chromium.org, Mar 19 2018 
There are now two components that are clients of the subresource_filter specific Safe Browsing check: the popup blocker and the ad filter code.

It would be nice to move this navigation check (handled currently via a NavigationThrottle) into Safe Browsing proper, so that popup blocker code doesn't need to depend on ad filter code.

This check is implemented in subresource_filter_safe_browsing_activation_throttle.cc.

It is my understanding that in the network service world, SafeBrowsing navigation checks will be handled by a NavigationThrottle. Possibly this integration could integrate with that work.

Varun: WDYT about this?

Comment 1 by vakh@chromium.org, Apr 6 2018 

That sounds like a good idea. Do you have a design in mind that you can share?

Comment 2 by vakh@chromium.org, Apr 6 2018

Owner: csharrison@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by vakh@chromium.org, Apr 6 2018

Labels: SafeBrowsing-Triaged

Comment 4 by csharrison@chromium.org, Apr 6 2018

Owner: ----
Status: Available (was: Assigned)
I can work on a design. I wanted to avoid doing a lot of design if the team was opposed in general.

I'm marking this as available since I don't have immediate plans to do it, but someone on my team might.
►

Sign in to add a comment