Show disabled fullscreen and mute button on modern media controls when preload=none Rough mock here (ignore time display): https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZZIx9p6vbtpx/files/MCHtA7U1iMGr69laPZDCC2xNn8G12BWoPZA
Here are a couple of screenshots from patchset 1 of crrev.com/c/969952
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b22949e7898505dc848f3b1478e01773c62c477 commit 0b22949e7898505dc848f3b1478e01773c62c477 Author: Tommy Steimel <steimel@chromium.org> Date: Thu Mar 22 18:21:20 2018 Show disabled fullscreen and mute buttons on modern media controls This CL modifies the modern media controls on videos with preload=none to show disabled fullscreen and mute buttons instead of hiding them completely. Bug: 823401 Change-Id: I853ec4bd216e5c63018750d03b81ea96e74e3fc6 Reviewed-on: https://chromium-review.googlesource.com/969952 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#545162} [add] https://crrev.com/0b22949e7898505dc848f3b1478e01773c62c477/third_party/WebKit/LayoutTests/media/controls/modern/video-preload-none-has-disabled-controls.html [modify] https://crrev.com/0b22949e7898505dc848f3b1478e01773c62c477/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/0b22949e7898505dc848f3b1478e01773c62c477/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/0b22949e7898505dc848f3b1478e01773c62c477/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h [modify] https://crrev.com/0b22949e7898505dc848f3b1478e01773c62c477/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0a56923f2cac27a016e51c541ff9afe17b9909b commit d0a56923f2cac27a016e51c541ff9afe17b9909b Author: Tommy Steimel <steimel@chromium.org> Date: Tue Mar 27 21:15:31 2018 Only show elements in the overflow menu if they are not disabled This CL prevents disabled elements from showing up in the overflow menu for modern media controls. This fixes a bug where the disabled fullscreen and mute buttons were showing up (enabled) in the overflow menu when the video was small enough. Bug: 823401 Change-Id: I56731e929e1d4f700eb007348183829a3a0aa2ee Reviewed-on: https://chromium-review.googlesource.com/978954 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#546262} [add] https://crrev.com/d0a56923f2cac27a016e51c541ff9afe17b9909b/third_party/WebKit/LayoutTests/media/controls/modern/dont-show-disabled-controls-in-overflow.html [modify] https://crrev.com/d0a56923f2cac27a016e51c541ff9afe17b9909b/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/d0a56923f2cac27a016e51c541ff9afe17b9909b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/d0a56923f2cac27a016e51c541ff9afe17b9909b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDivElement.cpp [modify] https://crrev.com/d0a56923f2cac27a016e51c541ff9afe17b9909b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDivElement.h [modify] https://crrev.com/d0a56923f2cac27a016e51c541ff9afe17b9909b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h [modify] https://crrev.com/d0a56923f2cac27a016e51c541ff9afe17b9909b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp [modify] https://crrev.com/d0a56923f2cac27a016e51c541ff9afe17b9909b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h
Comment 1 by steimel@chromium.org
, Mar 20 201810.3 KB
10.3 KB View Download
10.7 KB
10.7 KB View Download