New issue
Advanced search Search tips

Issue 823393 link

Starred by 1 user
Status: Fixed
Owner:
samans@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Present Tab (chrome) with High FPS received presentation flickers a lot and shows black rectangle visual artifacts

Project Member Reported by samans@chromium.org, Mar 19 2018 
This bug was filed externally.

Chrome Version: Canary 67.0.3371 
OS: Windows

What steps will reproduce the problem?
(1) Join a meeting with at least one other participant.
(2) Start a presentation of Chrome TAB and select a Chrome browser tab.

What is the expected result?
Participants receiving the chrome tab stream show visual flickering and black rectangular artifact.

What happens instead?
No artifacts and/or flickering - clean stream w/o artifacts.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/240c7447c670a33fdac023ea317b23bc90807874

commit 240c7447c670a33fdac023ea317b23bc90807874
Author: Saman Sami <samans@chromium.org>
Date: Tue Mar 20 02:51:57 2018

Fix capturing of background tabs

CopyOutputRequests must be taken from CompositorFrameSinkSupport before
SurfaceAggregator::copy_request_passes_ is populated. This broke at
http://crrev.com/99f8d9a.

Bug:  823393 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I2ee6130e66be5b0a0943df87cd22b40d4e9217c1
Reviewed-on: https://chromium-review.googlesource.com/969503
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544269}
[modify] https://crrev.com/240c7447c670a33fdac023ea317b23bc90807874/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/240c7447c670a33fdac023ea317b23bc90807874/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/240c7447c670a33fdac023ea317b23bc90807874/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/240c7447c670a33fdac023ea317b23bc90807874/components/viz/service/surfaces/surface.h
[modify] https://crrev.com/240c7447c670a33fdac023ea317b23bc90807874/components/viz/service/surfaces/surface_unittest.cc

Comment 2 by samans@chromium.org, Mar 23 2018

Status: Fixed (was: Started)
►

Sign in to add a comment