New issue
Advanced search Search tips

Issue 823386 link

Starred by 1 user
Status: Fixed
Owner:
smcgruer@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 772407



Sign in to add a comment

Web Animations: Remove timing objects

Project Member Reported by smcgruer@chromium.org, Mar 19 2018 
The upstream spec has removed the timing objects (https://github.com/w3c/csswg-drafts/pull/2432 ); we should follow suit.

Summary of relevant changes:

  * Replaced the timing member of AnimationEffectReadOnly with the getTiming() and updateTiming() methods on AnimationEffect.
  * Removed the AnimationEffectTimingReadOnly and AnimationEffectTiming interfaces.
  * Renamed the AnimationEffectTimingProperties dictionary to EffectTiming.
  * Renamed the ComputedTimingProperties dictionary to ComputedEffectTiming.
  * Introduced the OptionalEffectTiming dictionary for use with the updateTiming() method.

Comment 1 by smcgruer@chromium.org, Mar 20 2018

Description: Show this description

Comment 2 by smcgruer@chromium.org, Mar 26 2018

Status: Start (was: Assigned)

Comment 3 by smcgruer@chromium.org, Mar 26 2018

Status: Started (was: start)

Comment 4 by smcgruer@chromium.org, Mar 31 2018

Blocking: 772407
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aebffa30d259f1a0252818d2425c1fbf2fb13cd8

commit aebffa30d259f1a0252818d2425c1fbf2fb13cd8
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Apr 05 13:25:01 2018

Web Animations: remove timing objects

The upstream spec has removed the 'timing' objects and replaced them
with updateTiming/getTiming methods on AnimationEffect. It also removed
and renamed a few timing idl interfaces; see the bug for full details.

This CL also refactors the timing input parsing, aiming to make the
public TimingInput API match what the spec requires and not expose
other unnecessary methods.

See https://github.com/w3c/csswg-drafts/pull/2432 for the spec change.

Bug:  823384 ,  823386 
Change-Id: I40c82e46be29c16e2e4b53d69bbadc95c8bff324
Reviewed-on: https://chromium-review.googlesource.com/975923
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548403}
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/animations/multiple-same-name-css-animations.html
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/animations/web-animations/KeyframeEffect-animation.html
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/animations/web-animations/api-readonly-object-types.html
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/css/css-timing/cubic-bezier-timing-functions-output.html
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animatable/animate-expected.txt
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animatable/getAnimations-expected.txt
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animation/cancel-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animation/finished-expected.txt
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationEffect/updateTiming-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/copy-constructor-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/web-animations/timing-model/animation-effects/phases-and-states-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/AnimationEffect.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/AnimationEffect.h
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/AnimationEffect.idl
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/AnimationEffectTest.cpp
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/Source/core/animation/AnimationEffectTiming.h
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.cpp
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.h
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/BUILD.gn
[rename] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/ComputedEffectTiming.idl
[rename] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/EffectTiming.idl
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/ElementAnimation.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/KeyframeEffect.h
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/KeyframeEffectOptions.idl
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
[add] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/OptionalEffectTiming.idl
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/TimingInput.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/TimingInput.h
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Comment 6 by smcgruer@chromium.org, Apr 5 2018

Status: Fixed (was: Started)
►

Sign in to add a comment