New issue
Advanced search Search tips

Issue 823384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 772407



Sign in to add a comment

Web Animations: Remove *ReadOnly interfaces

Project Member Reported by smcgruer@chromium.org, Mar 19 2018

Issue description

The upstream spec has removed the *ReadOnly interfaces (https://github.com/w3c/csswg-drafts/pull/2432 ); we should follow suit.
 
Labels: -WebCom Hotlist-Interop
Summary of relevant changes:

  * Replaced AnimationEffectReadOnly with AnimationEffect.
  * Removed the AnimationEffectTimingReadOnly [... ] interfaces.
  * Removed KeyframeEffectReadOnly, leaving only KeyframeEffect.

We may wish to remove AnimationEffectTimingReadOnly along with the timing changes (see  issue 823386 )
Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41f61c889af479a2558c94fac9e134e0336b6ff6

commit 41f61c889af479a2558c94fac9e134e0336b6ff6
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Sat Mar 24 14:07:15 2018

Web Animations: Remove KeyframeEffectReadOnly

Upstream the spec has removed the *ReadOnly interfaces and merged their
behavior into the non-ReadOnly ones.

See https://github.com/w3c/csswg-drafts/pull/2432 for the spec change.

Bug:  823384 

TBR=dgozman

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6f6fe6b5f620ab5c9b83d2da6cb312b199e1d208
Reviewed-on: https://chromium-review.googlesource.com/971807
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545691}
[rename] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/LayoutTests/animations/web-animations/KeyframeEffect-animation.html
[rename] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/LayoutTests/animations/web-animations/KeyframeEffect-getKeyframes-correct-context.html
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/LayoutTests/animations/web-animations/api-readonly-object-types.html
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/idlharness-expected.txt
[add] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-KeyframeEffect-crash-expected.txt
[rename] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-KeyframeEffect-crash.js
[delete] https://crrev.com/b53b29c27fe6d4b22015471b614a669b35b654f3/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-KeyframeEffectReadOnly-crash-expected.txt
[add] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/LayoutTests/virtual/threaded/animations/KeyframeEffect-composited-animation.html
[delete] https://crrev.com/b53b29c27fe6d4b22015471b614a669b35b654f3/third_party/WebKit/LayoutTests/virtual/threaded/animations/KeyframeEffectReadOnly-composited-animation.html
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.h
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/BUILD.gn
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/EffectStack.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/EffectStack.h
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/EffectStackTest.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/ElementAnimation.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/KeyframeEffect.h
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/KeyframeEffect.idl
[delete] https://crrev.com/b53b29c27fe6d4b22015471b614a669b35b654f3/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp
[delete] https://crrev.com/b53b29c27fe6d4b22015471b614a669b35b654f3/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h
[delete] https://crrev.com/b53b29c27fe6d4b22015471b614a669b35b654f3/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/SampledEffect.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/SampledEffect.h
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/WorkletAnimationBase.h
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.cpp
[modify] https://crrev.com/41f61c889af479a2558c94fac9e134e0336b6ff6/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.h

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa1e42c4e100db4d6241bce983bb98491b1f6176

commit aa1e42c4e100db4d6241bce983bb98491b1f6176
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Sat Mar 24 17:41:15 2018

Web Animations: Rename AnimationEffectReadOnly to AnimationEffect

Upstream the spec has removed the *ReadOnly interfaces and merged their
behavior into the non-ReadOnly ones.

See https://github.com/w3c/csswg-drafts/pull/2432 for the spec change.

TBR=bashi,dgozman

Bug:  823384 
Change-Id: I01c515b7c60b029cb878ac3b7ace928d9ccc59cd
Reviewed-on: https://chromium-review.googlesource.com/971943
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545696}
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/idlharness-expected.txt
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/Animation.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/Animation.idl
[rename] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/AnimationEffect.cpp
[rename] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/AnimationEffect.h
[rename] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/AnimationEffect.idl
[rename] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/AnimationEffectTest.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/AnimationEffectTiming.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/AnimationTest.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/BUILD.gn
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/DocumentTimeline.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/DocumentTimeline.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/DocumentTimelineTest.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/InertEffect.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/InertEffect.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/Keyframe.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/KeyframeEffect.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/KeyframeEffect.idl
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/README.md
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/TimingCalculations.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/TimingCalculationsTest.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/animation/css/CSSAnimations.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.cpp
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.h
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.idl
[modify] https://crrev.com/aa1e42c4e100db4d6241bce983bb98491b1f6176/third_party/WebKit/Source/modules/animationworklet/WorkletAnimationTest.cpp

Status: Started (was: Assigned)
Blocking: 772407
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aebffa30d259f1a0252818d2425c1fbf2fb13cd8

commit aebffa30d259f1a0252818d2425c1fbf2fb13cd8
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Apr 05 13:25:01 2018

Web Animations: remove timing objects

The upstream spec has removed the 'timing' objects and replaced them
with updateTiming/getTiming methods on AnimationEffect. It also removed
and renamed a few timing idl interfaces; see the bug for full details.

This CL also refactors the timing input parsing, aiming to make the
public TimingInput API match what the spec requires and not expose
other unnecessary methods.

See https://github.com/w3c/csswg-drafts/pull/2432 for the spec change.

Bug:  823384 ,  823386 
Change-Id: I40c82e46be29c16e2e4b53d69bbadc95c8bff324
Reviewed-on: https://chromium-review.googlesource.com/975923
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548403}
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/animations/multiple-same-name-css-animations.html
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/animations/web-animations/KeyframeEffect-animation.html
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/animations/web-animations/api-readonly-object-types.html
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/css/css-timing/cubic-bezier-timing-functions-output.html
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animatable/animate-expected.txt
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animatable/getAnimations-expected.txt
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animation/cancel-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animation/finished-expected.txt
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationEffect/updateTiming-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/copy-constructor-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/external/wpt/web-animations/timing-model/animation-effects/phases-and-states-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/AnimationEffect.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/AnimationEffect.h
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/AnimationEffect.idl
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/AnimationEffectTest.cpp
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/Source/core/animation/AnimationEffectTiming.h
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.cpp
[delete] https://crrev.com/04d95c0af58603c209bb6d16055947bf0298f707/third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.h
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/BUILD.gn
[rename] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/ComputedEffectTiming.idl
[rename] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/EffectTiming.idl
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/ElementAnimation.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/KeyframeEffect.h
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/KeyframeEffectOptions.idl
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
[add] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/OptionalEffectTiming.idl
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/TimingInput.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/TimingInput.h
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp
[modify] https://crrev.com/aebffa30d259f1a0252818d2425c1fbf2fb13cd8/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Status: Fixed (was: Started)

Sign in to add a comment