New issue
Advanced search Search tips

Issue 823371 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 805267



Sign in to add a comment

Touchable Chrome frame header and Splitview

Project Member Reported by afakhry@chromium.org, Mar 19 2018

Issue description

Snapping a touchable chrome window to either side in splitview mode should use the same height as that of a maximized window (41dip).
 
Issue 818349 has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c42ba2c851318aa961abbf8a13689bf9fc902973

commit c42ba2c851318aa961abbf8a13689bf9fc902973
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Fri Mar 23 23:54:52 2018

Touchable Chrome: Snapped browser window in SplitView mode

The header of a browser window snapped in SplitView mode
should use the same height as that of a maximized
browser window header.

This is true for both touchable and non-touchable chrome.
This bug became more obvious with touchable chrome since
the header height is much bigger.

BUG= 823371 
TEST=Added test that would fail without the fix

Change-Id: Ica52701338b4fdf94582392bbebbbdfc96328433
Reviewed-on: https://chromium-review.googlesource.com/969585
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545633}
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/ash/ash_layout_constants.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/ash/ash_layout_constants.h
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/ash/frame/caption_buttons/frame_back_button.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/ash/frame/default_frame_header.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/ash/wm/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/chrome/browser/ui/views/frame/browser_frame_header_ash.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/c42ba2c851318aa961abbf8a13689bf9fc902973/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc

Status: Fixed (was: Started)

Sign in to add a comment