New issue
Advanced search Search tips

Issue 823369 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Add regression test for bug 821454

Project Member Reported by thestig@chromium.org, Mar 19 2018

Issue description

Add an automated test for  bug 821454 :

1) Hand craft a test PDF that replicates the conditions in the bug.
2) Exercise the appropriate PDFium APIs to make sure the bug does not occur.
 
Labels: Postmortem-Followup
Status: Started (was: Assigned)
Cc: thestig@chromium.org
 Issue 824128  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/bf85feeafdd8791f9dab7bfcd14ff850e015be26

commit bf85feeafdd8791f9dab7bfcd14ff850e015be26
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Mar 21 17:19:46 2018

Add a regression test for  bug 821454 .

WideString::Compare() went bad but no embedder test failed. Improve
coverage by hand crafting a PDF similar to the sample PDF in the bug
report.

BUG= chromium:823369 

Change-Id: I267f53ba3ef7612bf54771a85f8305b2cbc3cfcb
Reviewed-on: https://pdfium-review.googlesource.com/28910
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/bf85feeafdd8791f9dab7bfcd14ff850e015be26/fpdfsdk/fpdfdoc_embeddertest.cpp
[add] https://crrev.com/bf85feeafdd8791f9dab7bfcd14ff850e015be26/testing/resources/bug_821454.pdf
[add] https://crrev.com/bf85feeafdd8791f9dab7bfcd14ff850e015be26/testing/resources/bug_821454.in

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/148ba9d017a9996ca760b27697a6b5f362c06dc9

commit 148ba9d017a9996ca760b27697a6b5f362c06dc9
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Mar 21 20:05:01 2018

Roll src/third_party/pdfium/ a17ac192c..36bbc24e2 (6 commits)

https://pdfium.googlesource.com/pdfium.git/+log/a17ac192c043..36bbc24e2d7e

$ git log a17ac192c..36bbc24e2 --date=short --no-merges --format='%ad %ae %s'
2018-03-21 thestig Use more const pointers in CPDF_ContentMarkItem.
2018-03-21 thestig Rename foo_{wid,hei} to foo_{width,height}.
2018-03-21 dsinclair Move declarations in pdfium_test closer to usage
2018-03-21 thestig Rename "des_foo" to "dest_foo".
2018-03-21 thestig Add helpers to work with FXDIB_Format.
2018-03-21 thestig Add a regression test for  bug 821454 .

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:823369 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I10bca8d9dffb4b94a8c031e738d5bf27eb13f89e
Reviewed-on: https://chromium-review.googlesource.com/973891
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544813}
[modify] https://crrev.com/148ba9d017a9996ca760b27697a6b5f362c06dc9/DEPS

 Issue 835890  has been merged into this issue.

Sign in to add a comment