New issue
Advanced search Search tips

Issue 823365 link

Starred by 3 users
Status: Fixed
Owner:
skobes@chromium.org
Closed: Sep 6
Cc:
szager@chromium.org
pdr@chromium.org
vmp...@chromium.org
bokan@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocked on: View detail
issue 816595
issue 826647
issue 417782
issue 770343
issue 806031
issue 825145
issue 825775
issue 828808
issue 833167
issue 838150
issue 840389
issue 846740
issue 847236


Sign in to add a comment

post-launch RLS cleanup

Project Member Reported by skobes@chromium.org, Mar 19 2018 
Master bug for

- removing RLS feature entry / REF / Finch experiments
- P2/P3 RLS regressions that were not launch-blocking
- removal of non-RLS codepaths
- make LocalFrameView not inherit from PICSA
- fold PICSA into PLSA

Comment 1 by skobes@chromium.org, Mar 19 2018

Blockedon: 816595

Comment 2 by szager@chromium.org, Mar 19 2018 

I would also like to discuss whether we should move ScrollableArea (and a few other files) out of platform/ and into core/.

Comment 3 by skobes@chromium.org, Mar 28 2018

Blockedon: 826647

Comment 4 by skobes@chromium.org, Apr 17 2018

Blockedon: 828808

Comment 5 by skobes@chromium.org, Apr 17 2018

Blockedon: 825775

Comment 6 by bokan@chromium.org, Apr 17 2018

Blockedon: 806031

Comment 7 by skobes@chromium.org, Apr 19 2018

Blockedon: 833167

Comment 8 by skobes@chromium.org, May 1 2018

Blockedon: 825145

Comment 9 by skobes@chromium.org, May 1 2018

Blockedon: 770343
Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10f6333590825da11319d961c9d9b4060f581494

commit 10f6333590825da11319d961c9d9b4060f581494
Author: Steve Kobes <skobes@chromium.org>
Date: Wed May 02 20:58:05 2018

Remove RLS-disabled flag expectations and baselines.

This configuration is no longer tested.

Bug: 823365
Change-Id: Ied6ece777017245dad4ec93ef25f691f9110e62b
Reviewed-on: https://chromium-review.googlesource.com/1040536
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555508}
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/absolute-inside-out-of-view-fixed-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/background-color/view-blending-base-background-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/checkerboard-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/clip-child-by-non-stacking-ancestor-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/columns/composited-in-paginated-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/background-clip-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/background-color-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/body-background-painted-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/body-background-skipped-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/filter-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/hidden-with-visible-child-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/hidden-with-visible-text-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/layer-opacity-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/layer-transform-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/contents-opaque/visibility-hidden-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/draws-content/canvas-background-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/draws-content/webgl-background-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/fixed-body-background-positioned-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/fixed-position-changed-to-absolute-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/force-compositing-mode/force-composite-empty-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/ancestor-overflow-change-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/bounds-clipped-composited-child-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/bounds-ignores-hidden-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/clip-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/clip-inside-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/clip-with-shadow-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/composited-in-columns-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/flipped-writing-mode-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/foreground-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/horizontal-scroll-composited-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/limit-layer-bounds-positioned-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/limit-layer-bounds-transformed-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/geometry/vertical-scroll-composited-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/become-overlapped-iframe-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/composited-iframe-scroll-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/composited-parent-iframe-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/connect-compositing-iframe-delayed-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/connect-compositing-iframe-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/connect-compositing-iframe2-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/connect-compositing-iframe3-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/enter-compositing-iframe-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/iframe-in-composited-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/iframe-resize-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/iframe-size-from-zero-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/invisible-nested-iframe-hide-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/invisible-nested-iframe-show-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/nested-iframe-scrolling-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/overlapped-iframe-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/overlapped-iframe-iframe-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/overlapped-nested-iframes-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/resizer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/scrolling-iframe-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/iframes/visibility-hidden-transformed-content-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/images/clip-on-directly-composited-image-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/images/direct-image-dynamic-border-draws-content-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/animation-overlap-with-children-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/assumed-overlap-for-inline-transform-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-and-transform-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-in-fixed-overflow-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-no-content-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-nonscrollable-body-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-nonscrollable-body-overlap-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-nonscrollable-iframes-in-scrollable-page-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-out-of-view-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-out-of-view-positioning-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-out-of-view-with-backdrop-filter-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/fixed-position-under-transform-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/impl-thread-scrolling-non-composited-fixed-no-scroll-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/main-thread-scrolling-for-non-composited-fixed-position-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/main-thread-scrolling-non-composited-fixed-overflow-hidden-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overflow-scroll-overlap-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-animation-clipping-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-animation-container-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-animation-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-child-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-clipping-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-transformed-3d-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-transformed-layer-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-transformed-layer-with-transform-body-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/overlap-transforms-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/remove-clipping-layer-with-no-children-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/rotate3d-overlap-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/scroll-partial-update-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/spanOverlapsCanvas-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/squashing-into-ancestor-clipping-layer-change-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/stacking-context-overlap-expected.txt
[delete] https://crrev.com/ff31875bec10a7fe0513e094483f79157b034347/third_party/WebKit/LayoutTests/flag-specific/disable-blink-features=RootLayerScrolling/compositing/layer-creation/stacking-
Project Member

Comment 11 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2756f3cf0492bf2397935d42b645569017a2c628

commit 2756f3cf0492bf2397935d42b645569017a2c628
Author: Steve Kobes <skobes@chromium.org>
Date: Thu May 03 16:02:27 2018

Remove baselines for virtual/{rootlayerscrolls,disable-rls}.

These virtual test suites no longer exist.

Bug: 823365
Change-Id: I62503d3b99f192f46e09acd6b8f38fad84e1ee9a
Reviewed-on: https://chromium-review.googlesource.com/1042369
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555752}
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-rls/compositing/squashing/selection-repaint-with-gaps-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-rls/compositing/squashing/selection-repaint-with-gaps-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-rls/compositing/squashing/vertical-writing-mode-squashed-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/fast/scrolling/scrollbar-prevent-default-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/basic-scrollbar-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/custom-scrollbar-appearance-property-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/custom-scrollbar-with-incomplete-style-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/disabled-scrollbar-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinations-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinations-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/resize-scales-with-dpi-150-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/scrollbar-buttons-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/scrollbar-orientation-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/linux/virtual/rootlayerscrolls/scrollbars/scrollbars-on-positioned-content-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/rootlayerscrolls/scrollbars/custom-scrollbar-with-incomplete-style-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/rootlayerscrolls/fast/scrolling/scrollbar-prevent-default-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-rls/compositing/squashing/frame-clip-squashed-scrolled-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-rls/compositing/squashing/no-squashing-into-another-clip-layer-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-rls/compositing/squashing/selection-repaint-with-gaps-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac/virtual/rootlayerscrolls/scrollbars/custom-scrollbar-appearance-property-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac/virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac/virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinations-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac/virtual/rootlayerscrolls/scrollbars/resize-scales-with-dpi-150-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/mac/virtual/rootlayerscrolls/scrollbars/scrollbars-on-positioned-content-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/disable-rls/compositing/squashing/selection-repaint-with-gaps-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/fast/scrolling/scrollbar-prevent-default-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/auto-scrollbar-fades-out-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/custom-scrollbar-appearance-property-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinations-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinations-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/rtl/overflow-scroll-rtl-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win/virtual/rootlayerscrolls/scrollbars/scrollbars-on-positioned-content-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win7/virtual/rootlayerscrolls/fast/scrolling/scrollbar-prevent-default-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win7/virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win7/virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations-expected.txt
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win7/virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinations-expected.png
[delete] https://crrev.com/549fd903fefb5ae6965e23371624f2afca3cd4d6/third_party/WebKit/LayoutTests/platform/win7/virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinations-expected.txt
Project Member

Comment 12 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9

commit ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9
Author: Steve Kobes <skobes@chromium.org>
Date: Fri May 04 13:31:19 2018

Remove RLS checks in layout tests.

Bug: 823365
Change-Id: I29537cc8d749eb426a9ae5624789b95b34121b13
Reviewed-on: https://chromium-review.googlesource.com/1042802
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556038}
[modify] https://crrev.com/ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9/third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html
[modify] https://crrev.com/ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9/third_party/WebKit/LayoutTests/compositing/dont-composite-select-elements.html
[modify] https://crrev.com/ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9/third_party/WebKit/LayoutTests/compositing/dont-composite-text-input-elements.html
[modify] https://crrev.com/ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-animated-layers.html
[modify] https://crrev.com/ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html
[modify] https://crrev.com/ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-with-scale-transform.html
[modify] https://crrev.com/ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9/third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html
[modify] https://crrev.com/ab3e2c039f3a96117e96d1b2d6e0a98010cb75a9/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-shadow-included-in-invalidation.html

Comment 13 by pdr@chromium.org, May 7 2018

Blockedon: 840389

Comment 14 by skobes@chromium.org, May 9 2018

Blockedon: 838150
Project Member

Comment 17 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fd7afdc2c2a4d8d11fcf37f56ae5eefba7d7965

commit 4fd7afdc2c2a4d8d11fcf37f56ae5eefba7d7965
Author: Steve Kobes <skobes@chromium.org>
Date: Wed May 16 16:58:45 2018

RLS: Deparameterize core/paint unit tests.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id64ba29f5105f8adb3e6f65fd1da5c8eec28dd89
Reviewed-on: https://chromium-review.googlesource.com/1061584
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559146}
[modify] https://crrev.com/4fd7afdc2c2a4d8d11fcf37f56ae5eefba7d7965/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/4fd7afdc2c2a4d8d11fcf37f56ae5eefba7d7965/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater_test.cc
[modify] https://crrev.com/4fd7afdc2c2a4d8d11fcf37f56ae5eefba7d7965/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater_test.cc
[modify] https://crrev.com/4fd7afdc2c2a4d8d11fcf37f56ae5eefba7d7965/third_party/blink/renderer/core/paint/paint_layer_clipper_test.cc
[modify] https://crrev.com/4fd7afdc2c2a4d8d11fcf37f56ae5eefba7d7965/third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
[modify] https://crrev.com/4fd7afdc2c2a4d8d11fcf37f56ae5eefba7d7965/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/4fd7afdc2c2a4d8d11fcf37f56ae5eefba7d7965/third_party/blink/renderer/core/paint/view_painter_test.cc
Project Member

Comment 18 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2

commit c29c8861ab54c3aef9dc7f4448d509e5f6447fd2
Author: Steve Kobes <skobes@chromium.org>
Date: Wed May 16 18:14:33 2018

RLS: Deparameterize unit tests in core/page and core/frame.

Bug: 823365
Change-Id: Ied4f19b6a565e171e8cf8cd0e16189a8c7f29752
Reviewed-on: https://chromium-review.googlesource.com/1062011
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559186}
[modify] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/third_party/blink/renderer/core/frame/local_frame_view_test.cc
[modify] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/third_party/blink/renderer/core/frame/root_frame_viewport_test.cc
[modify] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/third_party/blink/renderer/core/frame/rotation_viewport_anchor_test.cc
[modify] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/third_party/blink/renderer/core/page/drag_controller_test.cc
[modify] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
[modify] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/third_party/blink/renderer/core/page/scrolling/scroll_into_view_test.cc
[modify] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/third_party/blink/renderer/core/page/scrolling/snap_coordinator_test.cc
Project Member

Comment 21 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40f2b7eb1c85ff9b7c118b004f87aec41816ff99

commit 40f2b7eb1c85ff9b7c118b004f87aec41816ff99
Author: Philip Rogers <pdr@chromium.org>
Date: Fri May 18 12:24:15 2018

[RLS] Remove unused code in view_painter, ax_object, graphics_layer, and print_context

Now that Root Layer Scrolling (RLS) is enabled by default, we can remove
these unused codepaths.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I212505daa58d1e723cc51c4c764c08822d01da33
Reviewed-on: https://chromium-review.googlesource.com/1065119
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559871}
[modify] https://crrev.com/40f2b7eb1c85ff9b7c118b004f87aec41816ff99/third_party/blink/renderer/core/page/print_context.cc
[modify] https://crrev.com/40f2b7eb1c85ff9b7c118b004f87aec41816ff99/third_party/blink/renderer/core/paint/view_painter.cc
[modify] https://crrev.com/40f2b7eb1c85ff9b7c118b004f87aec41816ff99/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/40f2b7eb1c85ff9b7c118b004f87aec41816ff99/third_party/blink/renderer/platform/graphics/graphics_layer.cc
Project Member

Comment 22 by bugdroid1@chromium.org, May 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c75c3661a3a1e277204063d6607d302bff8c5554

commit c75c3661a3a1e277204063d6607d302bff8c5554
Author: Philip Rogers <pdr@chromium.org>
Date: Sat May 19 21:40:35 2018

[RLS] Remove paint properties from LocalFrameView

This patch removes the paint properties for LocalFrameView as they are
stored on the LayoutView now.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7d138e6435d7af9fc2344853a2fd41c0294c09e4
Reviewed-on: https://chromium-review.googlesource.com/1066709
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560162}
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/block_painter.cc
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.h
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/find_properties_needing_update.h
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/frame_painter.cc
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/paint_invalidator.cc
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/paint_property_tree_builder.h
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/paint_property_tree_printer.cc
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/paint_property_tree_printer.h
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/core/paint/pre_paint_tree_walk.cc
[modify] https://crrev.com/c75c3661a3a1e277204063d6607d302bff8c5554/third_party/blink/renderer/modules/navigatorcontentutils/navigator_content_utils.cc
Project Member

Comment 24 by bugdroid1@chromium.org, May 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f748c29f44b2f94e194c64d585ca86f53d8e11e5

commit f748c29f44b2f94e194c64d585ca86f53d8e11e5
Author: Steve Kobes <skobes@chromium.org>
Date: Sat May 19 21:47:09 2018

Remove RLS checks in unit tests.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I07e34f6e26394c073124886eef08d93a667918f5
Reviewed-on: https://chromium-review.googlesource.com/1066615
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560174}
[modify] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/third_party/blink/renderer/core/paint/paint_controller_paint_test.cc
[modify] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/third_party/blink/renderer/core/paint/paint_layer_painter_test.cc
[modify] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.h
[modify] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/third_party/blink/renderer/core/paint/paint_property_tree_update_tests.cc
Project Member

Comment 25 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9436693a194c6101e0be22b7eb6ed8e9c1fd1066

commit 9436693a194c6101e0be22b7eb6ed8e9c1fd1066
Author: Philip Rogers <pdr@chromium.org>
Date: Mon May 21 18:59:23 2018

[RLS] Remove CompositedLayerMapping's fixed root background layer

CompositedLayerMapping's background_layer was only used for fixed root
backgrounds (see: PLC::NeedsFixedRootBackgroundLayer) because the main
graphics layer scrolled. With root layer scrolling, all fixed
backgrounds are painted on the main graphics layer, and we no longer
need CLM's background_layer.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1546edb5fa1588b7499328b1ec56327e379f847b
Reviewed-on: https://chromium-review.googlesource.com/1067076
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560321}
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/layout/layout_view.h
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/background_image_geometry.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/block_painter.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.h
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/paint_info.h
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/paint_layer_painter.cc
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/third_party/blink/renderer/core/paint/paint_layer_painting_info.h
[modify] https://crrev.com/9436693a194c6101e0be22b7eb6ed8e9c1fd1066/tools/metrics/histograms/histograms.xml
Project Member

Comment 26 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85a03bc295a24bcad455ceb311942bf9a5bc604e

commit 85a03bc295a24bcad455ceb311942bf9a5bc604e
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Wed May 23 23:28:10 2018

[RLS] Remove the RootLayerScrollingEnabled check from some more files.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I38f0e9c871eceb5d842cd9a5aa0c5449ec034321
Reviewed-on: https://chromium-review.googlesource.com/1070603
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561307}
[modify] https://crrev.com/85a03bc295a24bcad455ceb311942bf9a5bc604e/third_party/blink/renderer/core/paint/box_paint_invalidator.cc
[modify] https://crrev.com/85a03bc295a24bcad455ceb311942bf9a5bc604e/third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
[modify] https://crrev.com/85a03bc295a24bcad455ceb311942bf9a5bc604e/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/85a03bc295a24bcad455ceb311942bf9a5bc604e/third_party/blink/renderer/core/paint/paint_layer.h
Project Member

Comment 27 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d00179332cccfe454a8e75a7248b4588f4ef290

commit 4d00179332cccfe454a8e75a7248b4588f4ef290
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Wed May 23 23:55:14 2018

[RLS] Remove references to RootLayerScrollingEnabled in various files

Bug:823365

Change-Id: I188e8521d0981c3da23f978caaffdc0009190691
Reviewed-on: https://chromium-review.googlesource.com/1070887
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561316}
[modify] https://crrev.com/4d00179332cccfe454a8e75a7248b4588f4ef290/third_party/blink/renderer/core/dom/tree_scope.cc
[modify] https://crrev.com/4d00179332cccfe454a8e75a7248b4588f4ef290/third_party/blink/renderer/core/editing/finder/text_finder.cc
[modify] https://crrev.com/4d00179332cccfe454a8e75a7248b4588f4ef290/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/4d00179332cccfe454a8e75a7248b4588f4ef290/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/4d00179332cccfe454a8e75a7248b4588f4ef290/third_party/blink/renderer/core/frame/root_frame_viewport.cc
[modify] https://crrev.com/4d00179332cccfe454a8e75a7248b4588f4ef290/third_party/blink/renderer/core/fullscreen/fullscreen.cc
[modify] https://crrev.com/4d00179332cccfe454a8e75a7248b4588f4ef290/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/4d00179332cccfe454a8e75a7248b4588f4ef290/third_party/blink/renderer/core/page/scrolling/top_document_root_scroller_controller.cc
[modify] https://crrev.com/4d00179332cccfe454a8e75a7248b4588f4ef290/third_party/blink/renderer/core/page/spatial_navigation.cc
Project Member

Comment 28 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/965042c5f89bb5ff1e776c5a1533b9632e5cd91b

commit 965042c5f89bb5ff1e776c5a1533b9632e5cd91b
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Thu May 24 00:32:48 2018

[RLS] Remove the RootLayerScrollingEnabled check from FramePainter and PLSA.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia97f4fac5a0fd9929d8ff03b109057db7171e8f3
Reviewed-on: https://chromium-review.googlesource.com/1070621
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561331}
[modify] https://crrev.com/965042c5f89bb5ff1e776c5a1533b9632e5cd91b/third_party/blink/renderer/core/paint/frame_painter.cc
[modify] https://crrev.com/965042c5f89bb5ff1e776c5a1533b9632e5cd91b/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
Project Member

Comment 29 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec4da9b334be9e53cd2b1cf32b16af284da63b8f

commit ec4da9b334be9e53cd2b1cf32b16af284da63b8f
Author: Philip Rogers <pdr@chromium.org>
Date: Thu May 24 20:05:39 2018

[RLS] Remove !RLS code in CLM and background_image_geometry

This patch removes the !RLS codepaths in CompositedLayerMapping (CLM)
and background_image_geometry now that Root Layer Scrolling (RLS) has
launched.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id07239b22bb96fa7e4d0d3c41d82b61aa9eb5090
Reviewed-on: https://chromium-review.googlesource.com/1071871
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561588}
[modify] https://crrev.com/ec4da9b334be9e53cd2b1cf32b16af284da63b8f/third_party/blink/renderer/core/paint/background_image_geometry.cc
[modify] https://crrev.com/ec4da9b334be9e53cd2b1cf32b16af284da63b8f/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
Project Member

Comment 30 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36d127c070314233672e1d1ecdf7edc10d2d5ac7

commit 36d127c070314233672e1d1ecdf7edc10d2d5ac7
Author: Philip Rogers <pdr@chromium.org>
Date: Thu May 24 22:59:43 2018

[RLS] Remove !RLS code in paint_layer_clipper & root_scroller_controller

This patch removes the !RLS codepaths in paint layer clipper and root
scroller controller. Now that Root Layer Scrolling (RLS) is enabled
by default, this code is no longer needed.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I55e925d572dfbcee2cb4db53c73ca9f841a4d01b
Reviewed-on: https://chromium-review.googlesource.com/1072632
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561674}
[modify] https://crrev.com/36d127c070314233672e1d1ecdf7edc10d2d5ac7/third_party/blink/renderer/core/page/scrolling/root_scroller_controller.cc
[modify] https://crrev.com/36d127c070314233672e1d1ecdf7edc10d2d5ac7/third_party/blink/renderer/core/paint/paint_layer_clipper.cc
Project Member

Comment 31 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4af9c2aad765488d6eb9391a27ee3cb56110080

commit a4af9c2aad765488d6eb9391a27ee3cb56110080
Author: Philip Rogers <pdr@chromium.org>
Date: Thu May 24 23:08:08 2018

[RLS] Remove PaintLayerCompositor layers

This patch removes the !RLS codepaths in PaintLayerCompositor (PLC)
because PLC does not create layers with Root Layer Scrolling (RLS). Now
RLS has launched, we can remove this obsolete technology.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I999a7239c88acd48ba781ff5bcdcd6079994daaa
Reviewed-on: https://chromium-review.googlesource.com/1072487
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561678}
[modify] https://crrev.com/a4af9c2aad765488d6eb9391a27ee3cb56110080/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/a4af9c2aad765488d6eb9391a27ee3cb56110080/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/a4af9c2aad765488d6eb9391a27ee3cb56110080/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/a4af9c2aad765488d6eb9391a27ee3cb56110080/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/a4af9c2aad765488d6eb9391a27ee3cb56110080/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/a4af9c2aad765488d6eb9391a27ee3cb56110080/third_party/blink/renderer/core/paint/compositing/graphics_layer_updater.cc
[modify] https://crrev.com/a4af9c2aad765488d6eb9391a27ee3cb56110080/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
[modify] https://crrev.com/a4af9c2aad765488d6eb9391a27ee3cb56110080/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.h
Project Member

Comment 32 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c916c273b71bd71ea709558061daa6f74c4c554c

commit c916c273b71bd71ea709558061daa6f74c4c554c
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri May 25 03:16:26 2018

[RLS] Remove RootLayerScrolling references in LocalFrameView.

Bug: 823365
Change-Id: If472892ad0baae4aa6352b8ce37eb61fb84e5fdc
Reviewed-on: https://chromium-review.googlesource.com/1072412
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561753}
[modify] https://crrev.com/c916c273b71bd71ea709558061daa6f74c4c554c/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/c916c273b71bd71ea709558061daa6f74c4c554c/third_party/blink/renderer/core/frame/local_frame_view.h
Project Member

Comment 33 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38f783eacdf77fb4f07f054361ff8ba4f2554f30

commit 38f783eacdf77fb4f07f054361ff8ba4f2554f30
Author: Steve Kobes <skobes@chromium.org>
Date: Fri May 25 15:19:51 2018

Remove RootLayerScrolling REF.

This removes the entry in runtime_enabled_features.json5 along with the
two remaining uses of it in LocalFrameView.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic220dc9dc67c658900619f7f89f83ffce226e4dd
Reviewed-on: https://chromium-review.googlesource.com/1073387
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561882}
[modify] https://crrev.com/38f783eacdf77fb4f07f054361ff8ba4f2554f30/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/38f783eacdf77fb4f07f054361ff8ba4f2554f30/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/38f783eacdf77fb4f07f054361ff8ba4f2554f30/third_party/blink/renderer/core/paint/box_paint_invalidator.cc
[modify] https://crrev.com/38f783eacdf77fb4f07f054361ff8ba4f2554f30/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 34 by pdr@chromium.org, May 25 2018

Blockedon: 846740
Project Member

Comment 35 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9938ef3ab992d40b50aab3d2f607da42f459904b

commit 9938ef3ab992d40b50aab3d2f607da42f459904b
Author: Philip Rogers <pdr@chromium.org>
Date: Fri May 25 16:45:37 2018

[RLS] Remove deadcode from LocalFrameView

This patch removes:
LocalFrameView::IsEnclosedInCompositingLayer
LocalFrameView::UpdateLayersAndCompositingAfterScrollIfNeeded

Incidentally, this removes the last DisableCompositingQueryAsserts
from LocalFrameView.

Bug: 823365
Change-Id: I2cc8ef49252be320b994578570919ff5b2a34586
Reviewed-on: https://chromium-review.googlesource.com/1072908
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561911}
[modify] https://crrev.com/9938ef3ab992d40b50aab3d2f607da42f459904b/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/9938ef3ab992d40b50aab3d2f607da42f459904b/third_party/blink/renderer/core/frame/local_frame_view.h

Comment 37 by skobes@chromium.org, May 28 2018

Blockedon: 847236
Project Member

Comment 38 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f0a2ca363c26f6d913730d4f137fca97543f19b

commit 5f0a2ca363c26f6d913730d4f137fca97543f19b
Author: Stefan Zager <szager@chromium.org>
Date: Tue Jun 12 16:57:18 2018

[RootLayerScrolls] Cleanup: frame<->contents conversion is obsolete

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I10e7c64b3329fa4bab284e044c4fc9881915baec
Reviewed-on: https://chromium-review.googlesource.com/1096338
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566469}
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/editing/selection_controller.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/events/mouse_event.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/events/web_input_event_conversion.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/input/event_handling_util.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/input/gesture_manager.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/input/mouse_event_manager.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/input/mouse_wheel_event_manager.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/input/pointer_event_manager.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/input/scroll_manager.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/input/touch_event_manager.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/inspector/inspector_highlight.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/page/drag_controller.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/page/page_widget_delegate.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/page/touch_adjustment.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/page/touch_disambiguation.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/paint/object_paint_invalidator.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/5f0a2ca363c26f6d913730d4f137fca97543f19b/third_party/blink/renderer/core/testing/internals.cc
Project Member

Comment 39 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc

commit 21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc
Author: Steve Kobes <skobes@chromium.org>
Date: Tue Jun 12 23:02:08 2018

Delete LocalFrameView::ScrollbarManager and scroll_corner_.

This removes methods and paths in LocalFrameView that depend directly on
scrollbar existence.  Since RLS, LocalFrameView never has scrollbars.

Bug: 823365
Change-Id: I691480e4cad9239f12c50aa868c5d13571d45b2f
Reviewed-on: https://chromium-review.googlesource.com/1097540
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566618}
[modify] https://crrev.com/21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc/third_party/blink/renderer/core/input/mouse_event_manager.cc
[modify] https://crrev.com/21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc/third_party/blink/renderer/core/layout/layout_scrollbar_part.cc
[modify] https://crrev.com/21f5dfe201ccff1ec08a3df50fc9b047cacbc4dc/third_party/blink/renderer/core/layout/layout_view.cc
Project Member

Comment 40 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e3ff78d476f0c254d4fd7a629dc809870e31dbe

commit 4e3ff78d476f0c254d4fd7a629dc809870e31dbe
Author: Stefan Zager <szager@chromium.org>
Date: Thu Jun 14 10:22:48 2018

[RootLayerScrolls] Cleanup Frame/Contents conversions.

Conversion between 'frame' and 'contents' coordinate spaces is now a
no-op. This CL settles on 'frame' as the term d'art for the coordinate
space of the frame, so ViewportToContents becomes ViewportToFrame, and
vice versa.

Also, this adds a couple of missing float overrides for still-useful
conversion methods. Arbitrarily converting between LayoutUnit and
float can be a source of bugs.

BUG=823365
R=skobes@chromium.org,bokan@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id687f88988e6e27ea75027026377d9464bee3406
Reviewed-on: https://chromium-review.googlesource.com/1099996
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567214}
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getBoxModel-expected.txt
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/editing/selection_controller.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/editing/suggestion/text_suggestion_controller.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/editing/web_substring_util.mm
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/frame/remote_frame_view.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/frame/smart_clip.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/html/forms/color_input_type.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/html/forms/external_popup_menu.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/input/mouse_event_manager.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/input/pointer_event_manager.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/input/touch_action_test.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/inspector/inspector_highlight.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/page/context_menu_controller.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/page/drag_controller.cc
[modify] https://crrev.com/4e3ff78d476f0c254d4fd7a629dc809870e31dbe/third_party/blink/renderer/core/paint/paint_invalidator.cc
Project Member

Comment 41 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7853b97dfb55ec27a36ead7f1960abaaf1b639eb

commit 7853b97dfb55ec27a36ead7f1960abaaf1b639eb
Author: Stefan Zager <szager@chromium.org>
Date: Thu Jun 14 17:34:18 2018

[RootLayerScrolls] No more absolute coordinates

"Absolute" coordinates were a shim to ease the RLS transition. Get rid
of them in favor of "Frame" and "Document" coordinates.

BUG=823365
R=skobes@chromium.org,bokan@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id82f7908c32b2b529a2259bb5e18339a5568458a
Reviewed-on: https://chromium-review.googlesource.com/1100540
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567329}
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/clipboard/data_transfer.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/editing/finder/text_finder.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/editing/frame_selection_test.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/editing/markers/text_match_marker_list_impl.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/events/mouse_event.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/events/web_input_event_conversion.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/frame/root_frame_viewport_test.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/frame/rotation_viewport_anchor.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/input/touch.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/page/spatial_navigation.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/7853b97dfb55ec27a36ead7f1960abaaf1b639eb/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
Project Member

Comment 42 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40835e4769d4b5743fcab1c301892d4a332bc335

commit 40835e4769d4b5743fcab1c301892d4a332bc335
Author: Steve Kobes <skobes@chromium.org>
Date: Fri Jun 15 18:19:53 2018

Shorten LFV::LayoutViewportScrollableArea, mark const, and return PLSA*.

Bug: 823365
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I561aed3c38b87dabd011b623ede62fdbc8f7fe8a
Reviewed-on: https://chromium-review.googlesource.com/1102490
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567732}
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/WebKit/LayoutTests/scrollbars/scrollbar-layout-viewport-scrollwidth.html
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/clipboard/data_transfer_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/dom/tree_scope.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/editing/commands/move_commands.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/editing/frame_selection_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/events/mouse_event.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/browser_controls_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/dom_visual_viewport.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/frame_view_auto_size_info.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/local_frame_view_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/root_frame_viewport.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/rotation_viewport_anchor_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/html/anchor_element_metrics_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/html/image_document.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/html/image_document_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/input/event_handler_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/input/touch.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/input/touch_action_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/inspector/inspector_page_agent.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/intersection_observer/intersection_observer_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/layout/layout_box_model_object.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/layout/map_coordinates_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/layout/scroll_anchor_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/layout/scrollbars_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/layout/visual_rect_mapping_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/loader/programmatic_scroll_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/drag_controller_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/print_context.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/scrolling/root_scroller_controller.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/scrolling/root_scroller_util.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/scrolling/snap_coordinator_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/scrolling/top_document_root_scroller_controller.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/page/spatial_navigation.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/paint/background_image_geometry.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/paint/paint_controller_paint_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/paint/paint_layer_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/paint/view_painter_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/40835e4769d4b5743fcab1c301892d4a332bc335/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
Project Member

Comment 43 by bugdroid1@chromium.org, Jun 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc

commit 4ab527b20ef3ed6f81ff4672de0a59487cc25bfc
Author: Steve Kobes <skobes@chromium.org>
Date: Sat Jun 16 03:50:10 2018

Shrink PLSA header by 40%.

This patch reduces preprocessed size of paint_layer_scrollable_area.h
from 6.3 MB to 3.8 MB, avoiding transitive inclusion of chrome_client.h
and float_clip_rect.h with tricks similar to crrev.com/567547.  (Since
crrev.com/567732, more source files include PLSA's header.)

Bug: 242216,823365
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I969088b6f75b80d3279b0beb3cc701eb16e6ed6a
Reviewed-on: https://chromium-review.googlesource.com/1103235
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567868}
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/layout/jank_tracker.cc
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/paint/clip_rect.cc
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/paint/clip_rect.h
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
Project Member

Comment 44 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a846bb478fd0e50ff7fcf5785977b0d02825c334

commit a846bb478fd0e50ff7fcf5785977b0d02825c334
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Jun 19 00:20:25 2018

[RLS] Remove scrollbar painting from FramePainter

This is all dead code.

Bug: 823365
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2b7e8281099435dc937ddf5f8e2e77749c5cbad7
Reviewed-on: https://chromium-review.googlesource.com/1103779
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568252}
[modify] https://crrev.com/a846bb478fd0e50ff7fcf5785977b0d02825c334/third_party/blink/renderer/core/paint/frame_painter.cc
[modify] https://crrev.com/a846bb478fd0e50ff7fcf5785977b0d02825c334/third_party/blink/renderer/core/paint/frame_painter.h
Project Member

Comment 45 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e33c6c17bf4a4c2f1b631503d17f6e215c5cb2a8

commit e33c6c17bf4a4c2f1b631503d17f6e215c5cb2a8
Author: Stefan Zager <szager@chromium.org>
Date: Wed Jun 20 16:49:08 2018

[RootLayerScrolls] Fix logic for computing screen distance of iframe

BUG=823365
R=skobes@chromium.org,sclittle@chromium.org

Change-Id: I400bae2f5a35075b06e42a2b2796772c3a0a687f
Reviewed-on: https://chromium-review.googlesource.com/1107164
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568878}
[modify] https://crrev.com/e33c6c17bf4a4c2f1b631503d17f6e215c5cb2a8/third_party/blink/renderer/core/frame/local_frame_view.cc
Project Member

Comment 46 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecec3d1806553fb55f810201a35c29490aa105cb

commit ecec3d1806553fb55f810201a35c29490aa105cb
Author: Stefan Zager <szager@chromium.org>
Date: Thu Jun 21 23:22:13 2018

[RootLayerScrolls] Get rid of ScrollbarManager super-class

ScrollbarManager is now PLSA-specific.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia872266afb330836c10f6e36dce3e756a5895734
Reviewed-on: https://chromium-review.googlesource.com/1110881
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569442}
[modify] https://crrev.com/ecec3d1806553fb55f810201a35c29490aa105cb/third_party/blink/renderer/core/paint/BUILD.gn
[modify] https://crrev.com/ecec3d1806553fb55f810201a35c29490aa105cb/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/ecec3d1806553fb55f810201a35c29490aa105cb/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
[delete] https://crrev.com/9dd345d0e616ff5003ae9289087dfc2297ddd6e5/third_party/blink/renderer/core/paint/scrollbar_manager.cc
[delete] https://crrev.com/9dd345d0e616ff5003ae9289087dfc2297ddd6e5/third_party/blink/renderer/core/paint/scrollbar_manager.h
Project Member

Comment 47 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/069105ebde0915ee304c34eb5d69a22fc31ede7b

commit 069105ebde0915ee304c34eb5d69a22fc31ede7b
Author: Steve Kobes <skobes@chromium.org>
Date: Fri Jun 22 00:54:08 2018

Fold PaintInvalidationCapableScrollableArea into PLSA.

Bug: 823365
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic7d1091222850e65d5442b7a339c6925d5c51dac
Reviewed-on: https://chromium-review.googlesource.com/1110882
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569476}
[modify] https://crrev.com/069105ebde0915ee304c34eb5d69a22fc31ede7b/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/069105ebde0915ee304c34eb5d69a22fc31ede7b/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/069105ebde0915ee304c34eb5d69a22fc31ede7b/third_party/blink/renderer/core/layout/layout_object.h
[modify] https://crrev.com/069105ebde0915ee304c34eb5d69a22fc31ede7b/third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
[modify] https://crrev.com/069105ebde0915ee304c34eb5d69a22fc31ede7b/third_party/blink/renderer/core/page/scrolling/root_scroller_util.cc
[modify] https://crrev.com/069105ebde0915ee304c34eb5d69a22fc31ede7b/third_party/blink/renderer/core/paint/BUILD.gn
[delete] https://crrev.com/346b08f893f6fed91b4401c8da112da15d21a100/third_party/blink/renderer/core/paint/paint_invalidation_capable_scrollable_area.cc
[delete] https://crrev.com/346b08f893f6fed91b4401c8da112da15d21a100/third_party/blink/renderer/core/paint/paint_invalidation_capable_scrollable_area.h
[modify] https://crrev.com/069105ebde0915ee304c34eb5d69a22fc31ede7b/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/069105ebde0915ee304c34eb5d69a22fc31ede7b/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
Project Member

Comment 48 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d85d2145dfe588b218d39cad730bc09736bca86e

commit d85d2145dfe588b218d39cad730bc09736bca86e
Author: Stefan Zager <szager@chromium.org>
Date: Fri Jun 22 17:15:22 2018

[RootLayerScrolls] Don't include PLSA header from paint_layer.h

This reduces the number of .cc files that include the PLSA header
from 196 to 107.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I846a7b5e3120e5cf60ba59002ba53c82d8099d88
Reviewed-on: https://chromium-review.googlesource.com/1111011
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569671}
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/editing/frame_selection_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/editing/rendered_position.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/events/mouse_event.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/frame/local_frame_view_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/html/forms/text_field_input_type.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/input/event_handling_util.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/input/mouse_event_manager.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/input/scroll_manager.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_block.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_box_model_object.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_deprecated_flexible_box.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_flexible_box.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_list_box.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_tree_as_text.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/layout/visual_rect_mapping_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/page/scrolling/top_document_root_scroller_controller.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/background_image_geometry.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/compositing/graphics_layer_updater.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/paint_controller_paint_test.h
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/paint_layer.h
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/paint_layer_clipper.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/paint_layer_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/d85d2145dfe588b218d39cad730bc09736bca86e/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
Project Member

Comment 49 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9daa687e026e5dfbc15c5558b13a378254f26bc

commit f9daa687e026e5dfbc15c5558b13a378254f26bc
Author: Stefan Zager <szager@chromium.org>
Date: Fri Jun 22 18:33:58 2018

Avoid constructing scrollbars just to measure their thickness.

Introduce the method HyoptheticalScrollbarThickness, which avoids constructing a scrollbar. This
might be useful in figuring out overflow:auto scrollbars as well (left for a future CL).

R=skobes@chromium.org
BUG=823365

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id7d3a1be44f7146bfbb2d650e9fa0d647db54f3f
Reviewed-on: https://chromium-review.googlesource.com/1110892
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569705}
[modify] https://crrev.com/f9daa687e026e5dfbc15c5558b13a378254f26bc/third_party/blink/renderer/core/frame/frame_view_auto_size_info.cc
[modify] https://crrev.com/f9daa687e026e5dfbc15c5558b13a378254f26bc/third_party/blink/renderer/core/layout/layout_scrollbar.cc
[modify] https://crrev.com/f9daa687e026e5dfbc15c5558b13a378254f26bc/third_party/blink/renderer/core/layout/layout_scrollbar.h
[modify] https://crrev.com/f9daa687e026e5dfbc15c5558b13a378254f26bc/third_party/blink/renderer/core/layout/layout_scrollbar_part.cc
[modify] https://crrev.com/f9daa687e026e5dfbc15c5558b13a378254f26bc/third_party/blink/renderer/core/layout/layout_scrollbar_part.h
[modify] https://crrev.com/f9daa687e026e5dfbc15c5558b13a378254f26bc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/f9daa687e026e5dfbc15c5558b13a378254f26bc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
Project Member

Comment 50 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72f6a9c759b4a4063c228ba10b615fb4379aa772

commit 72f6a9c759b4a4063c228ba10b615fb4379aa772
Author: Stefan Zager <szager@chromium.org>
Date: Fri Jun 22 21:34:41 2018

Remove unnecessary local_frame_view.h includes.

This reduces the number of .cc files dependent on local_frame_view.h
from 2469 to 1930.

BUG=823365
R=skobes@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4631d893f47cd6a6b3768715f6328adfe17dc15c
Reviewed-on: https://chromium-review.googlesource.com/1112391
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569789}
[modify] https://crrev.com/72f6a9c759b4a4063c228ba10b615fb4379aa772/third_party/blink/renderer/core/animation/scroll_timeline.cc
[modify] https://crrev.com/72f6a9c759b4a4063c228ba10b615fb4379aa772/third_party/blink/renderer/core/editing/markers/document_marker_controller.cc
[modify] https://crrev.com/72f6a9c759b4a4063c228ba10b615fb4379aa772/third_party/blink/renderer/core/frame/remote_frame_view.h
[modify] https://crrev.com/72f6a9c759b4a4063c228ba10b615fb4379aa772/third_party/blink/renderer/core/layout/layout_embedded_content.h
[modify] https://crrev.com/72f6a9c759b4a4063c228ba10b615fb4379aa772/third_party/blink/renderer/core/layout/layout_grid.cc
[modify] https://crrev.com/72f6a9c759b4a4063c228ba10b615fb4379aa772/third_party/blink/renderer/core/layout/layout_object.h
[modify] https://crrev.com/72f6a9c759b4a4063c228ba10b615fb4379aa772/third_party/blink/renderer/core/layout/ng/ng_absolute_utils.cc
[modify] https://crrev.com/72f6a9c759b4a4063c228ba10b615fb4379aa772/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
[modify] https://crrev.com/72f6a9c759b4a4063c228ba10b615fb4379aa772/third_party/blink/renderer/core/paint/paint_layer.h
Project Member

Comment 51 by bugdroid1@chromium.org, Jun 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807c7cf898178b44c11866b69cf350da47f41b76

commit 807c7cf898178b44c11866b69cf350da47f41b76
Author: Steve Kobes <skobes@chromium.org>
Date: Sat Jun 23 22:39:38 2018

Remove ScrollableArea::IsScrollable and IsProgrammaticallyScrollable.

The first is redundant with PLSA::ScrollsOverflow; the other is unused.

Also remove LFV::GetScrollingReasons, which was used in a confusing way
by MainThreadScrollingReasonsPerFrame.

Bug: 823365
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iff0e8dae4bf80979868f5718427856d2efff7575
Reviewed-on: https://chromium-review.googlesource.com/1112066
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569896}
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/core/events/touch_event.cc
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/core/frame/root_frame_viewport.cc
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
[modify] https://crrev.com/807c7cf898178b44c11866b69cf350da47f41b76/third_party/blink/renderer/platform/scroll/scrollable_area.h
Project Member

Comment 52 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/308abdfea066764fbed3e7b84274f3f07a1df247

commit 308abdfea066764fbed3e7b84274f3f07a1df247
Author: Stefan Zager <szager@chromium.org>
Date: Mon Jun 25 01:16:09 2018

[RootLayerScrolls] Eliminate calls to LocalFrameView::VisibleContent*

VisibleContentRect() and VisibleContentSize() are based on
scroll_offset_ (which is always (0, 0)), and Size() with scrollbars
possible excluded -- but there are no scrollbars any more. Replace
all of the calls with Size().

BUG=823365
TBR=dmazzoni@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ieb41515bf53e20762aca9f81df413ebb397c9f5d
Reviewed-on: https://chromium-review.googlesource.com/1112067
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569944}
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/clipboard/data_transfer.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/frame/remote_frame_view.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/html/forms/internal_popup_menu.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/input/event_handling_util.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/input/touch_action_test.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/inspector/inspector_overlay_agent.h
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/paint/frame_painter.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/paint/object_paint_invalidator.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/paint/paint_invalidator.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/svg/graphics/svg_image_test.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/svg/svg_svg_element.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/308abdfea066764fbed3e7b84274f3f07a1df247/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
Project Member

Comment 53 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d22ea4a97ad699cb512acf6f55dbdf67b86b7225

commit d22ea4a97ad699cb512acf6f55dbdf67b86b7225
Author: Stefan Zager <szager@chromium.org>
Date: Tue Jun 26 00:32:43 2018

[RootLayerScrolls] Delete obsolete 'scrollbars suppressed' code.

Even before RLS landed, this functionality appears only to have been
accessed by an obsolete internals API.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I599103f2ba4ff4270eddfa11bef2eb016e612484
Reviewed-on: https://chromium-review.googlesource.com/1114067
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570267}
[modify] https://crrev.com/d22ea4a97ad699cb512acf6f55dbdf67b86b7225/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/d22ea4a97ad699cb512acf6f55dbdf67b86b7225/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/d22ea4a97ad699cb512acf6f55dbdf67b86b7225/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/d22ea4a97ad699cb512acf6f55dbdf67b86b7225/third_party/blink/renderer/core/svg/graphics/svg_image.cc
[modify] https://crrev.com/d22ea4a97ad699cb512acf6f55dbdf67b86b7225/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/d22ea4a97ad699cb512acf6f55dbdf67b86b7225/third_party/blink/renderer/core/testing/internals.h
[modify] https://crrev.com/d22ea4a97ad699cb512acf6f55dbdf67b86b7225/third_party/blink/renderer/core/testing/internals.idl
Project Member

Comment 55 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35f6dd337c9f336cb4f9a322e444a1f60668f2fc

commit 35f6dd337c9f336cb4f9a322e444a1f60668f2fc
Author: Stefan Zager <szager@chromium.org>
Date: Wed Jun 27 23:57:06 2018

[RootLayerScrolls] Make scroll origin PLSA-specific.

PLSA is the only ScrollableArea subclass that ever gets a non-zero
scroll origin. Push all the logic down into PLSA.

BUG=823365
R=skobes@chromium.org,bokan@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I163b409a66c8b6d1dd248e51aae843cba109395e
Reviewed-on: https://chromium-review.googlesource.com/1114460
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570949}
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/frame/root_frame_viewport.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/frame/root_frame_viewport.h
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/frame/visual_viewport.h
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/input/gesture_manager.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/layout/layout_tree_as_text.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/page/page_animator.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/page/scrolling/snap_coordinator_test.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/platform/mac/scroll_animator_mac.mm
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/platform/scroll/scroll_animator_compositor_coordinator.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/platform/scroll/scroll_types.h
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/platform/scroll/scrollable_area.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/platform/scroll/scrollable_area.h
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/platform/scroll/scrollable_area_test.cc
[modify] https://crrev.com/35f6dd337c9f336cb4f9a322e444a1f60668f2fc/third_party/blink/renderer/platform/scroll/scrollbar_test_suite.h
Project Member

Comment 56 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd339622dc7f73f303796786b8e50615c7b52da3

commit dd339622dc7f73f303796786b8e50615c7b52da3
Author: Stefan Zager <szager@chromium.org>
Date: Thu Jun 28 20:05:16 2018

[RootLayerScrolls] Refactor scrollbar mode logic out of LocalFrameView

LocalFrameView no longer needs scrollbar modes. Also, move the autosize
scrollbar mode logic in LayoutView. LayoutView::CalculateScrollbarModes
is now the source of truth.

BUG=823365
R=pdr@chromium.org,skobes@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie7bee820d189403c50d0b18d76bc14854e2998b8
Reviewed-on: https://chromium-review.googlesource.com/1117772
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571238}
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/core/frame/frame_view_auto_size_info.cc
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/core/layout/layout_media.cc
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/core/layout/layout_view.h
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/platform/scroll/scrollable_area.cc
[modify] https://crrev.com/dd339622dc7f73f303796786b8e50615c7b52da3/third_party/blink/renderer/platform/scroll/scrollable_area.h
Project Member

Comment 57 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b833403a143b92b13d55886ca65a00f998f540ec

commit b833403a143b92b13d55886ca65a00f998f540ec
Author: Stefan Zager <szager@chromium.org>
Date: Thu Jun 28 20:32:52 2018

[RootLayerScrolls] Get rid of obsolete kInFrameCoordinates constant

"Frame content" coordinates are no longer a thing.

BUG=823365
R=skobes@chromium.org,chrishtr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6e82c57a8bc9008402407639d4e2e4a60161e337
Reviewed-on: https://chromium-review.googlesource.com/1117889
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571247}
[modify] https://crrev.com/b833403a143b92b13d55886ca65a00f998f540ec/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/b833403a143b92b13d55886ca65a00f998f540ec/third_party/blink/renderer/core/layout/map_coordinates_flags.h
[modify] https://crrev.com/b833403a143b92b13d55886ca65a00f998f540ec/third_party/blink/renderer/core/paint/paint_invalidator.cc
Project Member

Comment 58 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/003c57ca59cbd0291eb14747f6d2be74f70cf601

commit 003c57ca59cbd0291eb14747f6d2be74f70cf601
Author: Stefan Zager <szager@chromium.org>
Date: Fri Jun 29 18:09:34 2018

[RootLayerScrolls] Mac-specific fixes

Get rid of Mac-specific code that uses LocalFrameView as a
ScrollableArea.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic7f7ffe99d2d3fdd6e12dd950d78e4f26eecdf9b
Reviewed-on: https://chromium-review.googlesource.com/1119664
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571545}
[modify] https://crrev.com/003c57ca59cbd0291eb14747f6d2be74f70cf601/third_party/blink/renderer/core/paint/theme_painter_mac.mm
[modify] https://crrev.com/003c57ca59cbd0291eb14747f6d2be74f70cf601/third_party/blink/renderer/platform/mac/theme_mac.h
[modify] https://crrev.com/003c57ca59cbd0291eb14747f6d2be74f70cf601/third_party/blink/renderer/platform/mac/theme_mac.mm
Project Member

Comment 59 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5139b9b056f8b29465f48ac899d7a39cf5809a6

commit f5139b9b056f8b29465f48ac899d7a39cf5809a6
Author: Stefan Zager <szager@chromium.org>
Date: Fri Jun 29 19:39:51 2018

[RootLayerScrolls] Unit test fixes

Miscellaneous fixes to tests that still used LocalFrameView as a
ScrollableArea.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I10e5a2d6c3519a127cb315ffee80d5bfe05dfaca
Reviewed-on: https://chromium-review.googlesource.com/1119769
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571596}
[modify] https://crrev.com/f5139b9b056f8b29465f48ac899d7a39cf5809a6/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/f5139b9b056f8b29465f48ac899d7a39cf5809a6/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/f5139b9b056f8b29465f48ac899d7a39cf5809a6/third_party/blink/renderer/core/frame/browser_controls_test.cc
[modify] https://crrev.com/f5139b9b056f8b29465f48ac899d7a39cf5809a6/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/f5139b9b056f8b29465f48ac899d7a39cf5809a6/third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
[modify] https://crrev.com/f5139b9b056f8b29465f48ac899d7a39cf5809a6/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/f5139b9b056f8b29465f48ac899d7a39cf5809a6/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/f5139b9b056f8b29465f48ac899d7a39cf5809a6/third_party/blink/renderer/core/paint/paint_layer_test.cc
[modify] https://crrev.com/f5139b9b056f8b29465f48ac899d7a39cf5809a6/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
Project Member

Comment 60 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/865916b3e399f5bfeefe082cfaa23bf9172c8bdd

commit 865916b3e399f5bfeefe082cfaa23bf9172c8bdd
Author: Stefan Zager <szager@chromium.org>
Date: Fri Jun 29 19:46:40 2018

[RootLayerScrolls] Delete scrollbar logic from GetLayoutSize

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Change-Id: I7b47fe3b3ac33b93c9b1a8fc118b154169d48c3a
Reviewed-on: https://chromium-review.googlesource.com/1119770
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571598}
[modify] https://crrev.com/865916b3e399f5bfeefe082cfaa23bf9172c8bdd/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/865916b3e399f5bfeefe082cfaa23bf9172c8bdd/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/865916b3e399f5bfeefe082cfaa23bf9172c8bdd/third_party/blink/renderer/core/layout/layout_view.cc
Project Member

Comment 61 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/566c97e6ac7ce97acde6b4de3725270971049a9f

commit 566c97e6ac7ce97acde6b4de3725270971049a9f
Author: Stefan Zager <szager@chromium.org>
Date: Fri Jun 29 23:01:49 2018

[RootLayerScrolls] Don't use LocalFrameView as a ScrollableArea

Delete a bunch of places where LocalFrameView is used as a
a ScrollableArea. In many places, the code is no-op and can be
deleted; in other places, migrate to methods that are not declared
on ScrollableArea.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifefb7676b6501ca1ec42bb5a7339a762023e4f96
Reviewed-on: https://chromium-review.googlesource.com/1119771
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571697}
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/editing/finder/find_in_page_coordinates.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/events/mouse_event.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/frame/remote_frame_view.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/input/gesture_manager.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/input/mouse_event_manager.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/layout/intersection_geometry.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/layout/scroll_anchor.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/paint/paint_layer_clipper.cc
[modify] https://crrev.com/566c97e6ac7ce97acde6b4de3725270971049a9f/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
Project Member

Comment 62 by bugdroid1@chromium.org, Jun 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88d8498ab4cf6c6be67e3d1dd1e4611c14fbace2

commit 88d8498ab4cf6c6be67e3d1dd1e4611c14fbace2
Author: Stefan Zager <szager@chromium.org>
Date: Sat Jun 30 00:31:02 2018

[RootLayerScrolls] LocalFrameView is not a ScrollableArea

And there was much rejoicing throughout the land.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Change-Id: Iadef3f9dc5785e1218555a771667474a0fa3ba60
Reviewed-on: https://chromium-review.googlesource.com/1119772
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571714}
[modify] https://crrev.com/88d8498ab4cf6c6be67e3d1dd1e4611c14fbace2/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/88d8498ab4cf6c6be67e3d1dd1e4611c14fbace2/third_party/blink/renderer/core/frame/local_frame_view.h
Project Member

Comment 63 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d36ece145181ec8e63daa16b2176dd3602cbff4

commit 6d36ece145181ec8e63daa16b2176dd3602cbff4
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Jul 04 01:01:32 2018

[RootLayerScrolls] Remove deadcode in LocalFrameView

This was generated using:
https://chromium-coverage.appspot.com/reports/572002/linux/chromium/src/third_party/blink/renderer/core/frame/local_frame_view.cc.html

BUG=823365

Change-Id: I136ba88950e2d042fd330cedb88614562af2e264
Reviewed-on: https://chromium-review.googlesource.com/1125309
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572419}
[modify] https://crrev.com/6d36ece145181ec8e63daa16b2176dd3602cbff4/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/6d36ece145181ec8e63daa16b2176dd3602cbff4/third_party/blink/renderer/core/frame/local_frame_view.h
Project Member

Comment 64 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/802a13fcdbedcdf26cd3198ff380179c343ce6c4

commit 802a13fcdbedcdf26cd3198ff380179c343ce6c4
Author: Stefan Zager <szager@chromium.org>
Date: Wed Jul 11 05:01:04 2018

Move GraphicsLayer text dumping out of platform.

The immediate motivation for this patch is to pave the way to move
stuff out of platform/scroll and into core/. That aside, it probably
makes more sense to put this kind of code in core/ rather than
platform/.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0859fbfa6ddf82c607a36cbbd0bee77e49a3c0b0
Reviewed-on: https://chromium-review.googlesource.com/1131000
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574081}
[modify] https://crrev.com/802a13fcdbedcdf26cd3198ff380179c343ce6c4/third_party/blink/public/platform/web_scroll_into_view_params.h
[modify] https://crrev.com/802a13fcdbedcdf26cd3198ff380179c343ce6c4/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/802a13fcdbedcdf26cd3198ff380179c343ce6c4/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/802a13fcdbedcdf26cd3198ff380179c343ce6c4/third_party/blink/renderer/core/paint/BUILD.gn
[add] https://crrev.com/802a13fcdbedcdf26cd3198ff380179c343ce6c4/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
[add] https://crrev.com/802a13fcdbedcdf26cd3198ff380179c343ce6c4/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.h
[modify] https://crrev.com/802a13fcdbedcdf26cd3198ff380179c343ce6c4/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/802a13fcdbedcdf26cd3198ff380179c343ce6c4/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/802a13fcdbedcdf26cd3198ff380179c343ce6c4/third_party/blink/renderer/platform/graphics/graphics_layer.h
Project Member

Comment 65 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb9b545a199897e05ca621e40fd5e93289f82bd

commit ecb9b545a199897e05ca621e40fd5e93289f82bd
Author: Stefan Zager <szager@chromium.org>
Date: Thu Jul 12 05:49:51 2018

Move scroll-related platform test code into core/testing/

Also delete unused fake_scrollable_area.h.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5620b9c31d53d523108c0c7a3a247264e588fc90
Reviewed-on: https://chromium-review.googlesource.com/1132380
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574494}
[modify] https://crrev.com/ecb9b545a199897e05ca621e40fd5e93289f82bd/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/ecb9b545a199897e05ca621e40fd5e93289f82bd/third_party/blink/renderer/core/editing/rendered_position_test.cc
[modify] https://crrev.com/ecb9b545a199897e05ca621e40fd5e93289f82bd/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/ecb9b545a199897e05ca621e40fd5e93289f82bd/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater_test.cc
[modify] https://crrev.com/ecb9b545a199897e05ca621e40fd5e93289f82bd/third_party/blink/renderer/core/testing/core_unit_test_helper.h
[rename] https://crrev.com/ecb9b545a199897e05ca621e40fd5e93289f82bd/third_party/blink/renderer/core/testing/use_mock_scrollbar_settings.h
[modify] https://crrev.com/ecb9b545a199897e05ca621e40fd5e93289f82bd/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/ecb9b545a199897e05ca621e40fd5e93289f82bd/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[delete] https://crrev.com/e5939dab948bcde131510fa955f2802e93159238/third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h
Project Member

Comment 66 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/442f13b7e97747ab09612a101159b1eb26072382

commit 442f13b7e97747ab09612a101159b1eb26072382
Author: Stefan Zager <szager@chromium.org>
Date: Thu Jul 12 16:18:15 2018

Get rid of GraphicsLayer::scrollable_area_

The only place where it was actually used was in
GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
call to the GraphicsLayerClient.

BUG=823365
R=pdr@chromium.org,skobes@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
Reviewed-on: https://chromium-review.googlesource.com/1132536
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574587}
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/core/frame/visual_viewport.h
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/core/layout/scrollbars_test.cc
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/442f13b7e97747ab09612a101159b1eb26072382/third_party/blink/renderer/platform/graphics/graphics_layer_client.h
Project Member

Comment 67 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f8543e5ccf9425b94b8e53536d8b4c1ee26c1ca

commit 3f8543e5ccf9425b94b8e53536d8b4c1ee26c1ca
Author: Stefan Zager <szager@chromium.org>
Date: Mon Jul 23 02:03:46 2018

Add class WebScrollbarThemeClient

This is an abstraction to facilitate moving the bulk of platform/scroll
into core. WebScrollbarTheme provides a Mac-only API which is called
into from content, and affects the styling of all scrollbars. After
this patch, all of the other scrollbar and scrollbar theme code can move
out of platform.

BUG=823365
R=skobes@chromium.org,chrishtr@chromium.org
TBR=dgozman@chromium.org

Change-Id: I888e08676b5343156ae391c44b2084e90023de0f
Reviewed-on: https://chromium-review.googlesource.com/1141116
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577102}
[modify] https://crrev.com/3f8543e5ccf9425b94b8e53536d8b4c1ee26c1ca/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/3f8543e5ccf9425b94b8e53536d8b4c1ee26c1ca/third_party/blink/public/platform/mac/web_scrollbar_theme.h
[modify] https://crrev.com/3f8543e5ccf9425b94b8e53536d8b4c1ee26c1ca/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/3f8543e5ccf9425b94b8e53536d8b4c1ee26c1ca/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.h
[modify] https://crrev.com/3f8543e5ccf9425b94b8e53536d8b4c1ee26c1ca/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.mm
[modify] https://crrev.com/3f8543e5ccf9425b94b8e53536d8b4c1ee26c1ca/third_party/blink/renderer/platform/scroll/web_scrollbar_theme.mm
[add] https://crrev.com/3f8543e5ccf9425b94b8e53536d8b4c1ee26c1ca/third_party/blink/renderer/platform/scroll/web_scrollbar_theme_client.h
Project Member

Comment 68 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef6a17cffa51a9cf55a1da5315385792e98e59e1

commit ef6a17cffa51a9cf55a1da5315385792e98e59e1
Author: Stefan Zager <szager@chromium.org>
Date: Thu Aug 02 18:43:59 2018

Move most files from platform/scroll/ to core/scroll/

Most of the functionality in these files interacts closely with layout and paint, so it makes sense
to put them in core/ to eliminate needless indirection. Since there are no remaining sub-classes of
ScrollableArea outside of core/ this is mostly a mechanical refactoring.

The PlatformChromeClient class is removed here, as it is now obsolete. Previously, the only
subclasses were ChromeClient (in core/page/) and a unit testing stub in
platform/scroll/scrollbar_test_suite.h. Since scrollbar_test_suite.h has moved into core/scroll/,
it can use EmptyChromeClient (from core/loader/), just as other unit tests in core/ do.

BUG=823365
R=skobes@chromium.org,chrishtr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I08567764310b0190de45e40789d83ce80b600dd0
Reviewed-on: https://chromium-review.googlesource.com/1136888
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580266}
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/public/platform/mac/web_scrollbar_theme.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/public/platform/web_scroll_into_view_params.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/css/css_primitive_value_mappings.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/css/selector_checker.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/editing/commands/editor_command.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/root_frame_viewport.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/root_frame_viewport.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/root_frame_viewport_test.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/settings.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/visual_viewport.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/html/forms/spin_button_element.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/html/image_document.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/input/event_handling_util.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/input/gesture_manager.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/input/scroll_manager.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/inspector/dev_tools_host.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/inspector/inspector_highlight.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/hit_test_result.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_scrollbar.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_scrollbar_theme.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_scrollbar_theme.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_text_control.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_theme.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_theme_default.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_theme_default.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_theme_mac.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_theme_mac.mm
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/layout_view.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/layout/scrollbars_test.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/chrome_client.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/chrome_client.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/print_context_test.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/scrolling/root_scroller_controller.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/scrolling/scroll_state.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/scrolling/top_document_root_scroller_controller.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/scrolling/viewport_scroll_callback.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/validation_message_client_impl.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/page/viewport_test.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/paint/paint_invalidator.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/paint/scrollable_area_painter.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/paint/scrollbar_painter.h
[add] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/BUILD.gn
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/ns_scroller_imp_details.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/programmatic_scroll_animator.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/programmatic_scroll_animator.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_animator.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_animator.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_animator_base.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_animator_base.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_animator_compositor_coordinator.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_animator_compositor_coordinator.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_animator_mac.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_animator_mac.mm
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_animator_test.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_customization.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_customization.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scroll_state_data.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollable_area.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollable_area.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollable_area_test.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_layer_delegate.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_layer_delegate.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_test_suite.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_android.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_aura.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_aura.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_aura_test.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_mac.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_mac.mm
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_mock.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_mock.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_overlay.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_overlay.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_overlay_mock.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/scrollbar_theme_overlay_test.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/smooth_scroll_sequencer.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/smooth_scroll_sequencer.h
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/web_scroll_into_view_params.cc
[rename] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/scroll/web_scrollbar_theme.mm
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/testing/core_unit_test_helper.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/testing/sim/sim_test.cc
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/core/testing/use_mock_scrollbar_settings.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/platform/mac/theme_mac.mm
[delete] https://crrev.com/44042b68646ce12e216dde3164c743e22b6a7548/third_party/blink/renderer/platform/platform_chrome_client.h
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/renderer/platform/scroll/DEPS
[modify] https://crrev.com/ef6a17cffa51a9cf55a1da5315385792e98e59e1/third_party/blink/tools/audit_non_blink_usage.py
Project Member

Comment 69 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a627649ec4bd720e08f94360d48caf4d6ac3fb

commit 18a627649ec4bd720e08f94360d48caf4d6ac3fb
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Aug 02 21:34:59 2018

[RootLayerScrolls] Remove internal LFV check in ScrollableAreaForNode

This internals-only code is not needed post-rls.

BUG=823365

Change-Id: I48e9a149230a89bc235e3323a132420764fbc394
Reviewed-on: https://chromium-review.googlesource.com/1154321
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580333}
[modify] https://crrev.com/18a627649ec4bd720e08f94360d48caf4d6ac3fb/third_party/blink/renderer/core/testing/internals.cc

Comment 70 by skobes@chromium.org, Sep 6

Status: Fixed (was: Assigned)
RLS post-launch code cleanup is complete.

Two regression bugs still repro - issue 816595 (Mac scrollbars don't shrink during elastic overscroll) and issue 826647 (DevTools Layers tab shows blank layers) - but we don't need to track them here.

Comment 71 by szager@chromium.org, Sep 6 

\o/
Project Member

Comment 72 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7834579b7d67fc897ee10a21984c61bf8b35b08a

commit 7834579b7d67fc897ee10a21984c61bf8b35b08a
Author: David Bokan <bokan@chromium.org>
Date: Tue Oct 30 15:48:36 2018

Remove unused pre-root-layer-scrolling code.

PendingOffsetToScroll was previously used to store where the layout box
was being scrolled to. There was a pre-RLS fixup to this value but it's
no longer set to anything other than its initial value so this CL
removes the entire value.

Bug: 823365,741830
Change-Id: I4d4090b629ad614bf691ea6360240fea7d43982d
Reviewed-on: https://chromium-review.googlesource.com/c/1305818
Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603915}
[modify] https://crrev.com/7834579b7d67fc897ee10a21984c61bf8b35b08a/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/7834579b7d67fc897ee10a21984c61bf8b35b08a/third_party/blink/renderer/core/layout/layout_box.h
►

Sign in to add a comment