New issue
Advanced search Search tips

Issue 823352 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 823315
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Some metrics in thread_times benchmarks drop to 0

Project Member Reported by sullivan@chromium.org, Mar 19 2018

Issue description

https://chromeperf.appspot.com/report?sid=108f2f611fcde261c3dcdb219ac0620ac42126310b6d1bd46001b6589eee0a5e

I noticed this when triaging perf bugs. Was this expected? Kicking off some bisects. Setting to Pri-1, but please drop priority if it was not expected.
 
I noticed that reference builds do NOT drop to 0, so this is likely a change outside of telemetry: https://chromeperf.appspot.com/report?sid=44d052ed188d92e0ce6813ffd5cb403a71ce373e35ca4b5942da9407a691e14c
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Mar 19 2018

Cc: haraken@chromium.org kinuko@chromium.org altimin@chromium.org
Owner: altimin@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/15c6a0b9440000

[scheduler] Use WorkerSchedulerProxy in DedicatedWorkerThread. by altimin@chromium.org
https://chromium.googlesource.com/chromium/src/+/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
altimin: this CL caused a lot of the thread_times metrics to drop to 0. Was this intentional?
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Mar 19 2018

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12a66e19440000

[scheduler] Use WorkerSchedulerProxy in DedicatedWorkerThread. by altimin@chromium.org
https://chromium.googlesource.com/chromium/src/+/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Mar 19 2018

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/128cbc39440000

[scheduler] Use WorkerSchedulerProxy in DedicatedWorkerThread. by altimin@chromium.org
https://chromium.googlesource.com/chromium/src/+/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Mergedinto: 823315
Status: Duplicate (was: Assigned)
Re #6: No, this is not intentional -- the compositor thread name was renamed accidentally. The fix has already landed. 

Sign in to add a comment