Issue metadata
Sign in to add a comment
|
thread_times.tough_scrolling_cases broken at 543354:543377 |
||||||||||||||||||||||||
Issue descriptionThe benchmark displays 0.0ms which is wrong. Suspect renaming compositor thread in traces from "Compositor" to "Compositor thread"
,
Mar 19 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15a572f1440000
,
Mar 19 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16b05db9440000
,
Mar 19 2018
The culprit CL: https://crrev.com/c/957046, it switches traces to use "Compositor thread" instead of "Compositor" for a thread name. This breaks all timeline-based metrics because the script expects the name to be "Compositor": https://cs.chromium.org/chromium/src/tools/perf/metrics/timeline.py?rcl=ac01799a7a69e348f68e9c12c886ee7afc126997&l=24 tdresser@: what would be better: to change the thread name back or to adjust a name that benchmarks use?
,
Mar 19 2018
I'm already landing a fix: https://chromium-review.googlesource.com/c/chromium/src/+/969042
,
Mar 19 2018
,
Mar 19 2018
Reverting seems correct to me. Doc forthcoming from dproy@ on how we can integration test things like this more effectively.
,
Mar 19 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/16b05db9440000
,
Mar 19 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/15a572f1440000 [scheduler] Use WorkerSchedulerProxy in DedicatedWorkerThread. by altimin@chromium.org https://chromium.googlesource.com/chromium/src/+/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 21 2018
The graphs have recovered. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 19 2018