New issue
Advanced search Search tips

Issue 823348 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 823315
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

thread_times.tough_scrolling_cases broken at 543354:543377

Project Member Reported by alexilin@chromium.org, Mar 19 2018

Issue description

The benchmark displays 0.0ms which is wrong.
Suspect renaming compositor thread in traces from "Compositor" to "Compositor thread" 
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 19 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=823348

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8ba08f9cfaea950553ee491ec9473946d15f30619990ecc6b1bdaf73d66499eb


Bot(s) for this bug's original alert(s):

android-nexus5
Cc: haraken@chromium.org kinuko@chromium.org tdres...@chromium.org altimin@chromium.org
Components: Speed>Tracing
Labels: -Pri-2 Pri-1
The culprit CL: https://crrev.com/c/957046, it switches traces to use "Compositor thread" instead of "Compositor" for a thread name. 

This breaks all timeline-based metrics because the script expects the name to be "Compositor": https://cs.chromium.org/chromium/src/tools/perf/metrics/timeline.py?rcl=ac01799a7a69e348f68e9c12c886ee7afc126997&l=24

tdresser@: what would be better: to change the thread name back or to adjust a name that benchmarks use?
Mergedinto: 823315
Status: Duplicate (was: Untriaged)
Cc: maxlg@chromium.org dproy@chromium.org
Reverting seems correct to me.

Doc forthcoming from dproy@ on how we can integration test things like this more effectively.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Mar 19 2018

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/16b05db9440000
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Mar 19 2018

Owner: altimin@chromium.org
Status: Assigned (was: Duplicate)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/15a572f1440000

[scheduler] Use WorkerSchedulerProxy in DedicatedWorkerThread. by altimin@chromium.org
https://chromium.googlesource.com/chromium/src/+/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Status: Fixed (was: Assigned)
The graphs have recovered.

Sign in to add a comment