New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823334 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[Autotest] hardware_memoryqual hangs when perform 10000 iterations of suspension tests.

Project Member Reported by sidal@chromium.org, Mar 19 2018

Issue description

Request cherry pick the following changelist into M65 Release:
     https://chromium-review.googlesource.com/944254
     https://chromium-review.googlesource.com/959184

Bug Description:
     Control file for hardware_memoryqual autotest suite performs 10000 suspension tests, which will cause ssh timeout to DUT from Moblab and fail the test suite. Moblab user used to be able to manually modify autotest control files to run only 2 iterations of suspension tests. However, this feature was removed due to security concerns.
Link: https://bugs.chromium.org/p/chromium/issues/detail?id=753607

     To solve this issue, modify the control file and reduce to 2 iterations of suspension tests.

Cherrypick Reason and Risk:
     This bug blocks partners from performing hardware_memoryqual test and halt the progress of Memory AVL process.

      This bug is related to hardware_memoryqual autotest sutie. It does not affect production images. Only test images will be affected.

      The hardware_memoryqual autotest suite is only used by partners to test memory components during the memory AVL process. This will only affect test images and will not impact users.

More details:
      https://issuetracker.google.com/74078789
 
These need to be merged into 66 and verified there before we pick into 65.

Comment 3 by sidal@chromium.org, Mar 19 2018

Cc: josa...@chromium.org
Labels: M-66 Merge-Request-66
Created the following CLs to cherry pick into M66 first:
     https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/969223
     https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/969224
     

Project Member

Comment 4 by sheriffbot@chromium.org, Mar 19 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
approved for m66
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 19 2018

Labels: merge-merged-release-R66-10452.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e7f71ee2d5be16f563a2b084c3cd6aaa58124429

commit e7f71ee2d5be16f563a2b084c3cd6aaa58124429
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Mon Mar 19 20:28:53 2018

Remove memory_qual suite tag from control.memory_qual

We observed SSH time out error when running this test.
To fix that, we already have control.memory_qual_moblab
that remove the 10K loops suspend part.

This CL removes control.memory_qual from the autotest
suite because we already add control.memory_qual_moblab
to the suite instead.

BUG=b:74078789, chromium:823334 
TEST=None

Change-Id: Ic63f6f01175c0407a40f797f1253b9f09b97b370
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/959184
Commit-Ready: Sida Liu <sidal@chromium.org>
Tested-by: Sida Liu <sidal@chromium.org>
Reviewed-by: Sida Liu <sidal@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@google.com>
(cherry picked from commit 3f5b7a4548df229224da26c83bf32133ddb59664)
Reviewed-on: https://chromium-review.googlesource.com/969223
Commit-Queue: Sida Liu <sidal@chromium.org>

[modify] https://crrev.com/e7f71ee2d5be16f563a2b084c3cd6aaa58124429/server/site_tests/sequences/control.memory_qual

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/85b46d53a754efe8705fc08f4fcfa441974c1f35

commit 85b46d53a754efe8705fc08f4fcfa441974c1f35
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Mon Mar 19 20:28:55 2018

memory_qual: Add new control file for moblab

moblab can't run 10K suspend loops as test will fail because
moblab can't SSH in to the DUT.

Before this we use moblab control file editing feature to manually
change loop count to 2 but this feature is dropped.

This CL fixes that by add new control file to run this test in moblab.

BUG=b:74078789,  chromium:823334 
TEST=None

Change-Id: I29fef7d8338aa8cf69f4b0f9e91eeda409cc5b78
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/944254
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
(cherry picked from commit afe70ae426b949a5df9ddedd179159409cceb562)
Reviewed-on: https://chromium-review.googlesource.com/969224
Reviewed-by: Sida Liu <sidal@chromium.org>
Commit-Queue: Sida Liu <sidal@chromium.org>
Tested-by: Sida Liu <sidal@chromium.org>

[add] https://crrev.com/85b46d53a754efe8705fc08f4fcfa441974c1f35/server/site_tests/sequences/control.memory_qual_moblab

Labels: -Hotlist-Merge-Review -Merge-Request-65 Merge-Approved-65
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 22 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0c1e20ab2d32750d62a45e698606817adb60c6e8

commit 0c1e20ab2d32750d62a45e698606817adb60c6e8
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Thu Mar 22 22:06:44 2018

Remove memory_qual suite tag from control.memory_qual

We observed SSH time out error when running this test.
To fix that, we already have control.memory_qual_moblab
that remove the 10K loops suspend part.

This CL removes control.memory_qual from the autotest
suite because we already add control.memory_qual_moblab
to the suite instead.

BUG=b:74078789, chromium:823334 
TEST=None

Change-Id: Ic63f6f01175c0407a40f797f1253b9f09b97b370
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/959184
Commit-Ready: Sida Liu <sidal@chromium.org>
Tested-by: Sida Liu <sidal@chromium.org>
Reviewed-by: Sida Liu <sidal@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@google.com>
(cherry picked from commit 3f5b7a4548df229224da26c83bf32133ddb59664)
Reviewed-on: https://chromium-review.googlesource.com/969221
Commit-Queue: Sida Liu <sidal@chromium.org>

[modify] https://crrev.com/0c1e20ab2d32750d62a45e698606817adb60c6e8/server/site_tests/sequences/control.memory_qual

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1c35531ca50c05914631ec58da6baedc9aeca5f5

commit 1c35531ca50c05914631ec58da6baedc9aeca5f5
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Thu Mar 22 22:06:46 2018

memory_qual: Add new control file for moblab

moblab can't run 10K suspend loops as test will fail because
moblab can't SSH in to the DUT.

Before this we use moblab control file editing feature to manually
change loop count to 2 but this feature is dropped.

This CL fixes that by add new control file to run this test in moblab.

BUG=b:74078789,  chromium:823334 
TEST=None

Change-Id: I29fef7d8338aa8cf69f4b0f9e91eeda409cc5b78
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/944254
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
(cherry picked from commit afe70ae426b949a5df9ddedd179159409cceb562)
Reviewed-on: https://chromium-review.googlesource.com/969222
Reviewed-by: Sida Liu <sidal@chromium.org>
Commit-Queue: Sida Liu <sidal@chromium.org>
Tested-by: Sida Liu <sidal@chromium.org>

[add] https://crrev.com/1c35531ca50c05914631ec58da6baedc9aeca5f5/server/site_tests/sequences/control.memory_qual_moblab

Project Member

Comment 11 by sheriffbot@chromium.org, Mar 26 2018

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 29 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-65 -Merge-Approved-66
Status: Fixed (was: Started)

Sign in to add a comment