Hmm - bettes@, is this the intended design here? I know pbos@ was working on something around icon colors.

I think this could be related to your change in https://chromium-review.googlesource.com/c/chromium/src/+/692817 but M65 sounds early unless it was done across the board.

My icon changes are reverted and I only touched colors for skia icons and favicons, so I think this skia change is unrelated.

I don't think we're trying to match platform style for icons embedded in views hierarchy, are we? FWIW I think we're doing the right thing aren't semantically OS folders but rather groupings of bookmarks.

Also "practically black" here in the screenshot is 0x5a5a5a, which is Chrome's current across-the-board icon color.

> Also "practically black" here in the screenshot is 0x5a5a5a, which is Chrome's current across-the-board icon color.

The icon is filled with whatever that color is - it's practically black.

> I don't think we're trying to match platform style for icons embedded in views hierarchy, are we?

Yes, we are. Views is not an end unto itself. The goal of Views is a toolkit that supports the UI style of its target platform. That is why, for example, the default button position in dialogs is on the right on macOS but backwards when running on other OSes. And so on.

Another way to explain this is the Bookmarks Bar shows macOS-style folder icons, while the Edit Bookmarks dialog shows folder icons that look quite different. However they are the exact same entity (i.e. both UI surfaces are showing bookmark folders), and so they should look the same. They should not be the almost-black icons which I guess are default for Views, but instead should match the current bookmark folder icons in the Chrome Mac bookmarks bar.

I'm not aware that we made a conscious decision on which icon to use. It's Alan's call for what we want, though shrike@ is right that either way it should be consistent with the bookmark bar.

On Windows we do get a OS-style icon, though I think it's kinda ugly. It would be more consistent with Chrome's UI to use the MD icon everywhere, though there is a certain user-friendliness to using the OS icon.

Just pointing out where the color comes from and how it got there (it's no accidental SK_ColorBlack or color calibration gone awry). Rest's up to Elly I think.

Tangentally I think it'd be nicer if the extra button just dumped the user into chrome://bookmarks with the bookmark selected and let the webUI own the more advanced bookmark editing, but I don't know how easy that is.

> Tangentally I think it'd be nicer if the extra button just dumped the user into chrome://bookmarks with the bookmark selected and let the webUI own the more advanced bookmark editing, but I don't know how easy that is.

Yeah, the UI in the Edit Bookmarks dialog is sadly crippled. Dropping into chrome://bookmarks might be better, though that UI is pretty clunky. It checks all the boxes on functionality but usability-wise it's very awkward.

Mac triage: WontFix here.