Refreshed during triage.

Refreshed during triage.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed2b20b64a40f0f461ebbffc040c9c007f257539

commit ed2b20b64a40f0f461ebbffc040c9c007f257539
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Oct 15 19:51:32 2018

Network Quality Estimator: Remove Network Quality Provider class

Network Quality Provider is the base class for network quality
estimator (NQE). It was originally added as a read-only version
of NQE with the goal of passing it to
consumers outside of //net, and preventing them
from calling internal net-specific APIs. With servicification, this is
no longer needed.

In short term, it also makes it simpler to plumb NQE to
H2 session class (see linked bug) which will be done
in a subsequent CL.

This is purely a refactor CL, and does not introduce any
functionality change.

Change-Id: Ibb5bbf6a06ca02d232fbca0c29022422738694f4
Bug:  823322 
Reviewed-on: https://chromium-review.googlesource.com/c/1280860
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599721}
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/BUILD.gn
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/http/http_network_session.cc
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/http/http_network_session.h
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/http/http_proxy_client_socket_pool.cc
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/http/http_proxy_client_socket_pool.h
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/nqe/network_quality_estimator.h
[delete] https://crrev.com/7fc2bace4e5d7d1b6fc5593de351bba9ec9f5596/net/nqe/network_quality_provider.cc
[delete] https://crrev.com/7fc2bace4e5d7d1b6fc5593de351bba9ec9f5596/net/nqe/network_quality_provider.h
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/nqe/throughput_analyzer.cc
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/nqe/throughput_analyzer.h
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/nqe/throughput_analyzer_unittest.cc
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/socket/client_socket_pool_manager_impl.cc
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/socket/client_socket_pool_manager_impl.h
[modify] https://crrev.com/ed2b20b64a40f0f461ebbffc040c9c007f257539/net/url_request/url_request_context_builder.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f

commit c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Oct 16 16:24:44 2018

NQE: Replace thread checker with sequence checker

In network quality estimator (NQE), replace all
occurences of thread checker by sequence checker.

This CL does not introduce any functionality changes.

This CL has been factored out of a larger CL that
hooks up NQE with the SPDY session class, and is
needed to prevent crashes in some of the tests.

Change-Id: I95eef8a8cc593812889ece20b5fb346df94c1608
Bug:  823322 
Reviewed-on: https://chromium-review.googlesource.com/c/1282722
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600010}
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/event_creator.cc
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/event_creator.h
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/network_qualities_prefs_manager.cc
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/network_qualities_prefs_manager_unittest.cc
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/network_quality_store.cc
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/network_quality_store.h
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/socket_watcher.cc
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/socket_watcher.h
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/socket_watcher_factory.h
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/throughput_analyzer.cc
[modify] https://crrev.com/c71cf62d19ed05c0cefaba0abe3d7a7662ebed2f/net/nqe/throughput_analyzer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/647b30d72a3df10915d2cc3e4d4f6e35df3868b4

commit 647b30d72a3df10915d2cc3e4d4f6e35df3868b4
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Oct 19 21:21:47 2018

NQE: Report H2 ping latency to network quality estimator

Report H2 ping latency to network quality estimator where
it is used for computing the network quality.

Change-Id: Ib25e339ccd3967293ec8be94ef35aaa2a30a0678
Bug:  823322 
Reviewed-on: https://chromium-review.googlesource.com/c/1285077
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601299}
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/http/http_network_session.cc
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/nqe/network_quality_observation.cc
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/nqe/network_quality_observation_source.cc
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/nqe/network_quality_observation_source.h
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/spdy/spdy_session.cc
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/spdy/spdy_session.h
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/spdy/spdy_session_pool.h
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/647b30d72a3df10915d2cc3e4d4f6e35df3868b4/tools/metrics/histograms/enums.xml

tbansal: What's the status of this issue?

Experiment is configured to run at ~15% in M-71 stable. M-71 goes to stable this week. So, I will start getting some data soon.