New issue
Advanced search Search tips

Issue 823310 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Make browser side fling work with viz

Project Member Reported by sahel@chromium.org, Mar 19 2018

Issue description

progressFling on the browser side calls SetNeedsBeginFrame to schedule the next fling animation progress.

On viz fling controller must use CompositorAnimationObserver to schedule next fling animation. 




 

Comment 1 by sahel@chromium.org, Mar 19 2018

Components: Blink>Scroll
Labels: -blinkscroll
Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e8570d900a200aafcc39a9256b6a90fdda3fb48

commit 9e8570d900a200aafcc39a9256b6a90fdda3fb48
Author: Sahel Sharify <sahel@chromium.org>
Date: Wed May 09 14:15:39 2018

Browser side fling works with viz enabled.

This cl decouples the fling controller client for sending events from
the fling controller client for scheduling and progressing the fling.

The FlingScheduler implements the fling controller scheduling client.
It schedules fling by either adding the FlingController as an animation
observer to ui::Compositor or by Calling SetNeedsBeginFrame if the
compositor is not available.

BrowserSideFlingBrowserTest.TouchpadFling
TBR=nasko@chromium.org

Bug:  823310 , 249063 
Test: BrowserSideFlingBrowserTest.TouchscreenFling,
Change-Id: I8c104daf41f87abdf0a78f3cb3d51274f279424b
Reviewed-on: https://chromium-review.googlesource.com/994181
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557171}
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/BUILD.gn
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/fling_browsertest.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/fling_controller.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/fling_controller.h
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/fling_controller_unittest.cc
[add] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/fling_scheduler.cc
[add] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/fling_scheduler.h
[add] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/fling_scheduler_mac.h
[add] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/fling_scheduler_mac.mm
[add] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/fling_scheduler_unittest.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/gesture_event_queue.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/gesture_event_queue.h
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/gesture_event_queue_unittest.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/input_router.h
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/input_router_client.h
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/input_router_impl.h
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/mock_input_router_client.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/input/mock_input_router_client.h
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/content/test/BUILD.gn
[modify] https://crrev.com/9e8570d900a200aafcc39a9256b6a90fdda3fb48/testing/buildbot/filters/viz.content_browsertests.filter

Comment 3 by sahel@chromium.org, May 9 2018

Status: Fixed (was: Assigned)

Sign in to add a comment