New issue
Advanced search Search tips

Issue 823285 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Add a form observer for autofill

Project Member Reported by olivierrobin@chromium.org, Mar 19 2018

Issue description

The form.js script is in /components/autofill/ios
The commands it triggers are un /ios/web

Move these handlers in components/autofill.
 

Comment 1 Deleted

Cc: eugene...@chromium.org
Status: Started (was: Assigned)
I started to work on this to prepare the iframe handling.

It seems that currently, the script command handlers added with AddScriptCommandCallback only work on main frame.

https://cs.chromium.org/chromium/src/ios/web/web_state/ui/crw_web_controller.mm?l=2314

The password controller works on all frames.

Can we change the limitation (and for example pass is_main_frame to the command callback)?

Thanks
Cc: michaeldo@chromium.org
Labels: -Type-Bug Type-Task
I think that ScriptCommandCallback callback will have Frame class argument, instead of a boolean. CCed Mike who is working to define iframes communication API.
I agree that we should use the WebFrame object here (and probably in most places in web instead of an is_main_frame boolean.)

However, if not having access to the is_main_frame state is blocking autofill preparations, maybe we should add the boolean for now? Then, we can replace it with the full details of the WebFrame object once it is available.
Thenks. As a temporary solution I will add a boolean.
We can replace it when WebFrame is available.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b03f402fb027dd8643a27824c93d22c4ef41bf9

commit 7b03f402fb027dd8643a27824c93d22c4ef41bf9
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Thu Jun 21 13:17:04 2018

Add is_main_frame parameter to ScriptCommandCallback

For compatibility, make all callbacks return false when is_main_frame is
false (current behavior).

Bug:  823285 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0bd4c7d1561df87f80c88b37e2342e4589a1fd24
Reviewed-on: https://chromium-review.googlesource.com/1105989
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569236}
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/components/translate/ios/browser/language_detection_controller.h
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/components/translate/ios/browser/language_detection_controller.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/components/translate/ios/browser/language_detection_controller_unittest.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/components/translate/ios/browser/translate_controller.h
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/components/translate/ios/browser/translate_controller.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/components/translate/ios/browser/translate_controller_unittest.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/chrome/browser/passwords/credential_manager.h
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/chrome/browser/passwords/credential_manager.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/chrome/browser/translate/js_language_detection_manager_unittest.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/chrome/browser/ui/payments/payment_request_manager.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/chrome/browser/web/print_tab_helper.h
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/chrome/browser/web/print_tab_helper.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web/public/test/earl_grey/web_view_actions.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web/public/web_state/web_state.h
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web/web_state/web_state_unittest.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web/webui/crw_web_ui_manager.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web_view/internal/cwv_web_view.mm
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web_view/public/cwv_script_command.h
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web_view/shell/shell_view_controller.m
[modify] https://crrev.com/7b03f402fb027dd8643a27824c93d22c4ef41bf9/ios/web_view/test/web_view_script_command_inttest.mm

Cc: mahmadi@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10168414bc04b4d38a8dcf5540b97728d4660278

commit 10168414bc04b4d38a8dcf5540b97728d4660278
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Mon Jul 09 09:13:58 2018

Create FormActivityObserver

Create a FormActivityObserver that will eventually replace the
WebStateObserver for form related events.
At the moment, this only forward WebStateObserver event.
Once every observer is switched to FormActivityObserver, the methods
will be removed from WebStateObserver.

Converts InsecureInputTabHelper as a first observer.

Bug:  823285 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia0e9c28e41dfcb032531a105f67ecb8791af682d
Reviewed-on: https://chromium-review.googlesource.com/1116999
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573250}
[modify] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/BUILD.gn
[rename] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/BUILD.gn
[rename] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/DEPS
[rename] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/fill_js_unittest.mm
[add] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/form_activity_observer.h
[add] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/form_activity_observer_bridge.h
[add] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/form_activity_observer_bridge.mm
[add] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/form_activity_tab_helper.h
[add] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/form_activity_tab_helper.mm
[rename] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/form_unittest.mm
[rename] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/resources/fill.js
[rename] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/components/autofill/ios/form_util/resources/form.js
[modify] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/ios/chrome/browser/DEPS
[modify] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/ios/chrome/browser/ssl/BUILD.gn
[modify] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/ios/chrome/browser/ssl/insecure_input_tab_helper.h
[modify] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/ios/chrome/browser/ssl/insecure_input_tab_helper.mm
[modify] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/10168414bc04b4d38a8dcf5540b97728d4660278/ios/web_view/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45e6b9e2048f355463a80281db9f3d4708eb0981

commit 45e6b9e2048f355463a80281db9f3d4708eb0981
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Tue Jul 17 14:10:04 2018

Migrate remaining calls to WebState form activity methods

- Create test utils
- Move the FormActivityTabHelper from WebStateObserver to Script callback
- Remove all the methods from WebState and WebStateObserver.

Bug:  823285 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0953a91144524018dbff154b2ff5b7bd18e17013
Reviewed-on: https://chromium-review.googlesource.com/1133000
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575630}
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/BUILD.gn
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/DEPS
[add] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/form_activity_observer_bridge_unittest.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/form_activity_tab_helper.h
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/form_activity_tab_helper.mm
[add] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/form_activity_tab_helper_unittest.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/form_unittest.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/resources/form.js
[add] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/test_form_activity_observer.h
[add] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/test_form_activity_observer.mm
[add] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/test_form_activity_tab_helper.h
[add] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/components/autofill/ios/form_util/test_form_activity_tab_helper.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/chrome/browser/autofill/form_suggestion_controller.h
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/public/test/fakes/crw_test_web_state_observer.h
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/public/test/fakes/crw_test_web_state_observer.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/public/test/fakes/test_web_state.h
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/public/test/fakes/test_web_state.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/public/test/fakes/test_web_state_observer.h
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/public/test/fakes/test_web_state_observer.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/public/web_state/web_state_observer.h
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/public/web_state/web_state_observer_bridge.h
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/web_state/web_state_observer_bridge.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web/web_state/web_state_observer_bridge_unittest.mm
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web_view/BUILD.gn
[modify] https://crrev.com/45e6b9e2048f355463a80281db9f3d4708eb0981/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66

commit 2bd8d9697eb55ae78d02028d68a6b7496ee0ee66
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Aug 22 15:47:14 2018

Create web::test::GetPageScript

This method can be used to configure the TestWebClient to inject scripts
needed for tests.
Also migrate other test methods in web::test

Bug:  823285 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie8a69a02defd2dd071b42b3c6654a7f25009af82
Reviewed-on: https://chromium-review.googlesource.com/1136301
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585027}
[delete] https://crrev.com/915214c2cce83f264385e0db77d3d4468aed1301/components/autofill/ios/form_util/DEPS
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/components/autofill/ios/form_util/form_activity_tab_helper_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/components/autofill/ios/form_util/form_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/components/translate/ios/browser/js_translate_manager_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/chrome/browser/autofill/js_suggestion_manager_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/chrome/browser/translate/js_language_detection_manager_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/chrome/browser/ui/static_content/static_html_view_controller_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/chrome/browser/web/chrome_web_client_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/chrome/browser/web/early_page_script_perftest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/BUILD.gn
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/browser_state_web_view_partition_inttest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/public/test/BUILD.gn
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/public/test/js_test_util.h
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/public/test/js_test_util.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/public/test/web_js_test.h
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/test/web_int_test.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/web_state/js/BUILD.gn
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/web_state/js/context_menu_js_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/web_state/js/crw_js_window_id_manager_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/web_state/js/page_script_util_unittest.mm
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web/web_state/ui/BUILD.gn
[modify] https://crrev.com/2bd8d9697eb55ae78d02028d68a6b7496ee0ee66/ios/web_view/internal/web_view_web_client_unittest.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31882dfe71e05fa2515a8725dce84e746f1d8893

commit 31882dfe71e05fa2515a8725dce84e746f1d8893
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Sep 05 08:32:39 2018

Rename FormActivityObserver callbacks

Rename OnFormActivity -> FormActivityRegistered
Rename DidSubmitDocument -> DocumentSubmitted

Bug:  823285 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4b02df2eb26e7af88e35dc92f24310220a2e57b6
Reviewed-on: https://chromium-review.googlesource.com/1193856
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588796}
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/form_util/form_activity_observer.h
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/form_util/form_activity_observer_bridge.h
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/form_util/form_activity_observer_bridge.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/form_util/form_activity_observer_bridge_unittest.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/form_util/form_activity_tab_helper.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/form_util/test_form_activity_observer.h
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/form_util/test_form_activity_observer.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/form_util/test_form_activity_tab_helper.h
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/autofill/ios/form_util/test_form_activity_tab_helper.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/components/password_manager/ios/password_controller_helper.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/ios/chrome/browser/ssl/insecure_input_tab_helper.h
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/ios/chrome/browser/ssl/insecure_input_tab_helper.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/31882dfe71e05fa2515a8725dce84e746f1d8893/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9

commit 26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Thu Sep 06 09:59:55 2018

Move FormActivityParams to components/autofill

The Form activity observer is now isolated from ios/web.
Move the FormActivityParams to the component.

Bug:  823285 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4a8b9184587214a4c57839440e5ef812557b917a
Reviewed-on: https://chromium-review.googlesource.com/1193880
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589123}
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/BUILD.gn
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/form_activity_observer.h
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/form_activity_observer_bridge.h
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/form_activity_observer_bridge.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/form_activity_observer_bridge_unittest.mm
[rename] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/form_activity_params.cc
[rename] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/form_activity_params.h
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/form_activity_tab_helper.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/test_form_activity_observer.h
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/test_form_activity_observer.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/test_form_activity_tab_helper.h
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/components/autofill/ios/form_util/test_form_activity_tab_helper.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/chrome/browser/autofill/form_input_accessory_view_provider.h
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/chrome/browser/autofill/form_suggestion_controller.h
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/chrome/browser/autofill/form_suggestion_controller.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/chrome/browser/ssl/insecure_input_tab_helper.h
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/chrome/browser/ssl/insecure_input_tab_helper.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/web/public/BUILD.gn
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/web/public/test/fakes/crw_test_web_state_observer.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/web/public/test/fakes/test_web_state_observer_util.h
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/web/web_state/BUILD.gn
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/26d5f1f5a5d6f1f97cb7e8775e351c728cac09f9/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment