OS: Mac Viz: --enable-features=VizDisplayCompositor Test Suite: browser_tests Test: PluginPowerSaverBrowserTest.SmallerThanPlayIcon Seeing a consistent failures on Mac for this test on the 10.13 FYI bot. However the stack trace is different in each run. Though the general trend of the stack traces seems to be that there are errors in handling the shutdown of different mojo pipes Example failures: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.13%2F1715%2F%2B%2Frecipes%2Fsteps%2Fviz_browser_tests_on_Intel_GPU_on_Mac%2F0%2Flogs%2FPluginPowerSaverBrowserTest.SmallerThanPlayIcon%2F0 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.13%2F1713%2F%2B%2Frecipes%2Fsteps%2Fviz_browser_tests_on_Intel_GPU_on_Mac%2F0%2Flogs%2FPluginPowerSaverBrowserTest.SmallerThanPlayIcon%2F0 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.13%2F1714%2F%2B%2Frecipes%2Fsteps%2Fviz_browser_tests_on_Intel_GPU_on_Mac%2F0%2Flogs%2FPluginPowerSaverBrowserTest.SmallerThanPlayIcon%2F0 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.13%2F1712%2F%2B%2Frecipes%2Fsteps%2Fviz_browser_tests_on_Intel_GPU_on_Mac%2F0%2Flogs%2FPluginPowerSaverBrowserTest.SmallerThanPlayIcon%2F0
Adding stack trace: 0 browser_tests base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 226 2 libsystem_platform.dyli _sigtramp + 26 3 libsystem_malloc.dylib tiny_free_no_lock + 570 4 browser_tests _ZZN4base9allocator35MallocZoneFunctionsToReplaceDefaultEvEN3$_18__invokeEP14_malloc_zone_tm + 45 5 browser_tests _ZZN4base9allocator35MallocZoneFunctionsToReplaceDefaultEvEN3$_18__invokeEP14_malloc_zone_tm + 45 6 libsystem_malloc.dylib malloc_zone_malloc + 103 7 libsystem_malloc.dylib malloc + 24 8 libc++abi.dylib operator new(unsigned long) + 40 9 browser_tests mojo::internal::MultiplexRouter::OnPipeConnectionError() + 504 10 browser_tests mojo::Connector::HandleError(bool, bool) + 372 11 browser_tests mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) + 248 12 browser_tests base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 184 13 browser_tests base::MessageLoop::RunTask(base::PendingTask*) + 468 14 browser_tests base::MessageLoop::DoWork() + 424 15 browser_tests base::MessagePumpCFRunLoopBase::RunWork() + 42 16 browser_tests base::mac::CallWithEHFrame(void () block_pointer) + 10 17 browser_tests base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63 18 CoreFoundation __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 19 CoreFoundation __CFRunLoopDoSource0 + 108 20 CoreFoundation __CFRunLoopDoSources0 + 208 21 CoreFoundation __CFRunLoopRun + 1293 22 CoreFoundation CFRunLoopRunSpecific + 483 23 HIToolbox RunCurrentEventLoopInMode + 286 24 HIToolbox ReceiveNextEventCommon + 613 25 HIToolbox _BlockUntilNextEventMatchingListInModeWithFilter + 64 26 AppKit _DPSNextEvent + 2085 27 AppKit -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 28 browser_tests __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64 29 browser_tests base::mac::CallWithEHFrame(void () block_pointer) + 10 30 browser_tests -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164 31 AppKit -[NSApplication run] + 764 32 browser_tests base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364 33 browser_tests base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 34 browser_tests base::RunLoop::Run() + 53 35 browser_tests content::RunMessageLoop() + 67 36 browser_tests PluginPowerSaverBrowserTest::VerifySnapshot(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 277 37 browser_tests PluginPowerSaverBrowserTest_SmallerThanPlayIcon_Test::RunTestOnMainThread() + 545 38 browser_tests content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 557 39 browser_tests ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4231 40 browser_tests ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 41 browser_tests content::BrowserMainLoop::PreMainMessageLoopRun() + 67 42 browser_tests content::StartupTaskRunner::RunAllTasksNow() + 39 43 browser_tests content::BrowserMainLoop::CreateStartupTasks() + 661 44 browser_tests content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96 45 browser_tests content::BrowserMain(content::MainFunctionParams const&) + 180 46 browser_tests content::ContentMainRunnerImpl::Run() + 377 47 browser_tests service_manager::Main(service_manager::MainParams const&) + 2323 48 browser_tests content::ContentMain(content::ContentMainParams const&) + 68 49 browser_tests content::BrowserTestBase::SetUp() + 2560 50 browser_tests InProcessBrowserTest::SetUp() + 399 51 browser_tests testing::Test::Run() + 97 52 browser_tests testing::TestInfo::Run() + 288 53 browser_tests testing::TestCase::Run() + 263 54 browser_tests testing::internal::UnitTestImpl::RunAllTests() + 855 55 browser_tests testing::UnitTest::Run() + 110 56 browser_tests base::TestSuite::Run() + 167 57 browser_tests ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37 58 browser_tests content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 389 I don't know what's going on here -- can someone more familiar with the mojo system in viz take a look?
Seems to be passing now. I'll re-enable it
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8d380f1abd0c6a2e9914c89a00478981342ba9a commit d8d380f1abd0c6a2e9914c89a00478981342ba9a Author: jonross <jonross@chromium.org> Date: Wed May 23 12:22:54 2018 Re-enable PluginPowerSaverBrowserTest on Viz It appears that PluginPowerSaverBrowserTest.SmallerThanPlayIcon on Mac for Viz has begun working again. This re-enables it. TBR=kylechar@chromium.org TEST=PluginPowerSaverBrowserTest.SmallerThanPlayIcon Bug: 823276 Change-Id: I6333f40c20da0622cc8bfe45da486922471e8307 Reviewed-on: https://chromium-review.googlesource.com/1069656 Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#561043} [modify] https://crrev.com/d8d380f1abd0c6a2e9914c89a00478981342ba9a/testing/buildbot/filters/viz.browser_tests.filter
Comment 1 by ccameron@chromium.org
, Apr 3 2018Owner: ----
Adding stack trace: 0 browser_tests base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 226 2 libsystem_platform.dyli _sigtramp + 26 3 libsystem_malloc.dylib tiny_free_no_lock + 570 4 browser_tests _ZZN4base9allocator35MallocZoneFunctionsToReplaceDefaultEvEN3$_18__invokeEP14_malloc_zone_tm + 45 5 browser_tests _ZZN4base9allocator35MallocZoneFunctionsToReplaceDefaultEvEN3$_18__invokeEP14_malloc_zone_tm + 45 6 libsystem_malloc.dylib malloc_zone_malloc + 103 7 libsystem_malloc.dylib malloc + 24 8 libc++abi.dylib operator new(unsigned long) + 40 9 browser_tests mojo::internal::MultiplexRouter::OnPipeConnectionError() + 504 10 browser_tests mojo::Connector::HandleError(bool, bool) + 372 11 browser_tests mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) + 248 12 browser_tests base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 184 13 browser_tests base::MessageLoop::RunTask(base::PendingTask*) + 468 14 browser_tests base::MessageLoop::DoWork() + 424 15 browser_tests base::MessagePumpCFRunLoopBase::RunWork() + 42 16 browser_tests base::mac::CallWithEHFrame(void () block_pointer) + 10 17 browser_tests base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63 18 CoreFoundation __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 19 CoreFoundation __CFRunLoopDoSource0 + 108 20 CoreFoundation __CFRunLoopDoSources0 + 208 21 CoreFoundation __CFRunLoopRun + 1293 22 CoreFoundation CFRunLoopRunSpecific + 483 23 HIToolbox RunCurrentEventLoopInMode + 286 24 HIToolbox ReceiveNextEventCommon + 613 25 HIToolbox _BlockUntilNextEventMatchingListInModeWithFilter + 64 26 AppKit _DPSNextEvent + 2085 27 AppKit -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 28 browser_tests __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64 29 browser_tests base::mac::CallWithEHFrame(void () block_pointer) + 10 30 browser_tests -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164 31 AppKit -[NSApplication run] + 764 32 browser_tests base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364 33 browser_tests base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 34 browser_tests base::RunLoop::Run() + 53 35 browser_tests content::RunMessageLoop() + 67 36 browser_tests PluginPowerSaverBrowserTest::VerifySnapshot(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 277 37 browser_tests PluginPowerSaverBrowserTest_SmallerThanPlayIcon_Test::RunTestOnMainThread() + 545 38 browser_tests content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 557 39 browser_tests ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4231 40 browser_tests ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 41 browser_tests content::BrowserMainLoop::PreMainMessageLoopRun() + 67 42 browser_tests content::StartupTaskRunner::RunAllTasksNow() + 39 43 browser_tests content::BrowserMainLoop::CreateStartupTasks() + 661 44 browser_tests content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96 45 browser_tests content::BrowserMain(content::MainFunctionParams const&) + 180 46 browser_tests content::ContentMainRunnerImpl::Run() + 377 47 browser_tests service_manager::Main(service_manager::MainParams const&) + 2323 48 browser_tests content::ContentMain(content::ContentMainParams const&) + 68 49 browser_tests content::BrowserTestBase::SetUp() + 2560 50 browser_tests InProcessBrowserTest::SetUp() + 399 51 browser_tests testing::Test::Run() + 97 52 browser_tests testing::TestInfo::Run() + 288 53 browser_tests testing::TestCase::Run() + 263 54 browser_tests testing::internal::UnitTestImpl::RunAllTests() + 855 55 browser_tests testing::UnitTest::Run() + 110 56 browser_tests base::TestSuite::Run() + 167 57 browser_tests ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37 58 browser_tests content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 389 I don't know what's going on here -- can someone more familiar with the mojo system in viz take a look?