VR: UI needs a click-on-disabled-button sound |
||||
Issue descriptionTibor, your comment about the sound on a disabled navigate-back button yielded a missing element in the UI audio spec. There is now a spec for this new sound. Related - where will we document the attenuation required for all UI sounds, so it can be looked up by anyone adding a new sound?
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/127b2129bb6dbb23d3614b65b00adc140719daaf commit 127b2129bb6dbb23d3614b65b00adc140719daaf Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Mar 19 19:21:46 2018 [vr] Add inactive button sound to assets Bug: 823272 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib9ef6c157ad0af0c50370b23bfa544d47b96046a Reviewed-on: https://chromium-review.googlesource.com/969102 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544108} [modify] https://crrev.com/127b2129bb6dbb23d3614b65b00adc140719daaf/chrome/browser/resources/vr/assets/VERSION [add] https://crrev.com/127b2129bb6dbb23d3614b65b00adc140719daaf/chrome/browser/resources/vr/assets/chromium/inactive_button_click.wav [add] https://crrev.com/127b2129bb6dbb23d3614b65b00adc140719daaf/chrome/browser/resources/vr/assets/google_chrome/inactive_button_click.wav.sha1 [modify] https://crrev.com/127b2129bb6dbb23d3614b65b00adc140719daaf/chrome/browser/resources/vr/assets/vr_assets_component_files.json
,
Mar 19 2018
,
Mar 19 2018
Split out UI work into issue 823413 . This bug will track the asset delivery and loading side.
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c41dad3a2c2debdf03158ff3f1ff8f253110386f commit c41dad3a2c2debdf03158ff3f1ff8f253110386f Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Mar 19 23:32:29 2018 [vr] Load inactive button click sound if available Bug: 823272 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I74cd47e699cd999ec4bd44a5e82fef71fd931d27 Reviewed-on: https://chromium-review.googlesource.com/969451 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544208} [modify] https://crrev.com/c41dad3a2c2debdf03158ff3f1ff8f253110386f/chrome/browser/vr/assets_loader.cc [modify] https://crrev.com/c41dad3a2c2debdf03158ff3f1ff8f253110386f/chrome/browser/vr/model/assets.h [modify] https://crrev.com/c41dad3a2c2debdf03158ff3f1ff8f253110386f/chrome/browser/vr/model/sound_id.h [modify] https://crrev.com/c41dad3a2c2debdf03158ff3f1ff8f253110386f/chrome/browser/vr/ui.cc
,
Mar 20 2018
,
Mar 20 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tiborg@chromium.org
, Mar 19 2018