Regression:Unable to drag the location entry from 'Weather' extension overlay
Reported by
vineetha...@etouch.net,
Mar 19 2018
|
||||||||
Issue descriptionChrome Version: 67.0.3375.0 (Official Build) Revision 9a9b208d93102cd427f37a45e2bdc28c07f23cbc-refs/heads/master@{#543961}(32/64 bit) OS: Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS) OS. Test URL: https://chrome.google.com/webstore/detail/weather/iolcbmjhmpdheggkocibajddahbeiglb/related?hl=en-GB What steps will reproduce the problem? (1) Launch Chrome, navigate to above URL and add 'Weather' extension to chrome. (2) Now click on the Weather extension icon to open the overlay. (3) Click on the down arrow below the location name to open another sub overlay. (4) Try to click on the three lines icon to drag the location entry Actual Result: Unable to drag the location entry from 'Weather' extension overlay. Expected Result: Should be able to drag the location entry from 'Weather' extension overlay. This is regression issue broken in ‘M-67’ and providing the bisect using per-revision bisect, Good build: 67.0.3371.0(Revision: 543279) Bad build: 67.0.3372.0 (Revision: 543590) You are probably looking for a change made after 543290 (known good), but no later than 543291 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/63667eca2a1d86f5de61f29c7c5c6417cc351757..3a3c78a924a686ed0d3f90d765b00cdd78453e11 Suspect: https://chromium.googlesource.com/chromium/src/+/3a3c78a924a686ed0d3f90d765b00cdd78453e11 @wangxianzhu: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Mar 20 2018
,
Mar 23 2018
The attached drag.zip is not a reduced test case, but can be used to reproduce and debug in content_shell. To reproduce: - unzip the attached drag.zip - open drag/drag.html in content_shell - wait until there is a red bar - move the mouse on the left area of the red bar and there will be a yellow rectangle - drag the yellow rectangle Expected (with --disable-features=SlimmingPaintV175): we can drag a half transparent yellow rectangle around Actual: nothing can be dragged around. The problem may be in https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp?rcl=b5d6aaf99248ccd8486dc2ebf63d18f5cb41c9df&l=94 about wrong property tree state.
,
Mar 23 2018
Here's the minimized repro: <!doctype html> <div id="container" style="position: absolute; top: 60px; z-index: 10;"> <div id="drag" draggable="true" style="width: 50px; height: 50px; background: blue;"></div> </div> With SPV175 (--enable-blink-features=SlimmingPaintV175): dragging the blue rectangle does not work. Without SPV175 (--disable-blink-features=SlimmingPaintV175): dragging blue rectangle works.
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41f6904a0a73db6d5ef31cc7e8648e743db1d9ee commit 41f6904a0a73db6d5ef31cc7e8648e743db1d9ee Author: Philip Rogers <pdr@chromium.org> Date: Sat Mar 24 08:32:11 2018 [SPv175] Fix transform space of drag images With Slimming Paint v1.75 (SPv175), PaintLayerPainter paints layer contents in the containing transform node's space. Not all layers create a transform space, such as a layer only used as a stacking context. This patch adjusts the painted output of a drag image by the offset from the layer to the layer's transform space. Bug: 823259 Change-Id: Ibd5bdba70979e94e07fd4398999c07eeef62548d Reviewed-on: https://chromium-review.googlesource.com/979166 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545682} [modify] https://crrev.com/41f6904a0a73db6d5ef31cc7e8648e743db1d9ee/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp [modify] https://crrev.com/41f6904a0a73db6d5ef31cc7e8648e743db1d9ee/third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp
,
Mar 25 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by wangxianzhu@chromium.org
, Mar 19 2018