New issue
Advanced search Search tips

Issue 823254 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Performance timing redirectEnd includes time for the page loading

Reported by taavo.t...@plumbr.io, Mar 19 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36

Steps to reproduce the problem:
1. Have a site where a link redirects after 1s to a page that loads after 500ms
2. Click on link to redirect
3. Check performance.timing

What is the expected behavior?
performance.timing.redirectEnd - performance.timing.redirectStart should be (around) 1000

What went wrong?
redirectEnd timestamp matches responseEnd, making redirectEnd - redirectStart be ~1500 (duration of redirect + page loading)

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 65.0.3325.162  Channel: stable
OS Version: 10.0
Flash Version: 

Additionally timings from fetchStart to connectEnd all also match responseEnd timestamp
 
redirects-test.zip
1.7 KB Download
redirect-chrome-bug.PNG
34.4 KB View Download
Components: -Blink>PerformanceAPIs Blink>PerformanceAPIs>NavigationTiming
Labels: Needs-Triage-M65

Comment 3 by maxlg@chromium.org, Mar 21 2018

Status: Available (was: Unconfirmed)
Verified that:
Chrome: performance.timing.redirectEnd - performance.timing.redirectStart = ~1500
Firefox: performance.timing.redirectEnd - performance.timing.redirectStart = ~1000

Move the bug to available.
 Vote for this issue and get email change notifications
Components: -Blink>PerformanceAPIs Blink>PerformanceAPIs>NavigationTiming
Verified that:
Chrome: performance.timing.redirectEnd - performance.timing.redirectStart = ~1500
Firefox: performance.timing.redirectEnd - performance.timing.redirectStart = ~1000

Move the bug to available.
Labels: -Pri-2 Pri-1
Owner: npm@chromium.org
Status: Assigned (was: Available)
P1: Do we have the same issue with nav timing 2?

If not, maybe this is P2.

We should have a test for this though.
Same result when using performance.getEntriesByType('navigation')
chrome-perftime2.png
54.9 KB View Download
redirects-test-2.zip
2.1 KB Download

Comment 9 by npm@chromium.org, May 8 2018

I'm able to reproduce the original test case but unable to reproduce the result in #8. I get pretty small values for the navigation entry. What Chrome version are you using for that?
That was with 66.0.3359.139 (current stable)

Tested just now with canary 68.0.3424.0 and both nav timings 1 & 2 methods seem fixed
chrome-canary-perftime-1.png
43.6 KB View Download
chrome-canary-perftime-2.png
58.2 KB View Download

Comment 11 by npm@chromium.org, May 17 2018

Labels: -Pri-1 Pri-2
Ok, thanks! In that case, reducing priority.
Ping from bug triage: Any update on this?
Cc: tommckee@chromium.org
Sorry, no update yet. CC Tom who might be interested in looking at this.
Sounds like a bisect between 68.0.3424.0 (canary) and 66.0.3359.139 (stable) could give us some insight into what happened to fix things per #10.
I'm running a bisect now... will update this bug if/when I find a candidate CL.
My bisect is implying the fix was introduced in 44cc16cdbb7589055303042d621336578b818d95 (CL: https://chromium-review.googlesource.com/981913).

I took a peek at the CL and it seems reasonable that the change fixed this issue.

What's the next step? Perhaps a regression test? Or just mark fixed?

I think a regression test would be nice and then we can mark this as Fixed. Do you want to take over that or shall I do it?
Cc: -tommckee@chromium.org npm@chromium.org
Owner: tommckee@chromium.org
I'll take it on.

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4c53cc3a3106373080ceedc6d21dc324e6654d

commit 1c4c53cc3a3106373080ceedc6d21dc324e6654d
Author: Tom McKee <tommckee@chromium.org>
Date: Tue Sep 11 12:28:13 2018

Adding a regression test against  crbug.com/823254 .

BUG= 823254 

Change-Id: Ibfa232b39e7003565ac68dba0e4e1aab9170c6fd
Reviewed-on: https://chromium-review.googlesource.com/1216845
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590272}
[modify] https://crrev.com/1c4c53cc3a3106373080ceedc6d21dc324e6654d/third_party/blink/renderer/core/loader/document_load_timing_test.cc

Status: Fixed (was: Assigned)
Regression test just landed... marking as fixed.

Sign in to add a comment