New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823238 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Unnecessary text continuation(...) is seen outside the app folder in App launcher

Project Member Reported by kebalaji@chromium.org, Mar 19 2018

Issue description

Chrome Version: 67.0.3374.0/10500.0.0 dev channel Daisy,Peppy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Click on App launcher>> Create any app folder and try naming the app folder with only spaces and observe

Actual: Unnecessary text continuation(...) is seen outside the folder 
Expected: No such text continuation(...) should be seen

This is a Non-Regression issue seen from M62

NOTE: Issue is seen on M63, M64, M65 and M66 also

@newcomer: Please confirm the issue
 
ActualFoldernamespace.webm
1.2 MB View Download
Owner: weidongg@chromium.org
Owner: newcomer@chromium.org
I already have a fix for this.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33ae92ea9d5db682c5ebe6ff8f2778920330d878

commit 33ae92ea9d5db682c5ebe6ff8f2778920330d878
Author: Alex Newcomer <newcomer@chromium.org>
Date: Wed Mar 21 18:05:19 2018

cros: Fix elipses in folder view.

Collapse whitespace when the FolderNameView loses focus.

Bug:  823238 
Change-Id: I9695853e61fc201be0e37a808e4503ba9787e1d8
Reviewed-on: https://chromium-review.googlesource.com/969650
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544768}
[modify] https://crrev.com/33ae92ea9d5db682c5ebe6ff8f2778920330d878/ui/app_list/views/folder_header_view.cc
[modify] https://crrev.com/33ae92ea9d5db682c5ebe6ff8f2778920330d878/ui/app_list/views/folder_header_view_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment