New issue
Advanced search Search tips

Issue 823221 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Toggle button get enabled/disabled after multiple tap/touch in chrome://settings.

Reported by pranjali...@etouch.net, Mar 19 2018

Issue description

Chrome Version: 67.0.3375.0 (Official Build) 9a9b208d93102cd427f37a45e2bdc28c07f23cbc-refs/heads/master@{#543961}(32/64 bit)
 
OS: Windows-10 Touch

Steps to reproduce:
1. Launch chrome and navigate to 'chrome://settings/'
2. Tap/touch continuously 4-5 times on Show bookmarks bar toggle button and observe. 

Actual: Toggle button get enabled/disabled after multiple tap/touch in chrome://settings.
Expected: Toggle button should get enabled/disabled on single tap/touch in chrome://settings.

This is Regression issue broken in 'M-67’ and Using the per-revision bisect providing the bisect results,

Good Build:67.0.3366.0 (Revision: 541889)
Bad Build:67.0.3367.0  (Revision: 542330) 

You are probably looking for a change made after 542268 (known good), but no later than 542269 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/346ac2e2bc15287477fd12a6bb2077256b35bf07..6e1cf7c20cc5285914ba2e6c876d322d8cafef49

Suspect: https://chromium.googlesource.com/chromium/src/+/6e1cf7c20cc5285914ba2e6c876d322d8cafef49

@dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note: 
1. Issue is not seen on Windows(7,8,8.1,10) , Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.4).
2. Issue is not seen using mouse click.

Kindly refer attached screen cast
 
Expected_result.mp4
297 KB View Download
Actual_result.mp4
345 KB View Download
Labels: TE-verified-67 TE-Verified-67.0.3375.0
Update:
Rechecked the above issue on Mac(10.12.6,10.13.1,10.13.4) using latest canary (build #67.0.3375.0) and fix is working as intended.
Please refer attached screen cast for the same.

Thank you...
Canary_behaviour.mov
7.5 MB View Download
Components: Internals>Input>Touch>Screen
Labels: -TE-Verified-67.0.3375.0 -TE-verified-67
Note: Please ignore my previous comment.

Comment 3 by dpa...@chromium.org, Mar 19 2018

Cc: dpa...@chromium.org
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
I don't have a Windows-10 Touch machine to try this. Was not able to reproduce on my Win10 with "device mode" on from DevTools. Either way, this seems like a bug that is unrelated to the Settings UI, and related to how touch events work (or don't work) in general on Windows-10 Touch.

Unassigning, for now, so that others that have such a machine can pick this up.
I think that the description/analysis of this bug is slightly misleading. I don't ever see the bookmarks button being disabled in the video, but I do see it not responding to taps sometimes. Is there any other indication of it being "disabled", or was that just a way of describing that it was not responding.

Does it ever not respond if you tap more slowly, perhaps once every couple of seconds?

I suspect that the issue is related to double-click versus single-click messages. When the user clicks the mouse once them a WM_LBUTTONDOWN message is sent, and a second click will be either the same message or WM_LBUTTONDBLCLK. For touch events the messages are ISG_TAP and ISG_DOUBLETAP. So, perhaps we changed something in our handling of ISG_DOUBLETAP messages. We don't handle them directly so it would have to be some difference in how Windows translates them to regular mouse messages.

Does the bug happen when toggling the home button, or just with the bookmarks bar button?

I cannot reproduce the button with chrome Canary on my surface laptop, using touch taps.

Comment 5 by dpa...@chromium.org, Mar 20 2018

Not sure if this is related, but mentioning it just in case. The UI code is utilizing the approach described at [1] to eliminate the 300ms delay that the browser used to wait to determine whether a double-tap would occur.

Specifically the way this is prevented is at [2], with the CSS "touch-action: manipulation;" rule. Could it be that this CSS rule is not working as expected on Windows10 Touch? 


[1] https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away
[2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings.html?l=14

Comment 6 by dpa...@chromium.org, Mar 20 2018

Cc: brucedaw...@chromium.org
> Could it be that this CSS rule is not working as expected on
> Windows10 Touch? 

Could be. A couple of things could help to better understand this bug:

1) What type of machine is this happening on? I can't reproduce it on my touch-screen SurfaceBook
2) Have any changes to the Windows input settings been made, such as changing the double-click timings?
3) Does the bug happen when toggling the home button, or just with the bookmarks bar button?

Answering the first two might help us reproduce the bug. Answering the second one might let us isolate possible causes, by hinting as to whether the bug happens with all buttons or just one.

Comment 8 by dpa...@chromium.org, Mar 23 2018

FYI, a similar issue is reported at issue 820888, which makes me think that there is something wrong with how touch events are implemented at a lower layer for Windows10 Touch setup.

Sign in to add a comment