New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 823220 link

Starred by 1 user
Status: Fixed
Owner:
█ yhong@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

factory: HWID database builder fails to handle the case of no region code probed.

Project Member Reported by yhong@chromium.org, Mar 19 2018 
When the developer runs `hwid build-database` on a device which region code is not set yet, the program will fail to generate the HWID database.

The attachment is the exception raised by the program.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/59949ab78ca625c86dfe84b0462feadca3bdea7f

commit 59949ab78ca625c86dfe84b0462feadca3bdea7f
Author: Yong Hong <yhong@chromium.org>
Date: Tue Mar 20 14:24:26 2018

hwid: Fix HWID database builder bug on `region_field`.

BUG= chromium:823220 
TEST=make test; manually run `hwid build-database`

Change-Id: I6e3c3156bc41376ad1495fd91f6735f8ff921f22
Reviewed-on: https://chromium-review.googlesource.com/968185
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Cheng-Han Yang <chenghan@chromium.org>

[modify] https://crrev.com/59949ab78ca625c86dfe84b0462feadca3bdea7f/py/hwid/v3/yaml_tags.py
[modify] https://crrev.com/59949ab78ca625c86dfe84b0462feadca3bdea7f/py/hwid/v3/database.py
[modify] https://crrev.com/59949ab78ca625c86dfe84b0462feadca3bdea7f/py/hwid/v3/builder.py

Comment 2 by yhong@chromium.org, Mar 30 2018

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-hwid/+/4b373871b637b92be89a564df076129ea0c4cf0b

commit 4b373871b637b92be89a564df076129ea0c4cf0b
Author: Cheng-Han Yang <chenghan@google.com>
Date: Mon Apr 16 16:20:37 2018
►

Sign in to add a comment