New issue
Advanced search Search tips

Issue 823210 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocking:
issue 857295



Sign in to add a comment

Adjust Skia Resource Cache according to the user definition for the device memory

Project Member Reported by gyuyoung...@chromium.org, Mar 19 2018

Issue description

As Skia font cache, according to my test locally, Skia resource cache has been used up to ~18mb (about 4mb on average) on chrome desktop. In the low-end device, they need to limit the memory usage of Skia's resource cache as well as font cache limitation. Please refer to https://bugs.chromium.org/p/chromium/issues/detail?id=274452.

So, it would be good if we can give the power users to limit the memory usage of Skia resource cache.

 
Owner: gyuyoung...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb496ebfd2066a9ac491f09d33c85e2ab3df1d3e

commit eb496ebfd2066a9ac491f09d33c85e2ab3df1d3e
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Mon Mar 19 11:26:02 2018

Pass the skia resource cache limit in the command line to renderer processes.

As skia font cache, we need to limit the memory usage of skia resource cache
for the low-end device as well. But, as the font cache, it's hard to estimate
what is the limit value the best for each low-end device. So it would be good
if we give them the power to limit to use the resource cache. This CL introduces
a new command line switch to limit the skia resource cache size.

Bug:  823210 
Change-Id: Icc55a8701fe2fa94bdc0ee09b428c19031c131a5
Reviewed-on: https://chromium-review.googlesource.com/968006
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544007}
[modify] https://crrev.com/eb496ebfd2066a9ac491f09d33c85e2ab3df1d3e/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/eb496ebfd2066a9ac491f09d33c85e2ab3df1d3e/content/public/common/content_switches.cc
[modify] https://crrev.com/eb496ebfd2066a9ac491f09d33c85e2ab3df1d3e/content/public/common/content_switches.h
[modify] https://crrev.com/eb496ebfd2066a9ac491f09d33c85e2ab3df1d3e/content/renderer/renderer_main.cc

Status: Fixed (was: Started)
Blocking: 857295

Sign in to add a comment