New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 823209 link

Starred by 4 users
Status: Fixed
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
█ manoranj...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
ligim...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Texts in print preview window goes blur upon hovering

Reported by khushal....@etouch.net, Mar 19 2018 
Chrome Version: 67.0.3375.0 (Official Build) Revision: 9a9b208d93102cd427f37a45e2bdc28c07f23cbc-refs/heads/master@{#543961} (32/64-bit)
 	
OS: Win(7, 8, 8.1, 10) 

What steps will reproduce the problem?
1. Launch chrome, and give print command.
2. In print preview window, try to select any option from the drop down list and hover the mouse on other texts and observe.

Actual Result: Texts in print preview window goes blur upon hovering.
Expected Result: Text should remain clear.

This is a regression issue, broken in M-67 series, and will soon update other info.

Good Build: 67.0.3374.0
Bad Build:  67.0.3375.0

Note: This Issue is seen only on devices with monitor resolution 1280 X 1024.

Thank You!

Comment 1 by khushal....@etouch.net, Mar 19 2018

Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67
Owner: junov@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-67 series, Using the per-revision bisect providing the bisect results,

Good Build: 67.0.3374.0 (Revision: 543950)
Bad Build:  67.0.3375.0 (Revision: 543961)

You are probably looking for a change made after 543954 (known good), but no later than 543955 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  
https://chromium.googlesource.com/chromium/src/+log/b9bc00e94c238c04749fd818b9c0ae05f1bd7248..c8f117ce2885070675675564dc39be7e92c6853d

Suspect: https://chromium.googlesource.com/chromium/src/+/c8f117ce2885070675675564dc39be7e92c6853d

@junov :Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
   
Thank You!
Actual Video.mp4
396 KB View Download
Expected Video.mp4
485 KB View Download

Comment 2 by nyerramilli@chromium.org, Mar 19 2018

Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Beta
marking as RBB, please change if required.

Comment 3 by junov@chromium.org, Mar 19 2018

Status: Started (was: Assigned)

Comment 4 by junov@chromium.org, Mar 19 2018

Labels: Needs-Feedback
I am unable to repro using a tip of tree dev build. I also tried Canary 67.0.3375.0 (same as in report), and was unable to repro. 

Could you attach the contents of your chrome://gpu page?

Comment 5 by junov@chromium.org, Mar 19 2018

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Changing from RBB to RBS. Reason: bug does not seem widespread. Specific to certain configurations.

Comment 6 by khushal....@etouch.net, Mar 20 2018 

W.r.t. comment #4, please find the attached screenshot for the contents of chrome://gpu page as requested.
chrome-gpu contents.png
896 KB View Download

Comment 7 by khushal....@etouch.net, Mar 20 2018

Labels: -Needs-Feedback

Comment 8 by dlong...@gmail.com, Mar 20 2018 

I'm seeing something similar simply when using a basic <select> element.  Upon changing a select value the page text goes all blocky/unreadable.  See attached animated GIF.
chrome_canary_67.0.3376.1_blocky_text.gif
1.4 MB View Download

Comment 9 by dlong...@gmail.com, Mar 20 2018 

For reference here is my chrome://gpu info
chrome_canary_67.0.3376.1_gpu_info.txt
24.4 KB View Download

Comment 10 by junov@chromium.org, Mar 20 2018 

In both of your chrome://gpu dumps, I am seeing these error messages: "glTexSubImage2D: invalid internalformat/format/type combination GL_BGRA_EXT/GL_RGB/GL_UNSIGNED_SHORT_5_6_5"

Could be a red herring, but I think this might be a good lead. Looks to me like a stale OpenGL texture binding.  Thanks for the info.

Comment 11 by junov@chromium.org, Mar 20 2018 

Update: A speculative fix is in the pipe: https://chromium-review.googlesource.com/c/chromium/src/+/972141
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c18cd561f9b5c335ae2c6a1bcaed501e285992c0

commit c18cd561f9b5c335ae2c6a1bcaed501e285992c0
Author: Justin Novosad <junov@chromium.org>
Date: Wed Mar 21 00:44:00 2018

Speculative fix for some skia-related rendering glitches

A number of rendering glitches have been reported after landing
https://chromium-review.googlesource.com/924616
I have not been able to reproduce any of these bugs using the hardware
at my disposal.  However, by inspecting the screenshots and other data
provided in the bug reports, I've ascertained that the cause is
probably a stale texture binding or a stale frame buffer binding.
Therefore, a likely cause is the under-invalidation of skia's GL state.
After a thorough manual review. I've found additional API entry points
that need to report state invalidations, which were not handled in the
CL that caused the regression (asuming it is indeed the cause).

Because I was not able to reproduce the bugs, I don't know which call
sites and which OpenGL entry points are to blame, and I am unable to
verify whether this fixes the bugs in question.  Will have to rely on
Canary channel users and test engineers for verification.

BUG=823608,823232, 823209 

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I67615825e87573674a2b93e4c9dd5017115d7c1c
Reviewed-on: https://chromium-review.googlesource.com/972141
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544604}
[modify] https://crrev.com/c18cd561f9b5c335ae2c6a1bcaed501e285992c0/gpu/skia_bindings/gles2_implementation_with_grcontext_support.cc
[modify] https://crrev.com/c18cd561f9b5c335ae2c6a1bcaed501e285992c0/gpu/skia_bindings/gles2_implementation_with_grcontext_support.h

Comment 13 by khushal....@etouch.net, Mar 21 2018 

Rechecked the above issue on latest Canary build #67.0.3377.0 for Windows OS (7, 8, 8.1, 10) and issue is still reproducible. Please refer the attached screencast.
Actual Video.mp4
617 KB View Download

Comment 14 by khushal....@etouch.net, Mar 22 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3378.0
Rechecked the above issue on latest Canary build #67.0.3378.0 for Windows OS (7, 8, 8.1, 10) and the issue is fixed. Please refer the attached screencast.
Fixed Video.mp4
629 KB View Download

Comment 15 by ligim...@chromium.org, Mar 22 2018

Cc: ligim...@chromium.org
Labels: -ReleaseBlock-Stable ReleaseBlock-Dev
Guessing Issue 823608 is a dupe of this bug, Justin please confirm the same. Also please merge the patch in #12 to 3377 branch, which is the Dev RC.

Even though this bug is tagged as RBS, few other rending issues were reported earlier, so we would like take this patch for Dev Release.

Comment 16 by junov@chromium.org, Mar 22 2018 

Offending patch was reverted to fix 823232  It is not clear whether this issue was fixed by the CL from #12 or the revert: https://chromium-review.googlesource.com/c/chromium/src/+/974064

Comment 17 by junov@chromium.org, Mar 22 2018 

Branch 3377 was cut at 544610, so it already includes the patch from #12.  If the bug is still visible in the branch, that means its the revert that fixed the issue and needs to be merged.

Comment 18 by junov@chromium.org, Mar 22 2018

Status: Fixed (was: Started)
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 22 2018

Labels: merge-merged-3377
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af5709eadad43b3cef11458d1bb019d9675a82b0

commit af5709eadad43b3cef11458d1bb019d9675a82b0
Author: Justin Novosad <junov@chromium.org>
Date: Thu Mar 22 17:32:29 2018

Revert "Automate calls to GrContext::resetContext"

This reverts commit c8f117ce2885070675675564dc39be7e92c6853d.
This reverts commit c18cd561f9b5c335ae2c6a1bcaed501e285992c0.

Reason for revert: causes rendering corruption in Android WebView

BUG=823232, 823209 
TBR=junov@chromium.org, piman@chromium.org

(cherry picked from commit 60f840e7e212c79d76e5e7fa32667214e050e20b)

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I56df8c34b7bbf2e80eb818f8ca4595f220dbffd0
Reviewed-on: https://chromium-review.googlesource.com/974064
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#544862}
Reviewed-on: https://chromium-review.googlesource.com/976050
Cr-Commit-Position: refs/branch-heads/3377@{#1}
Cr-Branched-From: d77b019f5aa49e13a58521f3b1e3604bd391be53-refs/heads/master@{#544610}
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/android_webview/browser/aw_render_thread_context_provider.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/android_webview/browser/aw_render_thread_context_provider.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/cc/raster/scoped_gpu_raster.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/cc/test/test_in_process_context_provider.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/common/gl_helper.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/common/gl_helper.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/common/gpu/context_provider.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/common/gpu/in_process_context_provider.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/common/gpu/in_process_context_provider.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/common/gpu/raster_context_provider.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/test/test_context_provider.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/test/test_context_support.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/components/viz/test/test_context_support.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/browser/gpu/gpu_ipc_browsertests.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/renderer/media_capture_from_element/canvas_capture_handler.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/renderer/webgraphicscontext3d_provider_impl.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/renderer/webgraphicscontext3d_provider_impl.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/content/test/layouttest_support.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/command_buffer/client/context_support.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/command_buffer/client/implementation_base.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/command_buffer/client/implementation_base.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/command_buffer/client/raster_implementation_gles_unittest.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/ipc/BUILD.gn
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/ipc/gl_in_process_context.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/skia_bindings/BUILD.gn
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h
[delete] https://crrev.com/d77b019f5aa49e13a58521f3b1e3604bd391be53/gpu/skia_bindings/gles2_implementation_with_grcontext_support.cc
[delete] https://crrev.com/d77b019f5aa49e13a58521f3b1e3604bd391be53/gpu/skia_bindings/gles2_implementation_with_grcontext_support.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/skia_bindings/grcontext_for_gles2_interface.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/gpu/skia_bindings/grcontext_for_gles2_interface.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/media/renderers/paint_canvas_video_renderer.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/services/ui/public/cpp/gpu/context_provider_command_buffer.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/services/ui/public/cpp/gpu/context_provider_command_buffer.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/third_party/WebKit/Source/platform/graphics/gpu/GraphicsContext3DUtils.cpp
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/third_party/WebKit/Source/platform/graphics/test/FakeWebGraphicsContext3DProvider.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/third_party/WebKit/public/platform/WebGraphicsContext3DProvider.h
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/ui/compositor/test/in_process_context_provider.cc
[modify] https://crrev.com/af5709eadad43b3cef11458d1bb019d9675a82b0/ui/compositor/test/in_process_context_provider.h

Comment 20 by ligim...@chromium.org, Mar 22 2018 

Verified in 67.0.3377.1, and is fixed now.

Comment 21 by rkalavakuntla@chromium.org, Mar 23 2018 

Tested this issue on Chrome OS version #67.0.3376.0/10510.0.0 dev channel with devices Daisy,Peppy as per the steps mentioned in Comment #0 and Observed no blur text in print preview upon hovering.

Attached the screencast for reference..
Thanks!
No blur text.mp4
4.5 MB View Download
►

Sign in to add a comment