[desktop-pwas] Low contrast ratio on origin text |
||||||||
Issue descriptionOrigin text in the app menu has a very low contrast ratio (BG #ffffff, FG #a8aa9b, contrast ratio = 2.4). (Guide suggests text should have minimum 4.5 CR.) This is the same colour as the keyboard shortcut info, inherited from the Chrome menu (out of scope of desktop PWAs project). However, perhaps the origin is more critical information than the keyboard shortcuts, so should have a higher CR? Hwi to decide whether to change.
,
Mar 23 2018
,
Mar 26 2018
,
Mar 27 2018
,
Mar 27 2018
There is a relevant comment on the UX review slide deck slide called "Known Issues".
,
Apr 3 2018
See c#1 for the color value.
,
Apr 6 2018
,
Apr 6 2018
Before and after screenshots of WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/999275
,
Apr 9 2018
@hwi: Should the colour of all minor text fields be updated to this contrast ratio rather than just the origin text? https://chromium-review.googlesource.com/c/chromium/src/+/999275/3/ui/native_theme/common_theme.cc#207
,
Apr 9 2018
Added this to the CL: Improving the contrast of the current minor text SGTM from UX POV. Thanks for the suggestion.
,
Apr 9 2018
LGTM. Thank you, alancutter@.
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5719d4005231a70554e0ab17d5c8ec6854b430d commit b5719d4005231a70554e0ab17d5c8ec6854b430d Author: Alan Cutter <alancutter@chromium.org> Date: Tue Apr 10 05:16:10 2018 Increase menu item minor text contrast This CL updates the minor text color to increase the contrast ratio to 4.5 where previously it was only 2.4. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=333305&signed_aid=nJkKAfQZwVySGN2WxDNekw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=333570&signed_aid=czXiHkbVYr98gGQf_RowuQ==&inline=1 Bug: 823197 Change-Id: I45a52eb1cf3782202d348a7617557ffc1ba6b139 Reviewed-on: https://chromium-review.googlesource.com/999275 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#549426} [modify] https://crrev.com/b5719d4005231a70554e0ab17d5c8ec6854b430d/chrome/browser/ui/libgtkui/native_theme_gtk2.cc [modify] https://crrev.com/b5719d4005231a70554e0ab17d5c8ec6854b430d/chrome/browser/ui/libgtkui/native_theme_gtk3.cc [modify] https://crrev.com/b5719d4005231a70554e0ab17d5c8ec6854b430d/ui/native_theme/common_theme.cc [modify] https://crrev.com/b5719d4005231a70554e0ab17d5c8ec6854b430d/ui/native_theme/native_theme.h [modify] https://crrev.com/b5719d4005231a70554e0ab17d5c8ec6854b430d/ui/native_theme/native_theme_dark_aura.cc [modify] https://crrev.com/b5719d4005231a70554e0ab17d5c8ec6854b430d/ui/views/controls/menu/menu_item_view.cc
,
Apr 10 2018
,
May 10 2018
Verified on M68 (10663.0.0, 68.0.3425.0). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hwi@chromium.org
, Mar 19 2018