New issue
Advanced search Search tips

Issue 823195 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus does not traverse on download list.

Reported by shruti.j...@etouch.net, Mar 19 2018 
Chrome Version: 67.0.3374.0 (Official Build) (64-bit)Revision c98d55f133677d5281011be711833a488825ff5f-refs/heads/master@{#543949}

OS: Win(7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.4) & Linux(14.04 LTS)


What steps will reproduce the problem?
(1)Launch chrome and Download any NTP.
(2)Navigate to chrome://downloads and Press tab and observe.

Actual: Focus does not traverse on download list.

Expected: Focus should traverse on download list.


This is a regression issue broken in 'M67' and will soon provide the bisect-info:
Good Build: 67.0.3272.0 
Bad Build:  67.0.3273.0
Actual.mov
17.6 MB Download
Expected.mov
4.8 MB View Download

Comment 1 by shruti.j...@etouch.net, Mar 19 2018

Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-67 and providing the bisect using Per-Revision script:
Good Build : 67.0.3372.0(Revision:543593)
Bad Build : 67.0.3373.0 (Revision:543879)

You are probably looking for a change made after 543615 (known good), but no later than 543616 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  
https://chromium.googlesource.com/chromium/src/+log/b35d9a7018b2e7ea651518411978e2bd93b46729..42944a0ed387ac5ada7af465cc20655aad417d19

Suspect:https://chromium.googlesource.com/chromium/src/+/42944a0ed387ac5ada7af465cc20655aad417d19

@Christopher Lam : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0b25eb06bb2c44a19479150feb1a9825d7e31ba

commit e0b25eb06bb2c44a19479150feb1a9825d7e31ba
Author: Christopher Lam <calamity@chromium.org>
Date: Thu Mar 22 02:05:47 2018

[cr-action-menu] Fix focus trapping on cr-action-menus.

This CL fixes focus getting trapped by the cr-action-menu which has
tabindex set on it. Since this is moved to the internal dialog, it
can be removed from the host.

Bug:  823195 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I88f012f9d94c31557917a64ae64c34ef0472a836
Reviewed-on: https://chromium-review.googlesource.com/968044
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544947}
[modify] https://crrev.com/e0b25eb06bb2c44a19479150feb1a9825d7e31ba/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

Comment 3 by calamity@chromium.org, Mar 22 2018

Status: Fixed (was: Assigned)

Comment 4 by shruti.j...@etouch.net, Mar 23 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3379.0
Update : 
Retested above issue in latest Canary #67.0.3379.0 build on Mac(10.12.6, 10.13.1, 10.13.4), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Kindly review an attached screen-cast.

Thank you!
Canary#67.0.3379.0_behaviour.mov
3.6 MB View Download
►

Sign in to add a comment