New issue
Advanced search Search tips

Issue 823190 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Header buttons briefly flash on file selection and deselection

Project Member Reported by dats@chromium.org, Mar 19 2018

Issue description

From  Issue 764675 

But I found some other short flashes of different buttons, e.g. "share" button when you select many files in Drive appears for a moment and then disappears, or "open" button disappears when files in the selection are of unknown type, etc. Not sure if that's animation delay or what, it's not very noticeable, but creates impression of some sluggishness and not polished experience.
 

Comment 1 by noel@chromium.org, Mar 19 2018

Cc: sa...@chromium.org weifangsun@chromium.org
sammc@ showed me the flashing.  Select a file observe the header buttons.

Now deselect the file: and the buttons (notably the OPEN button) appear to move to right as adjacent buttons like the share-icon are removed, before the OPEN button is itself removed.  User perceives as a "flash".

Possible fix: work out all the buttons to be removed on file de-selection. Make the DOM state change needed for that, _happen in a single pass_ [1].

[1] maybe it's { visibility: hidden } for these buttons, whatever, dunno, but
currently it seems each of these buttons is acting for itself, and updating the header independently of the other buttons who want to do the same thing: remove themselves from the header.

Comment 2 by noel@chromium.org, Mar 19 2018

Labels: -Pri-2 Pri-3
P3 no milestone as yet.

Comment 3 by sashab@chromium.org, Mar 28 2018

Status: Available (was: Untriaged)

Comment 4 by dats@chromium.org, Apr 12 2018

Graying-out/disabling non-operation buttons would be more user-friendly behavior than reshuffling the while toolbar on every section change, like normal desktop apps do.
Labels: Files-Fixit-2018
Owner: noel@chromium.org
Status: Fixed (was: Available)
The buttons don't seem to flicker anymore.
Status: Verified (was: Fixed)

Sign in to add a comment