New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823170 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 726619



Sign in to add a comment

[PIP] Implement frame for PiP window to allow it be draggable.

Project Member Reported by apaci...@chromium.org, Mar 19 2018

Issue description

The PiP window is currently non-draggable. Add a custom frame, which allows the user to drag the edges of the window to resize.
 
Blocking: 726619
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bae7c89f8beeccef5877021ad490999472864222

commit bae7c89f8beeccef5877021ad490999472864222
Author: Jennifer Apacible <apacible@chromium.org>
Date: Wed Apr 11 05:17:10 2018

[Picture in Picture] Add custom frame for window.

This change adds a custom views::NonClientFrameView for
OverlayWindowViews and modifies some of the views::Widget params.

The window continues to lack a title bar (min, max, close). It now
can be resized by dragging the edges of the window and dragged around
the display by dragging the contents of the window (not edges).

This changes does not take into account keeping aspect ratio or updating
the size of the embedded surface.

BUG:  823170   726621 
Change-Id: I4cba98ee2c36fae55105e9d088d6b95fe97cd636
Reviewed-on: https://chromium-review.googlesource.com/1006167
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549772}
[modify] https://crrev.com/bae7c89f8beeccef5877021ad490999472864222/chrome/browser/ui/views/overlay/overlay_window_views.cc

Status: Fixed (was: Assigned)
Components: Blink>Media>PictureInPicture

Sign in to add a comment