New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 823156 link

Starred by 1 user
Status: Assigned
Owner:
█ lushnikov@chromium.org
Last visit 28 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Snapshot are 1 pixel shorter than expected

Reported by gianluca...@gmail.com, Mar 18 2018 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/601.7.7 (KHTML, like Gecko) Version/9.1.2 Safari/601.7.7

Steps to reproduce the problem:
1. open dev tool
2. select Pixel2 screen layout  (1080x1920)
3. click "capture snapshot"

What is the expected behavior?
an image 1080x1920

What went wrong?
got an image 1079x1919

Did this work before? N/A 

Chrome version: <Copy from: 'about:version'>  Channel: n/a
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 29.0 r0

Comment 1 by woxxom@gmail.com, Mar 18 2018 

The device resolution is defined using logical pixels 731x411 @ 2.625, not physical:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json?l=500&rcl=29b26a4ba97065b4247debb2a5c759dacb8c5a88

  731 * 2.625 = 1918,875 -> 1919 px

The definitions should probably switch to using physical pixels or alternatively fractional values for the logical dimensions.

Comment 2 by gianluca...@gmail.com, Mar 18 2018 

understand... so is this one a bug or a feature? :-)

Comment 3 by krajshree@chromium.org, Mar 19 2018

Labels: Needs-Milestone

Comment 4 by eostroukhov@chromium.org, Mar 19 2018

Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 5 by dgozman@chromium.org, May 7 2018

Owner: lushnikov@chromium.org
Andrey, please take a look.
►

Sign in to add a comment