New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823155 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Don't show pragmatic uninstall dialog for webstore

Project Member Reported by bdea@google.com, Mar 18 2018

Issue description

The chrome.management.uninstall api shows the pragmatic uninstall dialog for extensions. Web Store is considered a hosted app. So if Web Store calls the uninstall api the uninstall dialog will show "Web Store wants to uninstall this extension."


 

Comment 1 by bdea@google.com, Mar 18 2018

Description: Show this description

Comment 2 by bdea@google.com, Mar 18 2018

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7264a04b6a618b8dd8dfa898940ee2e2e1f68483

commit 7264a04b6a618b8dd8dfa898940ee2e2e1f68483
Author: Bettina Dea <bdea@chromium.org>
Date: Fri Apr 06 04:27:45 2018

Don't show programmatic uninstall dialog for webstore.

The current chrome.management.uninstall api shows the programmatic
uninstall dialog for extensions uninstalling other extensions. Web Store
is treated as a hosted app. Thus in order not to show "Web store wants
to uninstall this extension" I added a check to make sure the uninstall
is not coming from the Web Store. I also added an uninstall source for
web store so we can track which uninstall pings come from the store.

Bug: 823155
Change-Id: I73c1e53ffaadcddd930e34032db2acda6cb9867f
Reviewed-on: https://chromium-review.googlesource.com/966485
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548669}
[modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/chrome/browser/extensions/api/management/management_api_unittest.cc
[modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/chrome/browser/extensions/extension_uninstall_dialog.cc
[modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/chrome/browser/extensions/extension_uninstall_dialog.h
[modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/extensions/browser/uninstall_reason.h

Comment 4 by bdea@google.com, Apr 6 2018

Labels: -Pri-3 Pri-2
Pls apply appropriate OSs label. Thank you.

Comment 6 by bdea@google.com, Apr 6 2018

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 7 by jawag@chromium.org, Apr 23 2018

Just confirming, is this on track for M67?

Sign in to add a comment