Don't show pragmatic uninstall dialog for webstore |
||||
Issue descriptionThe chrome.management.uninstall api shows the pragmatic uninstall dialog for extensions. Web Store is considered a hosted app. So if Web Store calls the uninstall api the uninstall dialog will show "Web Store wants to uninstall this extension."
,
Mar 18 2018
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7264a04b6a618b8dd8dfa898940ee2e2e1f68483 commit 7264a04b6a618b8dd8dfa898940ee2e2e1f68483 Author: Bettina Dea <bdea@chromium.org> Date: Fri Apr 06 04:27:45 2018 Don't show programmatic uninstall dialog for webstore. The current chrome.management.uninstall api shows the programmatic uninstall dialog for extensions uninstalling other extensions. Web Store is treated as a hosted app. Thus in order not to show "Web store wants to uninstall this extension" I added a check to make sure the uninstall is not coming from the Web Store. I also added an uninstall source for web store so we can track which uninstall pings come from the store. Bug: 823155 Change-Id: I73c1e53ffaadcddd930e34032db2acda6cb9867f Reviewed-on: https://chromium-review.googlesource.com/966485 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#548669} [modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc [modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/chrome/browser/extensions/api/management/management_api_unittest.cc [modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/chrome/browser/extensions/extension_uninstall_dialog.cc [modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/chrome/browser/extensions/extension_uninstall_dialog.h [modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/extensions/browser/api/management/management_api.cc [modify] https://crrev.com/7264a04b6a618b8dd8dfa898940ee2e2e1f68483/extensions/browser/uninstall_reason.h
,
Apr 6 2018
,
Apr 6 2018
Pls apply appropriate OSs label. Thank you.
,
Apr 6 2018
,
Apr 23 2018
Just confirming, is this on track for M67? |
||||
►
Sign in to add a comment |
||||
Comment 1 by bdea@google.com
, Mar 18 2018