New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823154 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make olddefconfig work on older kernels

Project Member Reported by kirtika@google.com, Mar 18 2018

Issue description

OS: R67

`./chromeos/scripts/kernelconfig olddefconfig`
works to renormalize configs without any further user-input on 3.18, 4.4 and 4.14. Try to cherry-pick to 3.8, 3.10 and 3.14. 

 
Cc: kirtika@chromium.org
Owner: briannorris@chromium.org
Status: Started (was: Untriaged)
I did part of this just for reviewing some stuff the other day, so I just finished it off and uploaded CLs.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

Labels: merge-merged-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ba70bc4ff6225f888fc7b47b41f9c4a660c18ed0

commit ba70bc4ff6225f888fc7b47b41f9c4a660c18ed0
Author: Marc Herbert <marc.herbert@intel.com>
Date: Wed Mar 21 20:25:55 2018

CHROMIUM: kernelconfig: replace silentoldconfig calls with oldconfig

silentconfig has become an internal interface, not meant to
be used anymore: https://lkml.org/lkml/2017/12/18/1640

The only two differences are:
- silentoldconfig actually generates the configuration source in
  include/{generated/,config/}. Not relevant here.
- silentoldconfig doesn't re-order/reformat .config when nothing is missing
  from it. Harmful here.

BUG= chromium:823154 
TEST=Find a pure normalization commit 'H' in git log -- chromeos/config/
  - checkout the (denormalized) the H~1 commit just before it
  - cherry-pick this on top
  - run ./chromeos/scripts/kernelconfig oldconfig
  - git diff H -- chromeos/config shows no difference

Change-Id: I582c63301fffd4cbf4d9bd819fff6aada9ddafb8
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/972587
Commit-Ready: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/ba70bc4ff6225f888fc7b47b41f9c4a660c18ed0/chromeos/scripts/kernelconfig

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/840c1e416b9fa0465bf79b3e0b877e2854a9cf91

commit 840c1e416b9fa0465bf79b3e0b877e2854a9cf91
Author: Marc Herbert <marc.herbert@intel.com>
Date: Wed Mar 21 20:25:51 2018

CHROMIUM: kernelconfig: replace silentoldconfig calls with oldconfig

silentconfig has become an internal interface, not meant to
be used anymore: https://lkml.org/lkml/2017/12/18/1640

The only two differences are:
- silentoldconfig actually generates the configuration source in
  include/{generated/,config/}. Not relevant here.
- silentoldconfig doesn't re-order/reformat .config when nothing is missing
  from it. Harmful here.

BUG= chromium:823154 
TEST=Find a pure normalization commit 'H' in git log -- chromeos/config/
  - checkout the (denormalized) the H~1 commit just before it
  - cherry-pick this on top
  - run ./chromeos/scripts/kernelconfig oldconfig
  - git diff H -- chromeos/config shows no difference

Change-Id: I582c63301fffd4cbf4d9bd819fff6aada9ddafb8
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/972566
Commit-Ready: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/840c1e416b9fa0465bf79b3e0b877e2854a9cf91/chromeos/scripts/kernelconfig

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2018

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0020374fd7d9216860e34d91f5200991110fa6b9

commit 0020374fd7d9216860e34d91f5200991110fa6b9
Author: Marc Herbert <marc.herbert@intel.com>
Date: Wed Mar 21 20:25:59 2018

CHROMIUM: kernelconfig: replace silentoldconfig calls with oldconfig

silentconfig has become an internal interface, not meant to
be used anymore: https://lkml.org/lkml/2017/12/18/1640

The only two differences are:
- silentoldconfig actually generates the configuration source in
  include/{generated/,config/}. Not relevant here.
- silentoldconfig doesn't re-order/reformat .config when nothing is missing
  from it. Harmful here.

BUG= chromium:823154 
TEST=Find a pure normalization commit 'H' in git log -- chromeos/config/
  - checkout the (denormalized) the H~1 commit just before it
  - cherry-pick this on top
  - run ./chromeos/scripts/kernelconfig oldconfig
  - git diff H -- chromeos/config shows no difference

Change-Id: I582c63301fffd4cbf4d9bd819fff6aada9ddafb8
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/972573
Commit-Ready: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/0020374fd7d9216860e34d91f5200991110fa6b9/chromeos/scripts/kernelconfig

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e5474ccb5dabe21efd45326dd9feea986ba8089c

commit e5474ccb5dabe21efd45326dd9feea986ba8089c
Author: Marc Herbert <marc.herbert@intel.com>
Date: Thu Mar 22 01:30:50 2018

CHROMIUM: kernelconfig: add olddefconfig target

This is part of an effort to tame denormalized split configs:
- this lets developers normalize configs much faster;
- it allows I23bb52d9c08e77a4 or similar to warn when split configs are
  de-normalized.

BUG= chromium:823154 
TEST=find and checkout the parent of a normalization commit:
  git log --oneline --grep ormalize -- chromeos/config
  git checkout e3510b3f2887^ # (just an example - try HEAD too)
Apply this patch. Run the new olddefconfig target:
  ./chromeos/scripts/kernelconfig olddefconfig
  git diff chromeos/config/ |
        grep '' && echo 'ERROR: split configs denormalized'

Change-Id: Ibee3b87ddccd17c388f2a86e65adf9e0379eba0d
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/972588
Commit-Ready: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/e5474ccb5dabe21efd45326dd9feea986ba8089c/chromeos/scripts/kernelconfig

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/9d975629907f317fb3eb38788be4ab992c8b38ba

commit 9d975629907f317fb3eb38788be4ab992c8b38ba
Author: Marc Herbert <marc.herbert@intel.com>
Date: Thu Mar 22 01:30:48 2018

CHROMIUM: kernelconfig: add olddefconfig target

This is part of an effort to tame denormalized split configs:
- this lets developers normalize configs much faster;
- it allows I23bb52d9c08e77a4 or similar to warn when split configs are
  de-normalized.

BUG= chromium:823154 
TEST=find and checkout the parent of a normalization commit:
  git log --oneline --grep ormalize -- chromeos/config
  git checkout e3510b3f2887^ # (just an example - try HEAD too)
Apply this patch. Run the new olddefconfig target:
  ./chromeos/scripts/kernelconfig olddefconfig
  git diff chromeos/config/ |
        grep '' && echo 'ERROR: split configs denormalized'

Change-Id: Ibee3b87ddccd17c388f2a86e65adf9e0379eba0d
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/972567
Commit-Ready: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/9d975629907f317fb3eb38788be4ab992c8b38ba/chromeos/scripts/kernelconfig

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/fc4f999cf8ae330300619475f421c57f1de62217

commit fc4f999cf8ae330300619475f421c57f1de62217
Author: Marc Herbert <marc.herbert@intel.com>
Date: Thu Mar 22 01:30:43 2018

CHROMIUM: kernelconfig: add olddefconfig target

This is part of an effort to tame denormalized split configs:
- this lets developers normalize configs much faster;
- it allows I23bb52d9c08e77a4 or similar to warn when split configs are
  de-normalized.

BUG= chromium:823154 
TEST=find and checkout the parent of a normalization commit:
  git log --oneline --grep ormalize -- chromeos/config
  git checkout e3510b3f2887^ # (just an example - try HEAD too)
Apply this patch. Run the new olddefconfig target:
  ./chromeos/scripts/kernelconfig olddefconfig
  git diff chromeos/config/ |
        grep '' && echo 'ERROR: split configs denormalized'

Change-Id: Ibee3b87ddccd17c388f2a86e65adf9e0379eba0d
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/972574
Commit-Ready: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/fc4f999cf8ae330300619475f421c57f1de62217/chromeos/scripts/kernelconfig

Status: Fixed (was: Started)

Sign in to add a comment