New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823147 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::LayoutBlockFlow::XPositionForFloatIncludingMargin

Project Member Reported by ClusterFuzz, Mar 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5237319343538176

Fuzzer: marty_html_twiddler
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x612000049a00
Crash State:
  blink::LayoutBlockFlow::XPositionForFloatIncludingMargin
  blink::LayoutBlockFlow::AddOverflowFromFloats
  blink::LayoutBlock::SimplifiedLayout
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=531706:531716

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5237319343538176

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 18 2018

Components: Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: ikilpatrick@chromium.org xiaoche...@chromium.org e...@chromium.org futhark@chromium.org
Very strange. Nothing in the blame list looks relevant. It looks like |child.GetLayoutObject()| has been freed and then this method is being called. +layout folks, can you please investigate this further?
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 19 2018

Labels: M-66
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 19 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 19 2018

Labels: Pri-1
Cc: kateso...@chromium.org

Comment 7 by e...@chromium.org, Mar 19 2018

Owner: cbiesin...@chromium.org
Status: Assigned (was: Untriaged)
Christian, could you look into this please? The regression range is suspicious (requested a re-run) but the failure is real.

Comment 8 by mmoroz@chromium.org, Mar 30 2018

cbiesinger@, please take a look as per c#7. This is a High severity security issue affecting Beta branch.
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 2 2018

cbiesinger: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Just a heads up, M66 Stable cut is on April 12th, 10 days away. This issue is marked as RB-Stable for 66. Please make sure to address this issue prior to stable cut. Thanks! 
Reminder: Please note that M66 Stable is only 7 days away. This bug has been marked as ReleaseBlock Stable for M66. So please take a look and appropriately address this bug. 
Labels: -ReleaseBlock-Stable
Status: WontFix (was: Assigned)
Flaky test case, per email thread.
Project Member

Comment 13 by sheriffbot@chromium.org, Jul 20

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment