New issue
Advanced search Search tips

Issue 823144 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
WebRTC-1.0-Spec-Compliance


Sign in to add a comment

implement RTCPeerConnection.connectionState

Reported by fi...@appear.in, Mar 18 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/64.0.3282.167 Chrome/64.0.3282.167 Safari/537.36

Steps to reproduce the problem:
1. check 'connectionState' in RTCPeerConnection

What is the expected behavior?
see http://w3c.github.io/webrtc-pc/#rtcpeerconnectionstate-enum et al

What went wrong?
Chrome mixes up connectionstate and emits a combined ice/dtls state as iceconnectionstatechange.

Migrating developers might actually be the bigger problem here. Adding connectionState as an alias for iceConnectionState might be a good first step.

Also this makes it look like chrome has a significantly higher iceconnection setup time (30%) than Firefox since in Chrome the setup time includes the DTLS handshake whereas in Firefox it does not.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 64.0.3282.167  Channel: n/a
OS Version: 
Flash Version:
 
Labels: Needs-Triage-M64

Comment 2 by guidou@chromium.org, Mar 19 2018

Components: -Blink>WebRTC Blink>WebRTC>PeerConnection
Owner: hbos@chromium.org
Status: Assigned (was: Unconfirmed)
Owner: jonasolsson@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93094c4962f94a897a6601a75724e4b2db329fae

commit 93094c4962f94a897a6601a75724e4b2db329fae
Author: Jonas Olsson <jonasolsson@chromium.org>
Date: Fri Nov 23 14:42:26 2018

Add RTCPeerConnection.connectionState and onconnectionstatechange.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/lxHPNYoaEU8/0JFwF0ipCQAJ

Bug:  chromium:823144 
Change-Id: Ia849f44d1c8898da0fcb8341c8ff56de4de2d815
Reviewed-on: https://chromium-review.googlesource.com/c/1292560
Commit-Queue: Jonas Olsson <jonasolsson@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610603}
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/content/renderer/media/webrtc/rtc_peer_connection_handler.cc
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/content/renderer/media/webrtc/rtc_peer_connection_handler.h
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-connectionState-expected.txt
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-connectionState.html
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-constructor-expected.txt
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/blink/public/platform/web_rtc_peer_connection_handler_client.h
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/blink/renderer/core/events/event_type_names.json5
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.h
[modify] https://crrev.com/93094c4962f94a897a6601a75724e4b2db329fae/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.idl

Status: Fixed (was: Started)

Sign in to add a comment