[css-grid] repeat(auto-fill, ...) creates one more track than necessary when only min-width/height is definite |
|||
Issue descriptionChrome Version: 67.0.3371.0 (Official Build) dev (64-bit) OS: Linux What steps will reproduce the problem? (1)load the attached testcase (2) (3) What is the expected result? see test What happens instead? see test Fwiw, it works correctly in Firefox.
,
Mar 20 2018
,
Mar 23 2018
Thank you for the report Mats. This should be already fixed in ToT.
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e14c9f41fada84c7162a659e0194d5150ff7d293 commit e14c9f41fada84c7162a659e0194d5150ff7d293 Author: Sergio Villar Senin <svillar@igalia.com> Date: Fri Mar 23 11:26:59 2018 [css-grid] Fix auto repeat tracks computation with definite min sizes Indefinitely sized containers use the specified definite min-size (if any) as available space in order to compute the number of auto repeat tracks to create. A bug in that code was causing the grid to be one track larger than expected. That was only happening in the case of the free space being a multiple of the total size of the autorepeat tracks. Bug: 823140 Change-Id: I6cc13df478da4ba00585fa557012391291941d1a Reviewed-on: https://chromium-review.googlesource.com/973522 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#545403} [add] https://crrev.com/e14c9f41fada84c7162a659e0194d5150ff7d293/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/grid-definition/grid-inline-auto-repeat-001.html [modify] https://crrev.com/e14c9f41fada84c7162a659e0194d5150ff7d293/third_party/WebKit/Source/core/layout/LayoutGrid.cpp |
|||
►
Sign in to add a comment |
|||
Comment 1 by r...@igalia.com
, Mar 19 2018Status: Available (was: Untriaged)