New issue
Advanced search Search tips

Issue 823116 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in void base::Pickle::WriteBytesStatic<4ul>

Project Member Reported by ClusterFuzz, Mar 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6325606879592448

Fuzzer: inferno_twister
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  void base::Pickle::WriteBytesStatic<4ul>
  IPC::TupleParamTraitsHelper<std::__1::tuple<std::__1::basic_string<char, std::__
  IPC::MessageT<LayoutTestHostMsg_SimulateWebNotificationClick_Meta, std::__1::tup
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=541771:541772

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6325606879592448

Additional requirements: Requires HTTP

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 18 2018

Components: Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 18 2018

Labels: Test-Predator-Auto-Owner
Owner: c.pa...@samsung.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/636394fb5626827fd9c15e0a60df4ce9fe8af6f0 (Introduce InputDeviceInfo interface).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 18 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 18 2018

Labels: Pri-1

Comment 5 by c.pa...@samsung.com, Mar 19 2018

Cc: guidou@chromium.org
Labels: Test-Predator-Wrong-CL
The call stack does not relate to the changes in  https://chromium.googlesource.com/chromium/src/+/636394fb5626827fd9c15e0a60df4ce9fe8af6f0 (Introduce InputDeviceInfo interface). As per the callstack, the crash seems to be due to an uninitialized value sent across the IPC LayoutTestHostMsg_SimulateWebNotificationClick. However, the CL in question does not have any change related to this IPC. It seems like this CL has been wrongly picked.

Comment 6 by guidou@chromium.org, Mar 19 2018

Owner: peter@chromium.org
Removing c.padhi@ as owner, since this issue is unrelated to the suspected CL.

Assigning to peter@, who is more familiar with the test runner and the IPC message involved in the issue, for further triaging.

Comment 7 by est...@chromium.org, Mar 19 2018

Labels: M-67

Comment 8 by peter@chromium.org, Mar 19 2018

Labels: -ReleaseBlock-Stable
Content shell is a testing-only target, so there is no reason for this to block any release.

The LayoutTestHostMsg_SimulateWebNotificationClick message hasn't changed for well over a year. Is it possible that it means a message with a similar signature, as we sometimes see for callbacks? The parameters for this one are always populated on the Send() path.
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 20 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by ClusterFuzz, Mar 22 2018

ClusterFuzz has detected this issue as fixed in range 544993:544996.

Detailed report: https://clusterfuzz.com/testcase?key=6325606879592448

Fuzzer: inferno_twister
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  void base::Pickle::WriteBytesStatic<4ul>
  IPC::TupleParamTraitsHelper<std::__1::tuple<std::__1::basic_string<char, std::__
  IPC::MessageT<LayoutTestHostMsg_SimulateWebNotificationClick_Meta, std::__1::tup
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=541771:541772
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=544993:544996

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6325606879592448

Additional requirements: Requires HTTP

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Mar 22 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6325606879592448 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 22 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 28 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment