[PIP] Add and enable for modern media controls. |
||||
Issue descriptionCurrently PiP is enabled for legacy media controls. Add for modern controls.
,
Apr 5 2018
The newly added test here is failing on multiple platforms: Mac: https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/687574 * media/picture-in-picture/controls/picture-in-picture-video-with-audio-only-button.html * virtual/picture-in-picture/media/picture-in-picture/controls/picture-in-picture-video-with-audio-only-button.html Windows: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/138173 * media/picture-in-picture/controls/picture-in-picture-video-with-audio-only-button.html * virtual/picture-in-picture/media/picture-in-picture/controls/picture-in-picture-video-with-audio-only-button.html Reverting.
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/253ec1175121a9f74ac1ddbabe64429849a0c82a commit 253ec1175121a9f74ac1ddbabe64429849a0c82a Author: Kenneth Russell <kbr@chromium.org> Date: Thu Apr 05 10:02:31 2018 Revert "[Picture in Picture] Add modern media control." This reverts commit a776bce43e66547197918b212ce1236c80298980. Reason for revert: new layout test is failing on multiple platforms; see https://bugs.chromium.org/p/chromium/issues/detail?id=823109#c2 . Original change's description: > [Picture in Picture] Add modern media control. > > Currently, there is only a PiP button for the legacy / non-modern > set of media controls. This adds and enables the modern version. > > BUG: 726619 823109 > Change-Id: Iddb2d8393d5cf519bb6e32639d5f640bc341fc6f > Reviewed-on: https://chromium-review.googlesource.com/966980 > Commit-Queue: apacible <apacible@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548358} TBR=mlamouri@chromium.org,apacible@chromium.org,steimel@chromium.org Change-Id: I8b2b26e40ed3743858c99d993a1535899bfcbf36 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/997612 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548378} [delete] https://crrev.com/d90e694fc6f5199e727200f6b36f361351497344/third_party/WebKit/LayoutTests/media/picture-in-picture/controls/picture-in-picture-video-with-audio-only-button.html [modify] https://crrev.com/253ec1175121a9f74ac1ddbabe64429849a0c82a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [delete] https://crrev.com/d90e694fc6f5199e727200f6b36f361351497344/third_party/WebKit/Source/modules/media_controls/resources/ic_picture_in_picture.svg [modify] https://crrev.com/253ec1175121a9f74ac1ddbabe64429849a0c82a/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04c9faaae4480434d5b9bb55e86a51b7ca067adb commit 04c9faaae4480434d5b9bb55e86a51b7ca067adb Author: Jennifer Apacible <apacible@chromium.org> Date: Fri Apr 06 05:01:54 2018 Reland "[Picture in Picture] Add modern media control." This is a reland of a776bce43e66547197918b212ce1236c80298980 This updates the utils filepath so the new test passes. Original change's description: > [Picture in Picture] Add modern media control. > > Currently, there is only a PiP button for the legacy / non-modern > set of media controls. This adds and enables the modern version. > > BUG: 726619 823109 > Change-Id: Iddb2d8393d5cf519bb6e32639d5f640bc341fc6f > Reviewed-on: https://chromium-review.googlesource.com/966980 > Commit-Queue: apacible <apacible@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548358} TBR=mlamouri@chromium.org,steimel@chromium.org BUG: 726619 823109 Change-Id: I311c137f70b8e5f2ee2681ac8ffd022f2a272d8a Reviewed-on: https://chromium-review.googlesource.com/998078 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#548675} [add] https://crrev.com/04c9faaae4480434d5b9bb55e86a51b7ca067adb/third_party/WebKit/LayoutTests/media/picture-in-picture/controls/picture-in-picture-video-with-audio-only-button.html [modify] https://crrev.com/04c9faaae4480434d5b9bb55e86a51b7ca067adb/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [add] https://crrev.com/04c9faaae4480434d5b9bb55e86a51b7ca067adb/third_party/WebKit/Source/modules/media_controls/resources/ic_picture_in_picture.svg [modify] https://crrev.com/04c9faaae4480434d5b9bb55e86a51b7ca067adb/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
,
Apr 6 2018
,
Apr 6 2018
,
Apr 18 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Apr 5 2018